All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers
Date: Wed, 17 Apr 2019 16:04:49 +0100	[thread overview]
Message-ID: <20190417150449.GA1807@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <5465672.Kypt5CsLy1@xps>

On Wed, Apr 17, 2019 at 04:59:53PM +0200, Thomas Monjalon wrote:
> 10/04/2019 22:52, Bruce Richardson:
> > if either gcc or clang are missing, skip doing those builds.
> > This allows a setup to only do, e.g. gcc tests.
> > 
> > CC: stable@dpdk.org
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > --- a/devtools/test-meson-builds.sh
> > +++ b/devtools/test-meson-builds.sh
> >  # shared and static linked builds with gcc and clang
> >  for c in gcc clang ; do
> > -	for s in static shared ; do
> > -		export CC="ccache $c"
> > -		build build-$c-$s --default-library=$s
> > -	done
> > +	if command -v $c >/dev/null 2>&1 ; then
> > +		for s in static shared ; do
> > +			export CC="ccache $c"
> > +			build build-$c-$s --default-library=$s
> > +		done
> > +	fi
> 
> May I suggest this oneline change instead?
> 
> command -v $c >/dev/null 2>&1 || continue
> 
Looks fine to me. Make the change on apply if you like, otherwise let me
know if you want a V2.

  reply	other threads:[~2019-04-17 15:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 20:52 [dpdk-dev] [PATCH 0/3] fix test-meson-builds for older distros Bruce Richardson
2019-04-10 20:52 ` [dpdk-dev] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers Bruce Richardson
2019-04-17 14:59   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-04-17 15:04     ` Bruce Richardson [this message]
2019-04-10 20:52 ` [dpdk-dev] [PATCH 2/3] devtools/test-meson-builds: support older compilers Bruce Richardson
2019-04-10 20:52 ` [dpdk-dev] [PATCH 3/3] devtools/test-meson-builds: fix bash-isms Bruce Richardson
2019-04-11  8:48 ` [dpdk-dev] [PATCH 0/3] fix test-meson-builds for older distros Luca Boccassi
2019-04-17 15:17   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417150449.GA1807@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.