All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 09/15] vl: Make -machine $TYPE, help and -accel help print to stdout
Date: Wed, 17 Apr 2019 21:06:35 +0200	[thread overview]
Message-ID: <20190417190641.26814-10-armbru@redhat.com> (raw)
In-Reply-To: <20190417190641.26814-1-armbru@redhat.com>

Command line help help explicitly requested by the user should be
printed to stdout, not stderr.  We do elsewhere.  Adjust -machine
$TYPE,help and -accel help to match: use printf() instead of
error_printf().

Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
 vl.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/vl.c b/vl.c
index 9877972d97..190c773176 100644
--- a/vl.c
+++ b/vl.c
@@ -1556,12 +1556,12 @@ static int machine_help_func(QemuOpts *opts, MachineState *machine)
             continue;
         }
 
-        error_printf("%s.%s=%s", MACHINE_GET_CLASS(machine)->name,
-                     prop->name, prop->type);
+        printf("%s.%s=%s", MACHINE_GET_CLASS(machine)->name,
+               prop->name, prop->type);
         if (prop->description) {
-            error_printf(" (%s)\n", prop->description);
+            printf(" (%s)\n", prop->description);
         } else {
-            error_printf("\n");
+            printf("\n");
         }
     }
 
@@ -3643,7 +3643,7 @@ int main(int argc, char **argv, char **envp)
                                                      optarg, true);
                 optarg = qemu_opt_get(accel_opts, "accel");
                 if (!optarg || is_help_option(optarg)) {
-                    error_printf("Possible accelerators: kvm, xen, hax, tcg\n");
+                    printf("Possible accelerators: kvm, xen, hax, tcg\n");
                     exit(0);
                 }
                 opts = qemu_opts_create(qemu_find_opts("machine"), NULL,
-- 
2.17.2

  parent reply	other threads:[~2019-04-17 19:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 19:06 [Qemu-devel] [PATCH v3 00/15] Clean up use of error_printf() Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 01/15] qemu-img: Use error_vreport() in error_exit() Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 02/15] block/ssh: Do not report read/write/flush errors to the user Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 03/15] loader-fit: Wean off error_printf() Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 04/15] mips/boston: Report errors with error_report(), not error_printf() Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 05/15] pci: Report fatal " Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 06/15] hpet: Report warnings with warn_report(), " Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 07/15] vfio: " Markus Armbruster
2019-04-17 22:05   ` Alex Williamson
2019-04-18  6:18     ` Markus Armbruster
2019-04-18 16:36       ` Alex Williamson
2019-04-18 20:25         ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 08/15] s390x/kvm: " Markus Armbruster
2019-04-17 19:06 ` Markus Armbruster [this message]
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 10/15] monitor error: Make printf()-like functions return a value Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 11/15] qemu-print: New qemu_printf(), qemu_vprintf() etc Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 12/15] blockdev: Make -drive format=help print to stdout Markus Armbruster
2019-04-17 19:06   ` Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 13/15] char: Make -chardev help " Markus Armbruster
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 14/15] char-pty: Print "char device redirected" message " Markus Armbruster
2019-04-17 19:31   ` Eric Blake
2019-04-17 19:06 ` [Qemu-devel] [PATCH v3 15/15] monitor: Simplify how -device/device_add print help Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417190641.26814-10-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.