From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D647FC282DC for ; Wed, 17 Apr 2019 20:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FE442183E for ; Wed, 17 Apr 2019 20:52:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="lpLDpoue" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733154AbfDQUwY (ORCPT ); Wed, 17 Apr 2019 16:52:24 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:43783 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732992AbfDQUwR (ORCPT ); Wed, 17 Apr 2019 16:52:17 -0400 Received: by mail-qt1-f194.google.com with SMTP id i14so144221qtr.10 for ; Wed, 17 Apr 2019 13:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z49qLCfJaLviSo+toqZfclNdDqJnm041NoS1xnZAwc4=; b=lpLDpoueVMr4FddKq+fpht4f++JFEuZ2PvXbHmz39KGvlbE4xaHWJu+dNjVEbxxkoN 4udKjDVLI5XNNR0M6XVoNr9d97fK7pgr4kqomqsIhgB0q1UQb/YAF2mONj4UsVKpolQs c9HgWrTIj2O11IUWEZWrEqnloWXq8pnsYgOWzgcL05tx74A5u5kLv6CU/gbP7x29OUY2 3NSFroZPyndnmhpLNPElFwsEVPb2XFqnzQRo+VDoxvJubXuQpAOA3fhwjHt4R/zpUDxS ACc2okLGh7YJQVG6xBJndXz309bOagrQ3uyDosnGcjGH+EiBMR8+nllcTpXgcXzS0IFS +AgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z49qLCfJaLviSo+toqZfclNdDqJnm041NoS1xnZAwc4=; b=qbHTFyCjDdHEDDhbsHicxGdKqpSAIumXskeMzFVwMN9VfqD6N69NMhLqezlRYcS3sl UakPyNl1RGsEcBZoXsvwPvYVglf2ZIxXEDFWItR9lyssS2Gkk8SbjhEEvSeZ05Y3knci AoeVi8y4JVQ5gzZMnBkJx0uM2p96o8n0FGhmnhFIZWRtaRPcxCzIX8ApgsspM6oMpFFm civOZ8gt4paFadACDItyo9Mk0YDu+HAs+CT/gfghnSrR955pCjZiQ/1phBPgf7iGx/mw 7Mk05OqZFCgLep9S2A7t08BmEQBPLjczjn0QP20UMPf//V9eNuxFMj9pRX40GycNKgF/ k9lg== X-Gm-Message-State: APjAAAUSJK79jwahnVFkjInEDcHWECaxxWiQoY2jKa1jkwXFOT9HYexs drjPjm5Sd8o7o+JjJ5vlo8NBuw== X-Google-Smtp-Source: APXvYqzgG4LQ74rpPA3hiXdm1j/NWpLJ59yRMBD77YpJ9lmet3zC2pMJseLlKkIrO/dvthiukxnuwg== X-Received: by 2002:aed:3726:: with SMTP id i35mr71556882qtb.35.1555534336621; Wed, 17 Apr 2019 13:52:16 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d34sm60247qta.18.2019.04.17.13.52.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 13:52:16 -0700 (PDT) From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jakub Kicinski , Dirk van der Merwe Subject: [PATCH net-next 4/5] net: gemini: remove unnecessary assert Date: Wed, 17 Apr 2019 13:51:58 -0700 Message-Id: <20190417205159.30938-5-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190417205159.30938-1-jakub.kicinski@netronome.com> References: <20190417205159.30938-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver does not advertize NETIF_F_FRAGLIST, the stack can't pass skbs with frags lists to the xmit function. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/cortina/gemini.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 949103db8a8a..9003eb6716cd 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -1235,8 +1235,6 @@ static int gmac_start_xmit(struct sk_buff *skb, struct net_device *netdev) int txq_num, nfrags; union dma_rwptr rw; - SKB_FRAG_ASSERT(skb); - if (skb->len >= 0x10000) goto out_drop_free; -- 2.21.0