From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1E6C282DA for ; Wed, 17 Apr 2019 21:21:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91C5F2183F for ; Wed, 17 Apr 2019 21:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387454AbfDQVVS (ORCPT ); Wed, 17 Apr 2019 17:21:18 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:50946 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfDQVVR (ORCPT ); Wed, 17 Apr 2019 17:21:17 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hGrzT-0007xA-Is; Wed, 17 Apr 2019 21:21:11 +0000 Date: Wed, 17 Apr 2019 22:21:11 +0100 From: Al Viro To: Arnd Bergmann Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Andrew Donnellan , Felipe Balbi , Frederic Barrat , Frank Haverkamp , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Jerry Zhang , Vincent Pelletier , Andrzej Pietrasiewicz , Shen Jing , linuxppc-dev@lists.ozlabs.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers Message-ID: <20190417212111.GX2217@ZenIV.linux.org.uk> References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202013.4034148-11-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416202013.4034148-11-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 16, 2019 at 10:19:48PM +0200, Arnd Bergmann wrote: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, compat_ptr() > does not do anything, but using the new compat_ptr_ioctl() > helper makes it more correct in theory, and simplifies the code. > > Acked-by: Greg Kroah-Hartman > Acked-by: Andrew Donnellan > Acked-by: Felipe Balbi > Signed-off-by: Arnd Bergmann > --- > drivers/misc/cxl/flash.c | 8 +------- > drivers/misc/genwqe/card_dev.c | 23 +---------------------- > drivers/scsi/megaraid/megaraid_mm.c | 28 +--------------------------- > drivers/usb/gadget/function/f_fs.c | 12 +----------- ACK, provided that all their ioctls are taking pointers (which is worth mentioning in commit message, assuming it's true) From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,10/26] compat_ioctl: use correct compat_ptr() translation in drivers From: Al Viro Message-Id: <20190417212111.GX2217@ZenIV.linux.org.uk> Date: Wed, 17 Apr 2019 22:21:11 +0100 To: Arnd Bergmann Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Andrew Donnellan , Felipe Balbi , Frederic Barrat , Frank Haverkamp , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Jerry Zhang , Vincent Pelletier , Andrzej Pietrasiewicz , Shen Jing , linuxppc-dev@lists.ozlabs.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gVHVlLCBBcHIgMTYsIDIwMTkgYXQgMTA6MTk6NDhQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBBIGhhbmRmdWwgb2YgZHJpdmVycyBhbGwgaGF2ZSBhIHRyaXZpYWwgd3JhcHBlciBh cm91bmQgdGhlaXIgaW9jdGwKPiBoYW5kbGVyLCBidXQgZG9uJ3QgY2FsbCB0aGUgY29tcGF0X3B0 cigpIGNvbnZlcnNpb24gZnVuY3Rpb24gYXQgdGhlCj4gbW9tZW50LiBJbiBwcmFjdGljZSB0aGlz IGRvZXMgbm90IG1hdHRlciwgc2luY2Ugbm9uZSBvZiB0aGVtIGFyZSB1c2VkCj4gb24gdGhlIHMz OTAgYXJjaGl0ZWN0dXJlIGFuZCBmb3IgYWxsIG90aGVyIGFyY2hpdGVjdHVyZXMsIGNvbXBhdF9w dHIoKQo+IGRvZXMgbm90IGRvIGFueXRoaW5nLCBidXQgdXNpbmcgdGhlIG5ldyBjb21wYXRfcHRy X2lvY3RsKCkKPiBoZWxwZXIgbWFrZXMgaXQgbW9yZSBjb3JyZWN0IGluIHRoZW9yeSwgYW5kIHNp bXBsaWZpZXMgdGhlIGNvZGUuCj4gCj4gQWNrZWQtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3Jl Z2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gQWNrZWQtYnk6IEFuZHJldyBEb25uZWxsYW4gPGFu ZHJldy5kb25uZWxsYW5AYXUxLmlibS5jb20+Cj4gQWNrZWQtYnk6IEZlbGlwZSBCYWxiaSA8ZmVs aXBlLmJhbGJpQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPgo+IC0tLQo+ICBkcml2ZXJzL21pc2MvY3hsL2ZsYXNoLmMgICAgICAg ICAgICB8ICA4ICstLS0tLS0tCj4gIGRyaXZlcnMvbWlzYy9nZW53cWUvY2FyZF9kZXYuYyAgICAg IHwgMjMgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9zY3NpL21lZ2FyYWlkL21l Z2FyYWlkX21tLmMgfCAyOCArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMv dXNiL2dhZGdldC9mdW5jdGlvbi9mX2ZzLmMgIHwgMTIgKy0tLS0tLS0tLS0tCgpBQ0ssIHByb3Zp ZGVkIHRoYXQgYWxsIHRoZWlyIGlvY3RscyBhcmUgdGFraW5nIHBvaW50ZXJzICh3aGljaCBpcwp3 b3J0aCBtZW50aW9uaW5nIGluIGNvbW1pdCBtZXNzYWdlLCBhc3N1bWluZyBpdCdzIHRydWUpCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers Date: Wed, 17 Apr 2019 22:21:11 +0100 Message-ID: <20190417212111.GX2217@ZenIV.linux.org.uk> References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202013.4034148-11-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190416202013.4034148-11-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Andrew Donnellan , Felipe Balbi , Frederic Barrat , Frank Haverkamp , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Jerry Zhang , Vincent Pelletier , Andrzej Pietrasiewicz , Shen Jing , linuxppc-dev@list List-Id: linux-scsi@vger.kernel.org On Tue, Apr 16, 2019 at 10:19:48PM +0200, Arnd Bergmann wrote: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, compat_ptr() > does not do anything, but using the new compat_ptr_ioctl() > helper makes it more correct in theory, and simplifies the code. > > Acked-by: Greg Kroah-Hartman > Acked-by: Andrew Donnellan > Acked-by: Felipe Balbi > Signed-off-by: Arnd Bergmann > --- > drivers/misc/cxl/flash.c | 8 +------- > drivers/misc/genwqe/card_dev.c | 23 +---------------------- > drivers/scsi/megaraid/megaraid_mm.c | 28 +--------------------------- > drivers/usb/gadget/function/f_fs.c | 12 +----------- ACK, provided that all their ioctls are taking pointers (which is worth mentioning in commit message, assuming it's true) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34768C282DA for ; Wed, 17 Apr 2019 21:23:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AB63217FA for ; Wed, 17 Apr 2019 21:23:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AB63217FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44kwFQ1Wt6zDqPC for ; Thu, 18 Apr 2019 07:23:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=ftp.linux.org.uk (client-ip=195.92.253.2; helo=zeniv.linux.org.uk; envelope-from=viro@ftp.linux.org.uk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44kwCj1hGlzDqNR for ; Thu, 18 Apr 2019 07:21:34 +1000 (AEST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hGrzT-0007xA-Is; Wed, 17 Apr 2019 21:21:11 +0000 Date: Wed, 17 Apr 2019 22:21:11 +0100 From: Al Viro To: Arnd Bergmann Subject: Re: [PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers Message-ID: <20190417212111.GX2217@ZenIV.linux.org.uk> References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202013.4034148-11-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416202013.4034148-11-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shen Jing , linux-scsi@vger.kernel.org, y2038@lists.linaro.org, Frank Haverkamp , Kashyap Desai , Felipe Balbi , Jerry Zhang , "James E.J. Bottomley" , linux-fsdevel@vger.kernel.org, Vincent Pelletier , megaraidlinux.pdl@broadcom.com, Felipe Balbi , "Martin K. Petersen" , Shivasharan S , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Andrzej Pietrasiewicz , Sumit Saxena , Andrew Donnellan , Frederic Barrat , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 16, 2019 at 10:19:48PM +0200, Arnd Bergmann wrote: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, compat_ptr() > does not do anything, but using the new compat_ptr_ioctl() > helper makes it more correct in theory, and simplifies the code. > > Acked-by: Greg Kroah-Hartman > Acked-by: Andrew Donnellan > Acked-by: Felipe Balbi > Signed-off-by: Arnd Bergmann > --- > drivers/misc/cxl/flash.c | 8 +------- > drivers/misc/genwqe/card_dev.c | 23 +---------------------- > drivers/scsi/megaraid/megaraid_mm.c | 28 +--------------------------- > drivers/usb/gadget/function/f_fs.c | 12 +----------- ACK, provided that all their ioctls are taking pointers (which is worth mentioning in commit message, assuming it's true)