All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Kochan <vadim4j@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 1/1] docs/adding-packages-generic.txt: Add note if package does not use source
Date: Thu, 18 Apr 2019 00:48:58 +0300	[thread overview]
Message-ID: <20190417214858.ede4xzogjreibkes@vkochan-ThinkPad-T470p> (raw)
In-Reply-To: <7ae95e75-4a5a-006a-db84-bc6b327849e4@mind.be>

Hi Arnout, All,

On Wed, Apr 17, 2019 at 11:30:56PM +0200, Arnout Vandecappelle wrote:
> 
> 
> On 17/04/2019 09:17, Vadim Kochan wrote:
> > Add some description how to allow to add package which does not need
> > any source code.
> > 
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
> >  docs/manual/adding-packages-generic.txt | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> > index 7be1754f54..96a57a519a 100644
> > --- a/docs/manual/adding-packages-generic.txt
> > +++ b/docs/manual/adding-packages-generic.txt
> > @@ -223,8 +223,13 @@ not and can not work as people would expect it should:
> >    which Buildroot will use to download the tarball from
> >    +LIBFOO_SITE+. If +HOST_LIBFOO_SOURCE+ is not specified, it defaults
> >    to +LIBFOO_SOURCE+. If none are specified, then the value is assumed
> > -  to be +libfoo-$(LIBFOO_VERSION).tar.gz+. +
> > -  Example: +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
> > +  to be +libfoo-$(LIBFOO_VERSION).tar.gz+.
> > +  In case when the package does not use any source code (e.g. only performs
> > +  some target/host altering), then +LIBFOO_SOURCE+ should be specified
> > +  with empty value. +
> > +  Examples:
> > +    +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
> > +    +LIBFOO_SOURCE =
> 
>  I'm probably stupid, but when is this needed? E.g. skeleton-init-sysv doesn't
> have any code, and it doesn't set _SOURCE to empty...
> 
>  Regards,
>  Arnout

Ohhh, So now I realize what was wrong ... looks like I got issue when I
use _VERSION in my custom package but it failed to "build" w/o _SOURCE
because _SOURCE automatically was set including this _VERSION value, and
only after I set "*_SOURCE=" then it fixed my problem. OK, this patch is
wrong, I will drop it. Thanks for point it!

Regards,
Vadim Kochan
> 
> >  
> >  * +LIBFOO_PATCH+ may contain a space-separated list of patch file
> >    names, that Buildroot will download and apply to the package source
> > 

      reply	other threads:[~2019-04-17 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  7:17 [Buildroot] [RFC 1/1] docs/adding-packages-generic.txt: Add note if package does not use source Vadim Kochan
2019-04-17 21:30 ` Arnout Vandecappelle
2019-04-17 21:48   ` Vadim Kochan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417214858.ede4xzogjreibkes@vkochan-ThinkPad-T470p \
    --to=vadim4j@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.