All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v3 03/16] PM / devfreq: tegra: Replace write memory barrier with the read barrier
Date: Thu, 18 Apr 2019 01:29:12 +0300	[thread overview]
Message-ID: <20190417222925.5815-4-digetx@gmail.com> (raw)
In-Reply-To: <20190417222925.5815-1-digetx@gmail.com>

The write memory barrier isn't needed because the BUS buffer is flushed
by read after write that happens after the removed wmb(), we will also
use readl() instead of the relaxed version to ensure that read is indeed
completed.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/devfreq/tegra-devfreq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index f7378a42d184..7d7b9a5895b2 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -243,8 +243,7 @@ static void tegra_devfreq_update_wmark(struct tegra_devfreq *tegra,
 static void actmon_write_barrier(struct tegra_devfreq *tegra)
 {
 	/* ensure the update has reached the ACTMON */
-	wmb();
-	actmon_readl(tegra, ACTMON_GLB_STATUS);
+	readl(tegra->regs + ACTMON_GLB_STATUS);
 }
 
 static void actmon_isr_device(struct tegra_devfreq *tegra,
-- 
2.21.0

  parent reply	other threads:[~2019-04-17 22:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 22:29 [PATCH v3 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 01/16] PM / devfreq: tegra: Fix kHz to Hz conversion Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 02/16] PM / devfreq: tegra: Replace readl-writel with relaxed versions Dmitry Osipenko
2019-04-17 22:29 ` Dmitry Osipenko [this message]
2019-04-17 22:29 ` [PATCH v3 04/16] PM / devfreq: tegra: Don't ignore clk errors Dmitry Osipenko
2019-04-18  0:23   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 05/16] PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 06/16] PM / devfreq: tegra: Drop primary interrupt handler Dmitry Osipenko
2019-04-18  0:24   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 07/16] PM / devfreq: tegra: Properly disable interrupts Dmitry Osipenko
2019-04-30  0:05   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 08/16] PM / devfreq: tegra: Clean up driver's probe / remove Dmitry Osipenko
2019-04-30  0:16   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 09/16] PM / devfreq: tegra: Avoid inconsistency of current frequency value Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 10/16] PM / devfreq: tegra: Mark ACTMON's governor as immutable Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 11/16] PM / devfreq: tegra: Move governor registration to driver's probe Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 12/16] PM / devfreq: tegra: Reconfigure hardware on governor's restart Dmitry Osipenko
2019-04-30  1:19   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 13/16] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
2019-04-18  0:21   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 14/16] PM / devfreq: tegra: Enable COMPILE_TEST for the driver Dmitry Osipenko
2019-04-17 22:29 ` [PATCH v3 15/16] PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c Dmitry Osipenko
2019-04-18  0:22   ` Chanwoo Choi
2019-04-17 22:29 ` [PATCH v3 16/16] PM / devfreq: Introduce driver for NVIDIA Tegra20 Dmitry Osipenko
2019-04-30  0:21   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417222925.5815-4-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.