From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGxpm-0004IJ-1Q for qemu-devel@nongnu.org; Wed, 17 Apr 2019 23:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGxpl-0000Ts-0I for qemu-devel@nongnu.org; Wed, 17 Apr 2019 23:35:34 -0400 Date: Thu, 18 Apr 2019 00:35:27 -0300 From: Eduardo Habkost Message-ID: <20190418033527.GD25134@habkost.net> References: <20190417025944.16154-1-ehabkost@redhat.com> <87sguhyykr.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sguhyykr.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Peter Maydell , Thomas Huth , Like Xu , Riku Voipio , Mark Cave-Ayland , Laurent Vivier , qemu-ppc@nongnu.org, Igor Mammedov , Paolo Bonzini , David Gibson , Artyom Tarasenko , Richard Henderson On Wed, Apr 17, 2019 at 07:45:24AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > My initial goal was simple: removing the qdev_get_machine() call > > from ppc_cpu_parse_featurestr() because I want to make > > qdev_get_machine() available only to softmmu code. > > > > Before doing this, I had to make *-user not call > > CPUClass::parse_features() anymore (it was pointless to call it, > > anyway). > > > > While doing this, I decided to rename parse_cpu_model() to > > something clearer (parse_cpu_option()). > > > > As a nice side effect, now the dependency between machine object > > creation and parse_cpu_option() is not hidden anymore. > > Series > Reviewed-by: Markus Armbruster Thanks. I'm queueing this even though I agree with the comments at patch 2/5, because I'm already planning to send a separate cleanup series for cpu_class_by_name() and other related code. -- Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9721EC282DA for ; Thu, 18 Apr 2019 03:36:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68BD62083D for ; Thu, 18 Apr 2019 03:36:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68BD62083D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34922 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGxqg-0004t9-OO for qemu-devel@archiver.kernel.org; Wed, 17 Apr 2019 23:36:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGxpm-0004IJ-1Q for qemu-devel@nongnu.org; Wed, 17 Apr 2019 23:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGxpl-0000Ts-0I for qemu-devel@nongnu.org; Wed, 17 Apr 2019 23:35:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37462) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGxpk-0000TC-Nd; Wed, 17 Apr 2019 23:35:32 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9DD8307EABF; Thu, 18 Apr 2019 03:35:30 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 622995C224; Thu, 18 Apr 2019 03:35:29 +0000 (UTC) Date: Thu, 18 Apr 2019 00:35:27 -0300 From: Eduardo Habkost To: Markus Armbruster Message-ID: <20190418033527.GD25134@habkost.net> References: <20190417025944.16154-1-ehabkost@redhat.com> <87sguhyykr.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <87sguhyykr.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 18 Apr 2019 03:35:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Like Xu , Riku Voipio , Mark Cave-Ayland , qemu-devel@nongnu.org, Laurent Vivier , qemu-ppc@nongnu.org, Paolo Bonzini , Igor Mammedov , Richard Henderson , Artyom Tarasenko , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190418033527.HOegWpaTAaqUtMqgFmHSp0aYS9r_E54Sp3cJeGp1fQ0@z> On Wed, Apr 17, 2019 at 07:45:24AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > My initial goal was simple: removing the qdev_get_machine() call > > from ppc_cpu_parse_featurestr() because I want to make > > qdev_get_machine() available only to softmmu code. > > > > Before doing this, I had to make *-user not call > > CPUClass::parse_features() anymore (it was pointless to call it, > > anyway). > > > > While doing this, I decided to rename parse_cpu_model() to > > something clearer (parse_cpu_option()). > > > > As a nice side effect, now the dependency between machine object > > creation and parse_cpu_option() is not hidden anymore. > > Series > Reviewed-by: Markus Armbruster Thanks. I'm queueing this even though I agree with the comments at patch 2/5, because I'm already planning to send a separate cleanup series for cpu_class_by_name() and other related code. -- Eduardo