From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Jiri Slaby <jslaby@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 02/02] tty: rocket: deprecate the rp_ioctl
Date: Thu, 18 Apr 2019 08:59:15 +0200 [thread overview]
Message-ID: <20190418065915.GA14565@kroah.com> (raw)
In-Reply-To: <20190418043558.10577-2-huangfq.daxian@gmail.com>
On Thu, Apr 18, 2019 at 12:35:58PM +0800, Fuqian Huang wrote:
> This patch depends on patch 01.
THat's implied as it is patch 02/02, so no need to put it in the
changelog text :)
>
> The rp_ioctl is deprecated.
> Add dev_warn_ratelimited to warn the use of rp_ioctl.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/tty/rocket.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c
> index b6543e28bd8b..1e1bcb54b680 100644
> --- a/drivers/tty/rocket.c
> +++ b/drivers/tty/rocket.c
> @@ -1284,18 +1284,28 @@ static int rp_ioctl(struct tty_struct *tty,
>
> switch (cmd) {
> case RCKP_GET_CONFIG:
> + dev_warn_ratelimited(tty->dev,
> + "RCKP_GET_CONFIG option is deprecated\n");
Nit, you can wrap this a bit nicer to make checkpatch.pl happy:
dev_warn_ratelimited(tty->dev,
"RCKP_GET_CONFIG option is deprecated\n");
I'll fix it up when I apply it, thanks!
greg k-h
prev parent reply other threads:[~2019-04-18 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 4:35 [PATCH v5 01/02] tty: rocket: Remove RCPK_GET_STRUCT ioctl Fuqian Huang
2019-04-18 4:35 ` [PATCH v5 02/02] tty: rocket: deprecate the rp_ioctl Fuqian Huang
2019-04-18 6:59 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418065915.GA14565@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=huangfq.daxian@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.