[dpdk-dev] [PATCH v2] lib/bitratestats: fix unchecked return value

[dpdk-dev] [PATCH v2] lib/bitratestats: fix unchecked return value

[Andrius Sirvys]

Checking the return value of rte_metrics_update_values, if failed
returning that value.
Coverity had picked up that that the return value wasn't being checked.

Coverity issue: 336863
Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
Cc: remy.horton@intel.com

Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
Acked-by: Rami Rosen <ramirose@gmail.com>
---
v2: Fixed checkpatch warnings and build failures
---
 lib/librte_bitratestats/rte_bitrate.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_bitratestats/rte_bitrate.c b/lib/librte_bitratestats/rte_bitrate.c
index c4b28f624..639e47547 100644
--- a/lib/librte_bitratestats/rte_bitrate.c
+++ b/lib/librte_bitratestats/rte_bitrate.c
@@ -67,6 +67,7 @@ rte_stats_bitrate_calc(struct rte_stats_bitrates *bitrate_data,
 	int64_t delta;
 	const int64_t alpha_percent = 20;
 	uint64_t values[6];
+	int ret;
 
 	if (bitrate_data == NULL)
 		return -EINVAL;
@@ -124,7 +125,10 @@ rte_stats_bitrate_calc(struct rte_stats_bitrates *bitrate_data,
 	values[3] = port_data->mean_obits;
 	values[4] = port_data->peak_ibits;
 	values[5] = port_data->peak_obits;
-	rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
+	ret = rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
 		values, ARRAY_SIZE(values));
+	if (ret < 0)
+		return ret;
+
 	return 0;
 }
-- 
2.17.1

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value

[Mcnamara, John]

> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Andrius Sirvys
> Sent: Thursday, April 18, 2019 9:52 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Sirvys, Andrius <andrius.sirvys@intel.com>;
> remy.horton@intel.com
> Subject: [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return
> value
> 
> Checking the return value of rte_metrics_update_values, if failed
> returning that value.
> Coverity had picked up that that the return value wasn't being checked.
> 
> Coverity issue: 336863
> Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
> Cc: remy.horton@intel.com
> 
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> Acked-by: Rami Rosen <ramirose@gmail.com>


Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value

[Thomas Monjalon]

> > Checking the return value of rte_metrics_update_values, if failed
> > returning that value.
> > Coverity had picked up that that the return value wasn't being checked.
> > 
> > Coverity issue: 336863
> > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
> > Cc: remy.horton@intel.com
> > 
> > Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> > Acked-by: Rami Rosen <ramirose@gmail.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

+Cc: stable

Applied, thanks