From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38BBC10F0E for ; Thu, 18 Apr 2019 11:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7787521850 for ; Thu, 18 Apr 2019 11:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388794AbfDRLUy (ORCPT ); Thu, 18 Apr 2019 07:20:54 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:55607 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727807AbfDRLUy (ORCPT ); Thu, 18 Apr 2019 07:20:54 -0400 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E04A9240005; Thu, 18 Apr 2019 11:20:49 +0000 (UTC) Date: Thu, 18 Apr 2019 13:20:49 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Michael Trimarchi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com Subject: Re: [PATCH 1/2] arm64: dts: allwinner: a64: Add pinmux setting for CSI MCLK on PE1 Message-ID: <20190418112049.mgvvvcwzf3ezg4pw@flea> References: <20190418083813.11776-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="awtgps4p5ffdljja" Content-Disposition: inline In-Reply-To: <20190418083813.11776-1-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --awtgps4p5ffdljja Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 02:08:12PM +0530, Jagan Teki wrote: > Some camera modules have the SoC feeding a master clock to the sensor > instead of having a standalone crystal. This clock signal is generated > from the clock control unit and output from the CSI MCLK function of > pin PE1. > > Add a pinmux setting for it for camera sensors to reference. > > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 6f27eb082429..6f4e00ec9c68 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -597,6 +597,11 @@ > function = "csi"; > }; > > + csi_mclk_pin: csi-mclk { The name of the pin should be ending with -pin, and please add /omit-if-no-ref/ Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --awtgps4p5ffdljja Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLhdkQAKCRDj7w1vZxhR xX0SAP91Z9NPv6I8QWcHV4ella9gF/FwxKlQf6i3TvT72y91GQEAvpMhVn1S6zhZ 2Z1ZlvmSuZLeJ9UuOwCmu7ndJU/rQwA= =YFn5 -----END PGP SIGNATURE----- --awtgps4p5ffdljja-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD53C282DD for ; Thu, 18 Apr 2019 11:21:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBA2F2183F for ; Thu, 18 Apr 2019 11:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MTo1ec4Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="b4yK5Ftz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBA2F2183F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7IryzoprhLJtVcU+3wznoWtP2tiCbNyQCBLwqeimZWI=; b=MTo1ec4YJ/d+Fcyy7H4HGFhDB X+VUnqK7IPcE0fzpp5oSC4db72/JwmBEajBchbdqN6Wdo1n6YNu71L5TOUBL9hZRUyqcZ45AV4kkm fVU9RN5/ucMEPob9iYCgpfYT7tqR0whb/m62UlNVntpZwJoigP5ZuBlCH2AuQb0x+EJcDDZBtLibZ 5CAFypLIb9SDg4HHN7i2MJVcy1LcNny2EF4KVK5kO7imhw6iiMhUhRI0j4tfZCfrFaD6qlJNhsPnA LK/OjW07vdfPYHhBdwGgv9VIUiv//SqFu8EcPCKtOOYMLZ/nJVC2bejSm+0uE9PeSedDV7U6iUilz fITWPxBiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH56k-0004VV-9k; Thu, 18 Apr 2019 11:21:34 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH56j-0004VK-JO for linux-arm-kernel@bombadil.infradead.org; Thu, 18 Apr 2019 11:21:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kQ4Ua///vPgpeWnkTkDHusTdWdAjlO1aOyObh4c2b20=; b=b4yK5Ftz/t5e+62GbfD1YlRKT pNiSdRhpYlkWJbBg1IzEhbNQoiBE5O51Qr5bVTOHwELRIVJ1fx6uKU6hQ6/ZXaiksmp5rmlsRNGvp a4lDd/D9rKn57c4JdZPbwFa3jdYvWIC3BaAmZwnpOBjTHZwTheMV5pcf/1E3w+YmnJeWYnQI0zn6Q TIxRrpWe7sQNDCAQnHNZNQkPAkWVl/aLLRmKWU+mKs4TuVQJ2sX4DsIWWQ5H4UdcECMwSLHGRCprc BNkOJJKPGcwxAn/piXU7cKeyqbso7C5swAMjUSoVyGtENeJDAFlMQGJ41OfjgC73orX60a4b2zeI6 TlvQE49DQ==; Received: from relay10.mail.gandi.net ([217.70.178.230]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH56e-0001ZF-EK for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 11:21:31 +0000 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E04A9240005; Thu, 18 Apr 2019 11:20:49 +0000 (UTC) Date: Thu, 18 Apr 2019 13:20:49 +0200 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH 1/2] arm64: dts: allwinner: a64: Add pinmux setting for CSI MCLK on PE1 Message-ID: <20190418112049.mgvvvcwzf3ezg4pw@flea> References: <20190418083813.11776-1-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20190418083813.11776-1-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_072128_597443_990F1D7D X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4147821277446267427==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4147821277446267427== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="awtgps4p5ffdljja" Content-Disposition: inline --awtgps4p5ffdljja Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 02:08:12PM +0530, Jagan Teki wrote: > Some camera modules have the SoC feeding a master clock to the sensor > instead of having a standalone crystal. This clock signal is generated > from the clock control unit and output from the CSI MCLK function of > pin PE1. > > Add a pinmux setting for it for camera sensors to reference. > > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 6f27eb082429..6f4e00ec9c68 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -597,6 +597,11 @@ > function = "csi"; > }; > > + csi_mclk_pin: csi-mclk { The name of the pin should be ending with -pin, and please add /omit-if-no-ref/ Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --awtgps4p5ffdljja Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLhdkQAKCRDj7w1vZxhR xX0SAP91Z9NPv6I8QWcHV4ella9gF/FwxKlQf6i3TvT72y91GQEAvpMhVn1S6zhZ 2Z1ZlvmSuZLeJ9UuOwCmu7ndJU/rQwA= =YFn5 -----END PGP SIGNATURE----- --awtgps4p5ffdljja-- --===============4147821277446267427== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4147821277446267427==--