From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F065C10F0E for ; Thu, 18 Apr 2019 12:57:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4853721479 for ; Thu, 18 Apr 2019 12:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388430AbfDRM5e (ORCPT ); Thu, 18 Apr 2019 08:57:34 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:57899 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbfDRM5d (ORCPT ); Thu, 18 Apr 2019 08:57:33 -0400 X-Originating-IP: 90.88.160.238 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7E10840003; Thu, 18 Apr 2019 12:57:29 +0000 (UTC) Date: Thu, 18 Apr 2019 14:57:29 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Michael Trimarchi , devicetree , linux-arm-kernel , linux-kernel , linux-amarula@amarulasolutions.com Subject: Re: [PATCH v2 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Message-ID: <20190418125729.ihsdhtclcv7loftm@flea> References: <20190418083543.11695-1-jagan@amarulasolutions.com> <20190418112357.qic227rdwordmzyh@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fqcutytxrihg6l4f" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fqcutytxrihg6l4f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 06:00:27PM +0530, Jagan Teki wrote: > On Thu, Apr 18, 2019 at 4:54 PM Maxime Ripard wrote: > > > > On Thu, Apr 18, 2019 at 02:05:42PM +0530, Jagan Teki wrote: > > > Add Goodix GT5663 capacitive touch controller node on > > > Amarula A64-Relic board. > > > > > > The CTP connected to board with, > > > - SDA, SCK from i2c1 > > > - GPIO-LD0 as AVDD28 supply > > > - PH4 gpio as interrupt pin > > > - PH8 gpio as reset pin > > > - X axis is inverted > > > - Y axis is inverted > > > > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v2: > > > - drop i2c1, bias-pull-up > > > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > index 3575db216016..3819ce396073 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > @@ -49,6 +49,24 @@ > > > bias-pull-up; > > > }; > > > > > > +&i2c1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&i2c1_pins>; > > > > That's the default already > > Yes, and i2c1 node in sun50i-a64.dtsi is not attaching pinctrl. So I > attached here. If that's the only muxing option, it should then. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fqcutytxrihg6l4f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLh0OQAKCRDj7w1vZxhR xXUFAP90TQofLCGvEH4XjS5PMg99z8RKJ6oVSIdJa2nJk5v/eQEA7surluc2rFnp dimL+VhNIlxTgQvD4IUcX9UO80Ij8ww= =pU/7 -----END PGP SIGNATURE----- --fqcutytxrihg6l4f-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B9CC10F0E for ; Thu, 18 Apr 2019 12:57:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C668421479 for ; Thu, 18 Apr 2019 12:57:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n7lNeZsV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C668421479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=clTXBgZ07h3zd9VDkqml1TZ0EvXc2ro02CprQnjsJvg=; b=n7lNeZsVjuoa436oLLQ4IAngf SyeamWklO7emsP0b2N7t8j75Vx4rW5/fOQYZoe/sMGc56oI6d67AshXeiz0m5gwYXMdPhzs9kK2d7 7nMHShyfltCx9SheQs6LFMBxC4ppKqz9IFvvHa4fWQUwG1GNJJhWHZWBL0D0FQq+9/NRJRqfpwS6k 9F2+/6Cqi0JS4Yqjpn2cPjJqPSR0VJVwWCVcNhd+L6u3dPXh5qhHB21HXnnVEE3mbHaJ0MV2I54PL /k6gizrbxnbtihp/TLUk7LJdrJwlcYkGLexY21BpTPCltMTzmTSzypfkOsXO7EncH0X3+9KbpbFIW T9kNjNvQQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6bg-0008G1-QK; Thu, 18 Apr 2019 12:57:36 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6bd-0008FU-LU for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 12:57:35 +0000 X-Originating-IP: 90.88.160.238 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7E10840003; Thu, 18 Apr 2019 12:57:29 +0000 (UTC) Date: Thu, 18 Apr 2019 14:57:29 +0200 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v2 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Message-ID: <20190418125729.ihsdhtclcv7loftm@flea> References: <20190418083543.11695-1-jagan@amarulasolutions.com> <20190418112357.qic227rdwordmzyh@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_055733_850162_70FB3246 X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-kernel , Chen-Yu Tsai , Rob Herring , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: multipart/mixed; boundary="===============1927827137587896493==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1927827137587896493== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fqcutytxrihg6l4f" Content-Disposition: inline --fqcutytxrihg6l4f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 06:00:27PM +0530, Jagan Teki wrote: > On Thu, Apr 18, 2019 at 4:54 PM Maxime Ripard wrote: > > > > On Thu, Apr 18, 2019 at 02:05:42PM +0530, Jagan Teki wrote: > > > Add Goodix GT5663 capacitive touch controller node on > > > Amarula A64-Relic board. > > > > > > The CTP connected to board with, > > > - SDA, SCK from i2c1 > > > - GPIO-LD0 as AVDD28 supply > > > - PH4 gpio as interrupt pin > > > - PH8 gpio as reset pin > > > - X axis is inverted > > > - Y axis is inverted > > > > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v2: > > > - drop i2c1, bias-pull-up > > > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > index 3575db216016..3819ce396073 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > @@ -49,6 +49,24 @@ > > > bias-pull-up; > > > }; > > > > > > +&i2c1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&i2c1_pins>; > > > > That's the default already > > Yes, and i2c1 node in sun50i-a64.dtsi is not attaching pinctrl. So I > attached here. If that's the only muxing option, it should then. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fqcutytxrihg6l4f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLh0OQAKCRDj7w1vZxhR xXUFAP90TQofLCGvEH4XjS5PMg99z8RKJ6oVSIdJa2nJk5v/eQEA7surluc2rFnp dimL+VhNIlxTgQvD4IUcX9UO80Ij8ww= =pU/7 -----END PGP SIGNATURE----- --fqcutytxrihg6l4f-- --===============1927827137587896493== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1927827137587896493==--