From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69024C282DF for ; Fri, 19 Apr 2019 20:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C58620663 for ; Fri, 19 Apr 2019 20:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727318AbfDSUNy (ORCPT ); Fri, 19 Apr 2019 16:13:54 -0400 Received: from wp210.webpack.hosteurope.de ([80.237.132.217]:48396 "EHLO wp210.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726331AbfDSUNx (ORCPT ); Fri, 19 Apr 2019 16:13:53 -0400 X-Greylist: delayed 6037 seconds by postgrey-1.27 at vger.kernel.org; Fri, 19 Apr 2019 16:13:52 EDT Received: from port-92-193-190-131.dynamic.qsc.de ([92.193.190.131] helo=localhost); authenticated by wp210.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1hHNmT-0005yE-Ds; Fri, 19 Apr 2019 09:17:53 +0200 Date: Fri, 19 Apr 2019 09:17:52 +0200 From: Jan =?iso-8859-1?Q?Kl=F6tzke?= To: David Miller Cc: Jan.Kloetzke@preh.de, oneukum@suse.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usbnet: fix kernel crash after disconnect Message-ID: <20190419071752.GG1084@tuxedo> References: <20190417091849.7475-1-Jan.Kloetzke@preh.de> <1555569464.7835.4.camel@suse.com> <1555574578.4173.215.camel@preh.de> <20190418.163544.2153438649838575906.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418.163544.2153438649838575906.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-bounce-key: webpack.hosteurope.de;jan@kloetzke.net;1555704833;5f5e3d6b; X-HE-SMSGID: 1hHNmT-0005yE-Ds Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, On Thu, Apr 18, 2019 at 04:35:44PM -0700, David Miller wrote: > From: Kloetzke Jan > Date: Thu, 18 Apr 2019 08:02:59 +0000 > > > I think this assumption is not correct. As far as I understand the > > networking code it is still possible that the ndo_start_xmit callback > > is called while ndo_stop is running and even after ndo_stop has > > returned. You can only be sure after unregister_netdev() has returned. > > Maybe some networking folks can comment on that. > > The kernel loops over the devices being unregistered, and first it clears > the __LINK_STATE_START on all of them, then it invokes ->ndo_stop() on > all of them. > > __LINK_STATE_START controls what netif_running() returns. > > All calls to ->ndo_start_xmit() are guarded by netif_running() checks. > > So when ndo_stop is invoked you should get no more ndo_start_xmit > invocations on that device. Otherwise how could you shut down DMA > resources and turn off the TX engine properly? But you could still race with another CPU that is past the netif_running() check, can you? So the driver has to make sure that it gracefully handles concurrent ->ndo_start_xmit() and ->ndo_stop() calls. Or are there any locks/barriers involved that make sure all ->ndo_start_xmit() calls have returned before invoking ->ndo_stop()? Regards, Jan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usbnet: fix kernel crash after disconnect From: =?utf-8?q?Jan_Kl=C3=B6tzke?= Message-Id: <20190419071752.GG1084@tuxedo> Date: Fri, 19 Apr 2019 09:17:52 +0200 To: David Miller Cc: Jan.Kloetzke@preh.de, oneukum@suse.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org List-ID: SGkgRGF2aWQsCgpPbiBUaHUsIEFwciAxOCwgMjAxOSBhdCAwNDozNTo0NFBNIC0wNzAwLCBEYXZp ZCBNaWxsZXIgd3JvdGU6Cj4gRnJvbTogS2xvZXR6a2UgSmFuIDxKYW4uS2xvZXR6a2VAcHJlaC5k ZT4KPiBEYXRlOiBUaHUsIDE4IEFwciAyMDE5IDA4OjAyOjU5ICswMDAwCj4gCj4gPiBJIHRoaW5r IHRoaXMgYXNzdW1wdGlvbiBpcyBub3QgY29ycmVjdC4gQXMgZmFyIGFzIEkgdW5kZXJzdGFuZCB0 aGUKPiA+IG5ldHdvcmtpbmcgY29kZSBpdCBpcyBzdGlsbCBwb3NzaWJsZSB0aGF0IHRoZSBuZG9f c3RhcnRfeG1pdCBjYWxsYmFjawo+ID4gaXMgY2FsbGVkIHdoaWxlIG5kb19zdG9wIGlzIHJ1bm5p bmcgYW5kIGV2ZW4gYWZ0ZXIgbmRvX3N0b3AgaGFzCj4gPiByZXR1cm5lZC4gWW91IGNhbiBvbmx5 IGJlIHN1cmUgYWZ0ZXIgdW5yZWdpc3Rlcl9uZXRkZXYoKSBoYXMgcmV0dXJuZWQuCj4gPiBNYXli ZSBzb21lIG5ldHdvcmtpbmcgZm9sa3MgY2FuIGNvbW1lbnQgb24gdGhhdC4KPiAKPiBUaGUga2Vy bmVsIGxvb3BzIG92ZXIgdGhlIGRldmljZXMgYmVpbmcgdW5yZWdpc3RlcmVkLCBhbmQgZmlyc3Qg aXQgY2xlYXJzCj4gdGhlIF9fTElOS19TVEFURV9TVEFSVCBvbiBhbGwgb2YgdGhlbSwgdGhlbiBp dCBpbnZva2VzIC0+bmRvX3N0b3AoKSBvbgo+IGFsbCBvZiB0aGVtLgo+IAo+IF9fTElOS19TVEFU RV9TVEFSVCBjb250cm9scyB3aGF0IG5ldGlmX3J1bm5pbmcoKSByZXR1cm5zLgo+IAo+IEFsbCBj YWxscyB0byAtPm5kb19zdGFydF94bWl0KCkgYXJlIGd1YXJkZWQgYnkgbmV0aWZfcnVubmluZygp IGNoZWNrcy4KPiAKPiBTbyB3aGVuIG5kb19zdG9wIGlzIGludm9rZWQgeW91IHNob3VsZCBnZXQg bm8gbW9yZSBuZG9fc3RhcnRfeG1pdAo+IGludm9jYXRpb25zIG9uIHRoYXQgZGV2aWNlLiAgT3Ro ZXJ3aXNlIGhvdyBjb3VsZCB5b3Ugc2h1dCBkb3duIERNQQo+IHJlc291cmNlcyBhbmQgdHVybiBv ZmYgdGhlIFRYIGVuZ2luZSBwcm9wZXJseT8KCkJ1dCB5b3UgY291bGQgc3RpbGwgcmFjZSB3aXRo IGFub3RoZXIgQ1BVIHRoYXQgaXMgcGFzdCB0aGUKbmV0aWZfcnVubmluZygpIGNoZWNrLCBjYW4g eW91PyBTbyB0aGUgZHJpdmVyIGhhcyB0byBtYWtlIHN1cmUgdGhhdCBpdApncmFjZWZ1bGx5IGhh bmRsZXMgY29uY3VycmVudCAtPm5kb19zdGFydF94bWl0KCkgYW5kIC0+bmRvX3N0b3AoKSBjYWxs cy4KCk9yIGFyZSB0aGVyZSBhbnkgbG9ja3MvYmFycmllcnMgaW52b2x2ZWQgdGhhdCBtYWtlIHN1 cmUgYWxsCi0+bmRvX3N0YXJ0X3htaXQoKSBjYWxscyBoYXZlIHJldHVybmVkIGJlZm9yZSBpbnZv a2luZyAtPm5kb19zdG9wKCk/CgpSZWdhcmRzLApKYW4K