From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB747C282DA for ; Fri, 19 Apr 2019 19:40:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91FCD2171F for ; Fri, 19 Apr 2019 19:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555702834; bh=8Xy3BH3ok43lXOEKvUk1aG2nIA1L/IAKSkP24QwVglk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Yfd5TMbSmIIsF9lGjWjt59oOErj5GII7BwNOwgzrReOF3M1QmfSbxdNKALAxJnkmI Srsk9D+ZvJSkYTybFs99ji50Bs8+dCYET9iD6h089Tmu4YQGVOEp5nE5RyUZcynIiL +6BIKb2BXI8tB52Yi2PKF1bOEfIzQYVP3AF23TwA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728063AbfDSTkd (ORCPT ); Fri, 19 Apr 2019 15:40:33 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54433 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbfDSTkc (ORCPT ); Fri, 19 Apr 2019 15:40:32 -0400 Received: by mail-wm1-f67.google.com with SMTP id c1so7186285wml.4 for ; Fri, 19 Apr 2019 12:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yv8sNlmOUSUFFszUmODIIclw3NeRdjYoHffY8iKyf+U=; b=lrqj2wzyBnqrtlzH+j772n4tj2tHzVxSDkwQT0vT6HBfqqvk7v3n6Q5yn8SE5hZgtA 52P+6gBug9COUaSLJ6Sc5Bm3POXGLdW6q8sCfBdzebBhkPsbpLp9SVFak0jAjfFrnr7E Vt25fIe1axrn4fh+HwkTe0dDNbwhfGGkruO9bodwVUdCJ+Ylx2pfT7rFeXp/Jg0AuHdz qhKOawW+psB6DR2dDa69PI7kzbKNjGwjwpUdSopYRbZ+tGulBskiYYrZAynEQUgg3I4V YEjHiI9ej2vDjdYaw99PTIcqZO6J8thYOJ7ZxIy3yqiKfT59ohAXjBDOx+/WQwvUyJu2 pG5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=yv8sNlmOUSUFFszUmODIIclw3NeRdjYoHffY8iKyf+U=; b=WR4zbxKZp9MrKapz1Hu5pix6umTMyiqIiu0nbfVi+VX9qmEvYuqPvG5C+Y8t/ypjFh +2oZZiL9P4wHKZRPkzvvuQyinpawyXUFXXfwqJIYjKyX1NJd5dvgbq6otWrTeF01UenR v/DjIi/blr6KIM9a3y+WkaSB2PqXueBIkkl7TwxdaOksBWpHxs6AfwK4dZmt2OWFDV3u ep0zXl69kzqwYAdmCJBWGmq6TG91kcqbnWN2Mr8QvEqbTAfnlcIgxxFm7UUGnIbn8pQU k3pX0/g+Z6DtZqRyU0Np/eeReWRNQUfCopX148e6uVnSDrFMDzCZ9dGGKIMVeD8Sdelh GqqQ== X-Gm-Message-State: APjAAAUosLCTjo4Kt22GvsXkoR4Z64Z+nC5kymFF/7piAdnExtgnbyXR u+GAAk2fn4+b71+7Jt1lnAylldwn X-Google-Smtp-Source: APXvYqy5yqAAeEeMBIi5mAMQzUHmY0tyqDIo0+d+UJ8uUhcjnKR636iMGs3O1KMaC6B8qtHXwaH+LQ== X-Received: by 2002:a1c:23cc:: with SMTP id j195mr1985837wmj.74.1555663904442; Fri, 19 Apr 2019 01:51:44 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id 192sm5554039wme.13.2019.04.19.01.51.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 01:51:43 -0700 (PDT) Date: Fri, 19 Apr 2019 10:51:40 +0200 From: Ingo Molnar To: "Saidi, Ali" Cc: Kees Cook , Michal Hocko , Matthew Wilcox , Jann Horn , Dave Hansen , "Liguori, Anthony" , Peter Zijlstra , Catalin Marinas , X86 ML , Will Deacon , LKML , Ingo Molnar , Borislav Petkov , "Woodhouse, David" , Andy Lutomirski , "H. Peter Anvin" , Andrew Morton , Thomas Gleixner , linux-arm-kernel Subject: Re: [PATCH 2/2] x86/mmap: handle worst-case heap randomization in mmap_base Message-ID: <20190419085140.GA50390@gmail.com> References: <20190312173248.13490-1-alisaidi@amazon.com> <20190312173248.13490-3-alisaidi@amazon.com> <34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Saidi, Ali wrote: > On 3/27/19, 2:52 PM, "linux-arm-kernel on behalf of Kees Cook" wrote: > > Adding some more people to CC... what do people think about this > moving of the brk to ELF_ET_DYN_BASE in this corner-case? Anything > that worked before should still work (i.e. the ultimately-launched > binary already had the brk very far from its text, so this should be > no different from a COMPAT_BRK standpoint). The only risk I see here > is that if someone started to suddenly depend on the entire memory > space above the mmap region being available when launching binaries > via a direct loader execs... which seems highly unlikely, I'd hope: > this would mean a binary would not work when execed normally. > > Kees' proposal addresses the issue for me. Anyone have concerns on this proposed solution? I'd suggest incorporating all feedback and sending a v2 series - it's much easier to get people's attention via code submitted. ;-) Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 859F2C282DA for ; Fri, 19 Apr 2019 08:51:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 559F021855 for ; Fri, 19 Apr 2019 08:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DesAWySn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lrqj2wzy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 559F021855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qdtusCBIoXDZ73Lx5wOTrLI0IZbVqF2Aj9eP/zpBjCE=; b=DesAWySnfz4qT1 orDyOLbLw7iOwEVpdeIufO+/g49HoCQu5WHHWe7jc2GfTpRVFJhNVejHqrUEPsDxKBDxOn01HZ1Aw C8NaDgV8xBL5yPvwAGXiwxPCqIVys+ih6Mh8VjdDriH942ASJpLzUc9BhFtuIxnwJUvnlIDgQz0/K h1eVtNCa4/qqCMk1C65AjlESKRd2Cm4gDePyAltMWo1LapUA1M4C0zAF9E38pzaLroOOwucCZl1W2 jrNBX7FyOXzfTBsAuUlxGQmFIzUki2OWnvgBkdy4I0RxhGlukdnD+UwBw7wQAe/NPSlO+7OMMrr96 IFvyhK3Mj37qAfZ0LT+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHPFN-0004M9-4O; Fri, 19 Apr 2019 08:51:49 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHPFK-0004Li-BJ for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 08:51:47 +0000 Received: by mail-wm1-x341.google.com with SMTP id z11so5590706wmi.0 for ; Fri, 19 Apr 2019 01:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yv8sNlmOUSUFFszUmODIIclw3NeRdjYoHffY8iKyf+U=; b=lrqj2wzyBnqrtlzH+j772n4tj2tHzVxSDkwQT0vT6HBfqqvk7v3n6Q5yn8SE5hZgtA 52P+6gBug9COUaSLJ6Sc5Bm3POXGLdW6q8sCfBdzebBhkPsbpLp9SVFak0jAjfFrnr7E Vt25fIe1axrn4fh+HwkTe0dDNbwhfGGkruO9bodwVUdCJ+Ylx2pfT7rFeXp/Jg0AuHdz qhKOawW+psB6DR2dDa69PI7kzbKNjGwjwpUdSopYRbZ+tGulBskiYYrZAynEQUgg3I4V YEjHiI9ej2vDjdYaw99PTIcqZO6J8thYOJ7ZxIy3yqiKfT59ohAXjBDOx+/WQwvUyJu2 pG5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=yv8sNlmOUSUFFszUmODIIclw3NeRdjYoHffY8iKyf+U=; b=eW47CKeVEPx5lHA5hovU0FHmqQOV26Wo1jynzvQntDYZKB+jLAprvBOrG3V9V9eS4k mS0xVHLjzq6AuOBAI7q9DyPbHiZBf3M8xTHyPSW3jLNWOYhlIvIZTtjXCrI8Z7+/lIxn DtiMWRC2NvPJT43AGXGF63MfHNQHGYDPh7hMcaJrseJILPQj5ZQ2/P93UoKZor+wd/SM PwFWBQI4ZFB2Z5LjO8s/vbRy6iPY3CT3dVJJoJwGFOHF4dhNjn/OiT7xPit72ITxNbgu 4zgbEH8UxaXfzwCG2P2PgmckStvuESb7syL2MBCc7EajufTODVTnMjes6hPuP3oQIKb5 7BTw== X-Gm-Message-State: APjAAAVIY6dk1gzBoDqty05TqhpBlbIFUOCxL9LHkeIea9FLwfrVDdvF /RiGEMblMFnVbn5udjq1RyM= X-Google-Smtp-Source: APXvYqy5yqAAeEeMBIi5mAMQzUHmY0tyqDIo0+d+UJ8uUhcjnKR636iMGs3O1KMaC6B8qtHXwaH+LQ== X-Received: by 2002:a1c:23cc:: with SMTP id j195mr1985837wmj.74.1555663904442; Fri, 19 Apr 2019 01:51:44 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id 192sm5554039wme.13.2019.04.19.01.51.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 01:51:43 -0700 (PDT) Date: Fri, 19 Apr 2019 10:51:40 +0200 From: Ingo Molnar To: "Saidi, Ali" Subject: Re: [PATCH 2/2] x86/mmap: handle worst-case heap randomization in mmap_base Message-ID: <20190419085140.GA50390@gmail.com> References: <20190312173248.13490-1-alisaidi@amazon.com> <20190312173248.13490-3-alisaidi@amazon.com> <34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <34381CFC-A90F-4979-9802-2BA0E6539C68@amazon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_015146_414104_850F8034 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Kees Cook , Jann Horn , Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , X86 ML , Matthew Wilcox , LKML , Ingo Molnar , Borislav Petkov , linux-arm-kernel , "Liguori, Anthony" , "H. Peter Anvin" , Andrew Morton , Andy Lutomirski , Thomas Gleixner , "Woodhouse, David" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CiogU2FpZGksIEFsaSA8YWxpc2FpZGlAYW1hem9uLmNvbT4gd3JvdGU6Cgo+IO+7v09uIDMvMjcv MTksIDI6NTIgUE0sICJsaW51eC1hcm0ta2VybmVsIG9uIGJlaGFsZiBvZiBLZWVzIENvb2siIDxs aW51eC1hcm0ta2VybmVsLWJvdW5jZXNAbGlzdHMuaW5mcmFkZWFkLm9yZyBvbiBiZWhhbGYgb2Yg a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPiB3cm90ZToKPiAKPiAgICAgQWRkaW5nIHNvbWUgbW9yZSBw ZW9wbGUgdG8gQ0MuLi4gd2hhdCBkbyBwZW9wbGUgdGhpbmsgYWJvdXQgdGhpcwo+ICAgICBtb3Zp bmcgb2YgdGhlIGJyayB0byBFTEZfRVRfRFlOX0JBU0UgaW4gdGhpcyBjb3JuZXItY2FzZT8gQW55 dGhpbmcKPiAgICAgdGhhdCB3b3JrZWQgYmVmb3JlIHNob3VsZCBzdGlsbCB3b3JrIChpLmUuIHRo ZSB1bHRpbWF0ZWx5LWxhdW5jaGVkCj4gICAgIGJpbmFyeSBhbHJlYWR5IGhhZCB0aGUgYnJrIHZl cnkgZmFyIGZyb20gaXRzIHRleHQsIHNvIHRoaXMgc2hvdWxkIGJlCj4gICAgIG5vIGRpZmZlcmVu dCBmcm9tIGEgQ09NUEFUX0JSSyBzdGFuZHBvaW50KS4gVGhlIG9ubHkgcmlzayBJIHNlZSBoZXJl Cj4gICAgIGlzIHRoYXQgaWYgc29tZW9uZSBzdGFydGVkIHRvIHN1ZGRlbmx5IGRlcGVuZCBvbiB0 aGUgZW50aXJlIG1lbW9yeQo+ICAgICBzcGFjZSBhYm92ZSB0aGUgbW1hcCByZWdpb24gYmVpbmcg YXZhaWxhYmxlIHdoZW4gbGF1bmNoaW5nIGJpbmFyaWVzCj4gICAgIHZpYSBhIGRpcmVjdCBsb2Fk ZXIgZXhlY3MuLi4gd2hpY2ggc2VlbXMgaGlnaGx5IHVubGlrZWx5LCBJJ2QgaG9wZToKPiAgICAg dGhpcyB3b3VsZCBtZWFuIGEgYmluYXJ5IHdvdWxkIG5vdCB3b3JrIHdoZW4gZXhlY2VkIG5vcm1h bGx5Lgo+IAo+IEtlZXMnIHByb3Bvc2FsIGFkZHJlc3NlcyB0aGUgaXNzdWUgZm9yIG1lLiBBbnlv bmUgaGF2ZSBjb25jZXJucyBvbiB0aGlzIHByb3Bvc2VkIHNvbHV0aW9uPwoKSSdkIHN1Z2dlc3Qg aW5jb3Jwb3JhdGluZyBhbGwgZmVlZGJhY2sgYW5kIHNlbmRpbmcgYSB2MiBzZXJpZXMgLSBpdCdz IAptdWNoIGVhc2llciB0byBnZXQgcGVvcGxlJ3MgYXR0ZW50aW9uIHZpYSBjb2RlIHN1Ym1pdHRl ZC4gOy0pCgpUaGFua3MsCgoJSW5nbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=