From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4344FC282E0 for ; Fri, 19 Apr 2019 20:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E166720821 for ; Fri, 19 Apr 2019 20:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555707515; bh=9wDVNpO8ngML+Fb8c/rFbSYWHToYHgwwLSYRw7EPNYM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PCgK3ORZeI4UywBYcmxYsip9FOVuL5bohvN0UnjE9u3m6oqAv4oy+X2cnY3BufFb2 pI08mIABPF/Pi0vaKoJbPCr6U3wymNBurFhpaYCCaw/KaQF356DGzzb8NJ2FpsWUSP 0JCHeyBXdxn+CTP6QNUIoGYjO3ZbQ/BVA5lSThzg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727507AbfDSU6d (ORCPT ); Fri, 19 Apr 2019 16:58:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33034 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbfDSU6d (ORCPT ); Fri, 19 Apr 2019 16:58:33 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CBA772851; Fri, 19 Apr 2019 20:58:31 +0000 (UTC) Date: Fri, 19 Apr 2019 13:58:30 -0700 From: Andrew Morton To: Joe Perches Cc: Masahiro Yamada , Douglas Anderson , Daniel Thompson , Jason Wessel , Christophe Leroy , "Peter Zijlstra (Intel)" , Kees Cook , kgdb-bugreport@lists.sourceforge.net, Johannes Weiner , Linux Kernel Mailing List , "Gustavo A. R. Silva" , Nicholas Mc Guire Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary Message-Id: <20190419135830.0e3273e223fb83947e5adb0d@linux-foundation.org> In-Reply-To: References: <20190323015227.245455-1-dianders@chromium.org> <20190416163034.3e642818ebf27ed6891c1981@linux-foundation.org> <20190418160651.40cb6a11186a6c6028e9d20d@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Apr 2019 04:14:27 -0700 Joe Perches wrote: > On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote: > > Hi Joe, > > > > Can you detect redundant Cc: by checkpatch? > > > > Please see below in details. > > Thanks. > > Yes, but I'm not sure why it's useful or necessary. > git send-email using some scripts elides duplicate email addresses Other (all?) MUAs will avoid addressing an email to a recipient more than once. The issue here is redundant Cc: lines in the changelog. > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2688,6 +2688,19 @@ sub process { > $signatures{$sig_nospace} = 1; > } > > +# Check for a cc: line with another signature -by: by the same author > + if ($sig_nospace =~ /^cc:/) { > + my $sig_email = substr($sig_nospace, 3); > + foreach my $sig (sort keys %signatures) { > + next if ($sig =~ /^cc:/); > + $sig =~ s/^[^:]+://; > + if ($sig eq $sig_email) { > + WARN("BAD_SIGN_OFF", > + "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr); > + } > + } > + } > + > # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email > if ($sign_off =~ /^co-developed-by:$/i) { > if ($email eq $author) { Thanks. But my checkpatch.pl is different from yours. q:/usr/src/25> grep "immediately followed by" scripts/checkpatch.pl q:/usr/src/25>