From: David Miller <davem@davemloft.net>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, idosch@mellanox.com, dsahern@gmail.com
Subject: Re: [PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp
Date: Sun, 21 Apr 2019 10:40:06 -0700 (PDT) [thread overview]
Message-ID: <20190421.104006.1335670381342231168.davem@davemloft.net> (raw)
In-Reply-To: <20190421154901.14202-1-dsahern@kernel.org>
From: David Ahern <dsahern@kernel.org>
Date: Sun, 21 Apr 2019 08:49:01 -0700
> From: David Ahern <dsahern@gmail.com>
>
> After commit c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use
> ip6_route_info_create"), the gateway is no longer filled in for fib6_nh
> structs in a prefix route. Accordingly, the RTF_ADDRCONF flag check can
> be dropped from the 'rt6_qualify_for_ecmp'.
>
> Further, RTF_DYNAMIC is only set in rt6_info instances, so it can be
> removed from the check as well.
>
> This reduces rt6_qualify_for_ecmp and the mlxsw version to just checking
> if the nexthop has a gateway which is the real indication of whether
> entries can be coalesced into a multipath route.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied, thanks David.
prev parent reply other threads:[~2019-04-21 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 15:49 [PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp David Ahern
2019-04-21 17:31 ` Ido Schimmel
2019-04-21 17:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190421.104006.1335670381342231168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.