* [PATCH v2 06/06] sound: isa: gus: fix misuse of %x
@ 2019-04-21 11:48 ` Fuqian Huang
0 siblings, 0 replies; 4+ messages in thread
From: Fuqian Huang @ 2019-04-21 11:48 UTC (permalink / raw)
Cc: Fuqian Huang, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
Pointers should be printed with %p or %px rather than
cast to long type and printed with %lx.
Change %lx to %p to print the pointer.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
sound/isa/gus/gus_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c
index 4ac76f4..63e790f 100644
--- a/sound/isa/gus/gus_mem.c
+++ b/sound/isa/gus/gus_mem.c
@@ -306,7 +306,7 @@ static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
used = 0;
for (block = alloc->first, i = 0; block; block = block->next, i++) {
used += block->size;
- snd_iprintf(buffer, "Block %i at 0x%lx onboard 0x%x size %i (0x%x):\n", i, (long) block, block->ptr, block->size, block->size);
+ snd_iprintf(buffer, "Block %i at 0x%p onboard 0x%x size %i (0x%x):\n", i, block, block->ptr, block->size, block->size);
if (block->share ||
block->share_id[0] || block->share_id[1] ||
block->share_id[2] || block->share_id[3])
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 06/06] sound: isa: gus: fix misuse of %x
@ 2019-04-21 11:48 ` Fuqian Huang
0 siblings, 0 replies; 4+ messages in thread
From: Fuqian Huang @ 2019-04-21 11:48 UTC (permalink / raw)
Cc: Fuqian Huang, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
Pointers should be printed with %p or %px rather than
cast to long type and printed with %lx.
Change %lx to %p to print the pointer.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
sound/isa/gus/gus_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c
index 4ac76f4..63e790f 100644
--- a/sound/isa/gus/gus_mem.c
+++ b/sound/isa/gus/gus_mem.c
@@ -306,7 +306,7 @@ static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
used = 0;
for (block = alloc->first, i = 0; block; block = block->next, i++) {
used += block->size;
- snd_iprintf(buffer, "Block %i at 0x%lx onboard 0x%x size %i (0x%x):\n", i, (long) block, block->ptr, block->size, block->size);
+ snd_iprintf(buffer, "Block %i at 0x%p onboard 0x%x size %i (0x%x):\n", i, block, block->ptr, block->size, block->size);
if (block->share ||
block->share_id[0] || block->share_id[1] ||
block->share_id[2] || block->share_id[3])
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 06/06] sound: isa: gus: fix misuse of %x
2019-04-21 11:48 ` Fuqian Huang
@ 2019-04-23 14:24 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2019-04-23 14:24 UTC (permalink / raw)
To: Fuqian Huang; +Cc: alsa-devel, Jaroslav Kysela, linux-kernel
On Sun, 21 Apr 2019 13:48:44 +0200,
Fuqian Huang wrote:
>
> Pointers should be printed with %p or %px rather than
> cast to long type and printed with %lx.
> Change %lx to %p to print the pointer.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
IMO, it's better to drop the address printing itself.
We don't want to expose the kernel address any longer.
Care to rewrite the patch?
thanks,
Takashi
> ---
> sound/isa/gus/gus_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c
> index 4ac76f4..63e790f 100644
> --- a/sound/isa/gus/gus_mem.c
> +++ b/sound/isa/gus/gus_mem.c
> @@ -306,7 +306,7 @@ static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
> used = 0;
> for (block = alloc->first, i = 0; block; block = block->next, i++) {
> used += block->size;
> - snd_iprintf(buffer, "Block %i at 0x%lx onboard 0x%x size %i (0x%x):\n", i, (long) block, block->ptr, block->size, block->size);
> + snd_iprintf(buffer, "Block %i at 0x%p onboard 0x%x size %i (0x%x):\n", i, block, block->ptr, block->size, block->size);
> if (block->share ||
> block->share_id[0] || block->share_id[1] ||
> block->share_id[2] || block->share_id[3])
> --
> 2.11.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 06/06] sound: isa: gus: fix misuse of %x
@ 2019-04-23 14:24 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2019-04-23 14:24 UTC (permalink / raw)
To: Fuqian Huang; +Cc: alsa-devel, Jaroslav Kysela, linux-kernel
On Sun, 21 Apr 2019 13:48:44 +0200,
Fuqian Huang wrote:
>
> Pointers should be printed with %p or %px rather than
> cast to long type and printed with %lx.
> Change %lx to %p to print the pointer.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
IMO, it's better to drop the address printing itself.
We don't want to expose the kernel address any longer.
Care to rewrite the patch?
thanks,
Takashi
> ---
> sound/isa/gus/gus_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c
> index 4ac76f4..63e790f 100644
> --- a/sound/isa/gus/gus_mem.c
> +++ b/sound/isa/gus/gus_mem.c
> @@ -306,7 +306,7 @@ static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
> used = 0;
> for (block = alloc->first, i = 0; block; block = block->next, i++) {
> used += block->size;
> - snd_iprintf(buffer, "Block %i at 0x%lx onboard 0x%x size %i (0x%x):\n", i, (long) block, block->ptr, block->size, block->size);
> + snd_iprintf(buffer, "Block %i at 0x%p onboard 0x%x size %i (0x%x):\n", i, block, block->ptr, block->size, block->size);
> if (block->share ||
> block->share_id[0] || block->share_id[1] ||
> block->share_id[2] || block->share_id[3])
> --
> 2.11.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-23 14:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-21 11:48 [PATCH v2 06/06] sound: isa: gus: fix misuse of %x Fuqian Huang
2019-04-21 11:48 ` Fuqian Huang
2019-04-23 14:24 ` Takashi Iwai
2019-04-23 14:24 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.