From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA55C10F11 for ; Mon, 22 Apr 2019 16:06:05 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C1DEC20859 for ; Mon, 22 Apr 2019 16:06:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="0YubzA4o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1DEC20859 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF00B4F93; Mon, 22 Apr 2019 18:06:03 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by dpdk.org (Postfix) with ESMTP id 866EC32A5 for ; Mon, 22 Apr 2019 18:06:02 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id t16so6037492plo.0 for ; Mon, 22 Apr 2019 09:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6qdI91QaoP1x+rNqloteSOaszz5JgEScHE9PjidZ8L0=; b=0YubzA4o57ayN4qhgm5TO4DV/sNwkJ34VtSKRqX5RUSxoDJMVuuovAdXxhrWPD3GKn KgbWbjD1dPQsOIHcgNY3q63KWJto42fg6RX5Z0LP0gq5+O/9goLNjiixr+pPXcctW43R uAvj/JQP+R2nUmKHMdqFc2/zjF2+oBrDLC+cCMXTVt0vx0hk0ZCBSBm+EVAlT2oM2Beu EL83oqeDN+K278qGyfb/IR4VjPfSV3BadhXwp2wRmERg5NgHOuQZ4tggxWmq2PKJ55ME dzJd8L9TccWOIXL3ttP0DiJgkfvQKKVSy5+mFqzNyqOGMmrb+7n6VHYngyE966uCObYX 4ogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6qdI91QaoP1x+rNqloteSOaszz5JgEScHE9PjidZ8L0=; b=mD8F+smjYPtvMG0nbCnewJUAwo9Ul71TwlTiULWj4kHyMc5CbQtSJ+An6TWtCFDl9L EMfjjOzgFY6K6iYgx9wXByB7jLnvzdTfpcNnYRYrUvos+IMXfHwUhvHECQo7qXppyBF6 n2KtMk8jC6BPxyMbDSLlfkJNoTlDXmicPgEH88IgAjH9kvm0T/37B1jtMsIQ519g/kgZ nUaT4iAeF/WkCm+B4Z4yG4JqFz4vkM8u7NW4rU8mIzDwfM51ZffiSmaKD4VbrLtsXAQt 3iZ71p8RBL+BgjM6Pm3FZH39T0umfpSa8ofLuOMAJVUSBYdCdI1KbiAtuWvxD7M6jrhW PG3Q== X-Gm-Message-State: APjAAAU4drAFjPFxCOUjhueQw/Y1dLnckcKiE/wlI3cPYLilzgW+MVIF bvTf5IXzwF3tcDUFAuc+fPY60w== X-Google-Smtp-Source: APXvYqzToweKN7IzfEK16mehw8Q9EPmn1vP0Vai3U9wJqePXmyz8eusSaWZtTkpuq0ecapvX53w4cA== X-Received: by 2002:a17:902:820e:: with SMTP id x14mr20955430pln.207.1555949161689; Mon, 22 Apr 2019 09:06:01 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o68sm20829073pfi.140.2019.04.22.09.06.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 09:06:01 -0700 (PDT) Date: Mon, 22 Apr 2019 09:05:54 -0700 From: Stephen Hemminger To: Olivier Matz Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190422090554.2e1af55d@hermes.lan> In-Reply-To: <20190410083218.17531-12-olivier.matz@6wind.com> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-12-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 11/14] net: add rte prefix to ip defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 10 Apr 2019 10:32:15 +0200 Olivier Matz wrote: > diff --git a/app/test-acl/main.c b/app/test-acl/main.c > index b80179417..eb6294396 100644 > --- a/app/test-acl/main.c > +++ b/app/test-acl/main.c > @@ -625,7 +625,7 @@ parse_ipv4_net(const char *in, uint32_t *addr, uint32_t *mask_len) > GET_CB_FIELD(in, d, 0, UINT8_MAX, '/'); > GET_CB_FIELD(in, m, 0, sizeof(uint32_t) * CHAR_BIT, 0); > > - addr[0] = IPv4(a, b, c, d); > + addr[0] = RTE_IPv4(a, b, c, d); IPv4 is a DPDK only macro, could you leave it alone.