From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:32812 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730585AbfDVXqQ (ORCPT ); Mon, 22 Apr 2019 19:46:16 -0400 Date: Mon, 22 Apr 2019 16:46:12 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH] xfs: unlock inode when xfs_ioctl_setattr_get_trans can't get transaction Message-ID: <20190422234612.GE4676@magnolia> References: <20190422182541.GA4676@magnolia> <20190422232025.GZ29573@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422232025.GZ29573@dread.disaster.area> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: xfs On Tue, Apr 23, 2019 at 09:20:25AM +1000, Dave Chinner wrote: > On Mon, Apr 22, 2019 at 11:25:41AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > We passed an inode into xfs_ioctl_setattr_get_trans with join_flags > > indicating which locks are held on that inode. If we can't allocate a > > transaction then we need to unlock the inode before we bail out, like > > all the other error paths do. > > > > Signed-off-by: Darrick J. Wong > > Yup, that's a problem, and the function header comment says "we now > take full responsibility for unlocking the inode" so this looks > fine. Cool. Thanks for the review! --D > Reviewed-by: Dave Chinner > > -- > Dave Chinner > david@fromorbit.com