From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70F7C10F03 for ; Wed, 24 Apr 2019 02:54:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FA48218D2 for ; Wed, 24 Apr 2019 02:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfDXCyq (ORCPT ); Tue, 23 Apr 2019 22:54:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48768 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726461AbfDXCyq (ORCPT ); Tue, 23 Apr 2019 22:54:46 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CA2F3140F90B5; Tue, 23 Apr 2019 19:54:45 -0700 (PDT) Date: Tue, 23 Apr 2019 19:54:45 -0700 (PDT) Message-Id: <20190423.195445.37329366818419219.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, idosch@mellanox.com, dsahern@gmail.com Subject: Re: [PATCH v2 net-next] mlxsw: spectrum_router: Prevent ipv6 gateway with v4 route via replace and append From: David Miller In-Reply-To: <20190423230329.9469-1-dsahern@kernel.org> References: <20190423230329.9469-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Apr 2019 19:54:46 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Tue, 23 Apr 2019 16:03:29 -0700 > From: David Ahern > > mlxsw currently does not support v6 gateways with v4 routes. Commit > 19a9d136f198 ("ipv4: Flag fib_info with a fib_nh using IPv6 gateway") > prevents a route from being added, but nothing stops the replace or > append. Add a catch for them too. > $ ip ro add 172.16.2.0/24 via 10.99.1.2 > $ ip ro replace 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0 > Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported. > $ ip ro append 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0 > Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported. > > Signed-off-by: David Ahern > --- > v2 > - added catch for append and moved up location to ADD case Applied, thanks David.