From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE36C10F14 for ; Tue, 23 Apr 2019 06:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBD2A20674 for ; Tue, 23 Apr 2019 06:31:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="aRk3qbUN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726155AbfDWGbL (ORCPT ); Tue, 23 Apr 2019 02:31:11 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34350 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfDWGbL (ORCPT ); Tue, 23 Apr 2019 02:31:11 -0400 Received: by mail-wr1-f65.google.com with SMTP id c6so12873396wrm.1 for ; Mon, 22 Apr 2019 23:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZAkr0bIsR8A1A8R8ZeGtUAauTCWdioGJSlevuw7cVig=; b=aRk3qbUNyMcOUZwzdx5kCStwobgGTqjvVtSTC/JThu8MWXTyast6kS/CLl2VGHgjON GlVKBfV71BJ5+ioUGDdWoUtNjcK3d1rOvDjhQjCgFVfwE7MQ8F3Iv+UEjOKRoSpdESFI TK6P0DdTfOgKE2K/vk+1AyofeDZRomjvNPIRRJUoG01OrK5z2ICyoW3UvO0HIujp4+QI M87xX0dhB+wBZOO8K9Fn2y7SQYIaQ+qknWNxcMRjHgc34Nhel172F9hZvKfGhivqbyAA B5BzPe5O9DiwVUk3yQcQinjg8FNdOdek5HbJ2nDKunVC8x8pxdu2mwdcYG1DP/Yh36QY HgUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZAkr0bIsR8A1A8R8ZeGtUAauTCWdioGJSlevuw7cVig=; b=E/w36yjPIbf9IZt0G32IDohD96n6JyYYKd77Xm7G2gwh9qcxBpmSQ8SKL+wvY4H9jo MDoUqsebZ9bt7Yv2wy5g86urNRL5z5jXteRyv6HcepqJPuTxtDBQ9hi1fhxh+/6FMVy7 3CVCBgagbsr1dUGEOulWq2Q281jTii7lke4unNDFUp4g8UWdgwsdIrxoFW6fu7v7pbDl Mf/H8VZzZP3B8Ov3d3ziK1APlLN9wKZ+ljK7udvIMZX6mUDz+jXRImPTLK4yKl5xNGiD aKCLp+N6wGtQ6tH2fic2smDR3CPwEqb/2xPmoTFDxhl/PG0nDqym31RhujEB08QA/1Bf UYnw== X-Gm-Message-State: APjAAAUKbDuurW3ofPDpVe/BbdkhiV9MRsQKG9GA18BBSlnvUv7Jyh99 LypcbviZrpgPBDgbst5j2/D/dA== X-Google-Smtp-Source: APXvYqyXgdkfo0f2Na5e1J2ucCYGJVjskYhcHR3WomlcJRGdwLiMJI92Mb47pyTxT79BAVuNnjFj4w== X-Received: by 2002:a5d:4ed2:: with SMTP id s18mr6929204wrv.188.1556001069761; Mon, 22 Apr 2019 23:31:09 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id u6sm27752378wrg.72.2019.04.22.23.31.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 23:31:09 -0700 (PDT) Date: Tue, 23 Apr 2019 08:31:08 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Message-ID: <20190423063108.GB2677@nanopsycho.orion> References: <20190420102922.6001-1-jiri@resnulli.us> <20190420102922.6001-9-jiri@resnulli.us> <20190422122338.3e1049a4@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422122338.3e1049a4@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Apr 22, 2019 at 09:23:38PM CEST, jakub.kicinski@netronome.com wrote: >On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote: >> - err = ida_alloc(&nsim_bus_dev_ids, GFP_KERNEL); >> + err = ida_alloc_range(&nsim_bus_dev_ids, >> + id == ~0 ? 0 : id, id, GFP_KERNEL); > >#define for ~0 ? Sure, but this is remove in patch 15. Is it necessary?