From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B70C10F14 for ; Tue, 23 Apr 2019 09:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31DDD206A3 for ; Tue, 23 Apr 2019 09:15:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ld4Yu8Te" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727330AbfDWJPz (ORCPT ); Tue, 23 Apr 2019 05:15:55 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46651 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726553AbfDWJPy (ORCPT ); Tue, 23 Apr 2019 05:15:54 -0400 Received: by mail-pg1-f194.google.com with SMTP id v2so4869699pge.13 for ; Tue, 23 Apr 2019 02:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mJHdzqlLYWmMeUxr+oUxA4OIgNvGQxtYMGWCGsdpu9M=; b=ld4Yu8Te7MHtE1criY8C+lk1EF4nhKigKHqLFFm3NXTcNt282p/4n3PqidoFMbzdHU FIvXLZjGsaroXcFUcI2ZuVm0jscL6A+YHUOpecAoYAYAM4D5fAvJwg6ugem2/XLHkuO0 7guP1IAqb2INOcQbqLvtVjNw0I3Rc8GfWwEBvEYDGJJyFLqxf+CVVL2uOTYi/BAkyMAV ckkH2fMpE1xzTDuHywFKGTYNrg0sOe5TgSAZUGvrKrnYXACmaJEhQyY13gBEzAQLv0T7 WpttJsvZ30yT3FeKU2HG82RwnXQx0J+02K63NIajn1kVJuyzvn3GNqcIe+6TUt/SBA4o Oxfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mJHdzqlLYWmMeUxr+oUxA4OIgNvGQxtYMGWCGsdpu9M=; b=ksdGSp7k9qX+tQvlSrPCLp7y4n31AA0CHZeHbRtMeFaPOQ/tojHMMoBdJ4q+yBoLWI QYxiKoiM4Z1HWGHvJY+hywubLqPkAJR+foQDWMUVQb/eszNjIKLZ2RmgfQPGikPcVBAt RM4/gG5kjlNlP27RniZd0u6B9vFHuCRyNlncvKXPBLf6CHc1TOZeyX1RIMFGn9tvPTQC r7MEZ7A08ELh01e4ib6OumPJDxUL7FsK85heEoxmUUyFwlPws2S9bp9PViGutl3m9Tnf yx9l3iwSoJAk60EC6qxyO4kh3KoNRRYGKSOxhPqaR7CsARQdOztzBpLidjSGuR3yTlRD Q5sg== X-Gm-Message-State: APjAAAWAxE9emmDxUE2kTK5W/f5bDqfetfgkQTrkQQm1OK7VC1mQM5st Yxk16+lG9eYxqB3JG2Edt9Y= X-Google-Smtp-Source: APXvYqy9UxOYbDY/XoMBzYaVg4bFC+LeaP/TWLEnK+bHC615v8CXd5+Y6e42mS5xMWuDATnv7IQFaA== X-Received: by 2002:a65:6110:: with SMTP id z16mr14940048pgu.131.1556010954017; Tue, 23 Apr 2019 02:15:54 -0700 (PDT) Received: from dhcp-12-139.nay.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id n22sm20114136pfa.51.2019.04.23.02.15.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 02:15:53 -0700 (PDT) Date: Tue, 23 Apr 2019 17:15:43 +0800 From: Hangbin Liu To: Miroslav Lichvar Cc: Richard Cochran , Jiri Benc , netdev@vger.kernel.org, David Miller , Patrick McHardy , stefan.sorensen@spectralink.com Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Message-ID: <20190423091543.GF18865@dhcp-12-139.nay.redhat.com> References: <20190320022333.3378-1-liuhangbin@gmail.com> <20190417061452.GA18865@dhcp-12-139.nay.redhat.com> <20190417154306.om6rjkxq4hikhsht@localhost> <20190417205958.6508bda2@redhat.com> <20190418033157.irs25halxnemh65y@localhost> <20190418080509.GD5984@localhost> <20190423041817.GE18865@dhcp-12-139.nay.redhat.com> <20190423083141.GA5188@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423083141.GA5188@localhost> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 23, 2019 at 10:31:41AM +0200, Miroslav Lichvar wrote: > On Tue, Apr 23, 2019 at 12:18:17PM +0800, Hangbin Liu wrote: > > On Thu, Apr 18, 2019 at 10:05:09AM +0200, Miroslav Lichvar wrote: > > > select a more general filter. A container could run a PTP clock if it > > > > Do you have an idea about how to select a general filter? If we have enabled > > HWTSTAMP_FILTER_PTP_V2_L4_SYNC on host and a user in container want to enable > > HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ, then which one is more general? > > In this case neither is a more general filter of the other. If Yes, that what I mean, some times it's hard to say which one is more general. like PTP_V2_L4_EVENT and PTP_V2_L2_SYNC. > V2_L4_SYNC is already selected, only the following filters could be > selected on the macvlan interface: > > HWTSTAMP_FILTER_PTP_V2_L4_SYNC, > HWTSTAMP_FILTER_PTP_V2_L4_EVENT, > HWTSTAMP_FILTER_PTP_V2_SYNC, > HWTSTAMP_FILTER_PTP_V2_EVENT, > HWTSTAMP_FILTER_ALL, > > I think one way to check this would be to assign each filter a > (16-bit?) value where the individual bits correspond to the message > types and the newly selected filter would have to contain all bits of > the old one. Just like I said, how to compare with different types. Thanks Hangbin