All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Nikita Danilov <Nikita.Danilov@aquantia.com>,
	Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>
Subject: Re: [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job
Date: Tue, 23 Apr 2019 17:37:25 -0700	[thread overview]
Message-ID: <20190423173725.2ee38a04@cakuba.netronome.com> (raw)
In-Reply-To: <7cd467eace3922fa693d30bba1fb5574fcea72fa.1556024424.git.igor.russkikh@aquantia.com>

On Tue, 23 Apr 2019 13:17:55 +0000, Igor Russkikh wrote:
> Service timer callback fetches statistics from FW and that may cause
> a long delay in error cases. We also now need to use fw mutex
> to prevent concurrent access to FW, thus - extract that logic
> from timer callback into the job in the separate work queue.
> 
> Signed-off-by: Nikita Danilov <ndanilov@aquantia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>

The split into patches is slightly imperfect here.

Patch 10 "introduces" a mutex, which nothing is using, yet.

Patch 11 starts some async work, which the mutex is needed for.

Patches 12 and 13 wrap other FW call sites...

Isn't it better to squash 12 and 13 into 10, this way 11 is safe 
to access FW from the work queue?

  reply	other threads:[~2019-04-24  0:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 13:17 [PATCH v2 net-next 00/16] net: atlantic: Aquantia driver updates 2019-04 Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 01/16] net: aquantia: add infrastructure to readout chip temperature Igor Russkikh
2019-04-23 19:12   ` Andrew Lunn
2019-04-24  8:29     ` Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for " Igor Russkikh
2019-04-23 19:17   ` Andrew Lunn
2019-04-24  8:28     ` Igor Russkikh
2019-04-24 12:32       ` Andrew Lunn
2019-04-23 13:17 ` [PATCH v2 net-next 03/16] net: aquantia: add link interrupt fields Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 04/16] net: aquantia: link interrupt handling function Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 05/16] net: aquantia: create global service workqueue Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 06/16] net: aquantia: link status irq handling Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 07/16] net: aquantia: improve ifup link detection Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 08/16] net: aquantia: use macros for better visibility Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 09/16] net: aquantia: user correct MSI irq type Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 10/16] net: aquantia: introduce fwreq mutex Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job Igor Russkikh
2019-04-24  0:37   ` Jakub Kicinski [this message]
2019-04-24  8:31     ` Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 12/16] net: aquantia: wrap fw ops by mutex Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 13/16] net: aquantia: fetch up to date statistics on ethtool request Igor Russkikh
2019-04-23 13:18 ` [PATCH v2 net-next 14/16] net: aquantia: get total counters from DMA block Igor Russkikh
2019-04-23 13:18 ` [PATCH v2 net-next 15/16] net: aquantia: fixups on 64bit dma counters Igor Russkikh
2019-04-23 13:18 ` [PATCH v2 net-next 16/16] net: aquantia: remove outdated device ids Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190423173725.2ee38a04@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=Dmitry.Bogdanov@aquantia.com \
    --cc=Igor.Russkikh@aquantia.com \
    --cc=Nikita.Danilov@aquantia.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.