From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 07/12] drm/legacy: move init/destroy of struct members into inlines Date: Tue, 23 Apr 2019 20:46:38 +0200 Message-ID: <20190423184638.GC9857@phenom.ffwll.local> References: <20190423020041.32702-1-airlied@gmail.com> <20190423020041.32702-8-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0BDE895C1 for ; Tue, 23 Apr 2019 18:46:42 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id j20so13585207edq.10 for ; Tue, 23 Apr 2019 11:46:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190423020041.32702-8-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMjMsIDIwMTkgYXQgMTI6MDA6MzZQTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3Jv dGU6Cj4gRnJvbTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiAKPiBUaGlzIHdp bGwgYWxsb3cgZWFzaWVyIHJlbW92YWwgbGF0ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBB aXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9k cnYuYyAgICB8IDEwICsrKy0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9sZWdhY3kuaCB8 IDE0ICsrKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwg NyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPiBpbmRleCAxOGY0NWY5YTk1NWMuLmU0ZjM2 YzVjY2ZjZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+IEBAIC02NTksMjAgKzY1OSwxNiBAQCBpbnQgZHJt X2Rldl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkvKiBubyBwZXItZGV2aWNlIGZl YXR1cmUgbGltaXRzIGJ5IGRlZmF1bHQgKi8KPiAgCWRldi0+ZHJpdmVyX2ZlYXR1cmVzID0gfjB1 Owo+ICAKPiArCWRybV9sZWdhY3lfaW5pdF9tZW1iZXJzKGRldik7Cj4gIAlJTklUX0xJU1RfSEVB RCgmZGV2LT5maWxlbGlzdCk7Cj4gIAlJTklUX0xJU1RfSEVBRCgmZGV2LT5maWxlbGlzdF9pbnRl cm5hbCk7Cj4gIAlJTklUX0xJU1RfSEVBRCgmZGV2LT5jbGllbnRsaXN0KTsKPiAtCUlOSVRfTElT VF9IRUFEKCZkZXYtPmN0eGxpc3QpOwo+IC0JSU5JVF9MSVNUX0hFQUQoJmRldi0+dm1hbGlzdCk7 Cj4gLQlJTklUX0xJU1RfSEVBRCgmZGV2LT5tYXBsaXN0KTsKPiAgCUlOSVRfTElTVF9IRUFEKCZk ZXYtPnZibGFua19ldmVudF9saXN0KTsKPiAgCj4gLQlzcGluX2xvY2tfaW5pdCgmZGV2LT5idWZf bG9jayk7Cj4gIAlzcGluX2xvY2tfaW5pdCgmZGV2LT5ldmVudF9sb2NrKTsKPiAgCW11dGV4X2lu aXQoJmRldi0+c3RydWN0X211dGV4KTsKPiAgCW11dGV4X2luaXQoJmRldi0+ZmlsZWxpc3RfbXV0 ZXgpOwo+ICAJbXV0ZXhfaW5pdCgmZGV2LT5jbGllbnRsaXN0X211dGV4KTsKPiAtCW11dGV4X2lu aXQoJmRldi0+Y3R4bGlzdF9tdXRleCk7Cj4gIAltdXRleF9pbml0KCZkZXYtPm1hc3Rlcl9tdXRl eCk7Cj4gIAo+ICAJZGV2LT5hbm9uX2lub2RlID0gZHJtX2ZzX2lub2RlX25ldygpOwo+IEBAIC03 MjQsNyArNzIwLDcgQEAgaW50IGRybV9kZXZfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICBlcnJfZnJlZToKPiAgCXB1dF9kZXZpY2UoZGV2LT5kZXYpOwo+ICAJbXV0ZXhfZGVzdHJveSgm ZGV2LT5tYXN0ZXJfbXV0ZXgpOwo+IC0JbXV0ZXhfZGVzdHJveSgmZGV2LT5jdHhsaXN0X211dGV4 KTsKPiArCWRybV9sZWdhY3lfZGVzdHJveV9tZW1iZXJzKGRldik7Cj4gIAltdXRleF9kZXN0cm95 KCZkZXYtPmNsaWVudGxpc3RfbXV0ZXgpOwo+ICAJbXV0ZXhfZGVzdHJveSgmZGV2LT5maWxlbGlz dF9tdXRleCk7Cj4gIAltdXRleF9kZXN0cm95KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gQEAgLTgw MCw3ICs3OTYsNyBAQCB2b2lkIGRybV9kZXZfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ ICAJcHV0X2RldmljZShkZXYtPmRldik7Cj4gIAo+ICAJbXV0ZXhfZGVzdHJveSgmZGV2LT5tYXN0 ZXJfbXV0ZXgpOwo+IC0JbXV0ZXhfZGVzdHJveSgmZGV2LT5jdHhsaXN0X211dGV4KTsKPiArCWRy bV9sZWdhY3lfZGVzdHJveV9tZW1iZXJzKGRldik7Cj4gIAltdXRleF9kZXN0cm95KCZkZXYtPmNs aWVudGxpc3RfbXV0ZXgpOwo+ICAJbXV0ZXhfZGVzdHJveSgmZGV2LT5maWxlbGlzdF9tdXRleCk7 Cj4gIAltdXRleF9kZXN0cm95KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fbGVnYWN5LmggYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2xlZ2FjeS5o Cj4gaW5kZXggZWY0MTlkNTAwZTUxLi4yMGM0YmVmYzQ3NmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9sZWdhY3kuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbGVnYWN5 LmgKPiBAQCAtMTM2LDUgKzEzNiwxOSBAQCBpbnQgZHJtX2xlZ2FjeV9zZ19hbGxvYyhzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICBpbnQgZHJtX2xlZ2FjeV9zZ19mcmVlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAkJICAgICAgIHN0cnVjdCBkcm1f ZmlsZSAqZmlsZV9wcml2KTsKPiAgCj4gK3N0YXRpYyBpbmxpbmUgdm9pZCBkcm1fbGVnYWN5X2lu aXRfbWVtYmVycyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICt7Cj4gKwlJTklUX0xJU1RfSEVB RCgmZGV2LT5jdHhsaXN0KTsKPiArCUlOSVRfTElTVF9IRUFEKCZkZXYtPnZtYWxpc3QpOwo+ICsJ SU5JVF9MSVNUX0hFQUQoJmRldi0+bWFwbGlzdCk7Cj4gKwlzcGluX2xvY2tfaW5pdCgmZGV2LT5i dWZfbG9jayk7Cj4gKwltdXRleF9pbml0KCZkZXYtPmN0eGxpc3RfbXV0ZXgpOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgaW5saW5lIHZvaWQgZHJtX2xlZ2FjeV9kZXN0cm95X21lbWJlcnMoc3RydWN0IGRy bV9kZXZpY2UgKmRldikKPiArewo+ICsJbXV0ZXhfZGVzdHJveSgmZGV2LT5jdHhsaXN0X211dGV4 KTsKPiArfQoKSSB0aGluayB3aXRoIHRoZSBvdGhlciBpbmxpbmUgZnVuY3Rpb25zIHlvdSBzdHVm ZiBpbnRvIGRybV9sZWdhY3kuaCBpdCdkCmp1c3RpZmljYXRpb24gZW5vdWdoIHRvIGNyZWF0ZSBh IGRybV9sZWdhY3lfbWlzYy5jLiBOb3QgZHJtX2xlZ2FjeS5jCmJlY2F1c2UgdGhlbiB5b3UgY2Fu J3QgaW5jbHVkZSBvdGhlciBmaWxlcyBpbnRvIGRybV9sZWdhY3kua28gYmVjYXVzZQpLYnVpbGQg aXMgc2lsbHkgOi0pCgpXaXRoIHRoYXQ6IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGZmd2xsLmNoPgoKPiArCj4gIHZvaWQgZHJtX2xlZ2FjeV9sb2NrX21hc3Rlcl9j bGVhbnVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fbWFzdGVyICptYXN0ZXIp Owo+ICAjZW5kaWYgLyogX19EUk1fTEVHQUNZX0hfXyAqLwo+IC0tIAo+IDIuMjAuMQo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVs IG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA==