From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD088C282DD for ; Tue, 23 Apr 2019 19:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACD5121773 for ; Tue, 23 Apr 2019 19:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W2e9QA/F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbfDWTEr (ORCPT ); Tue, 23 Apr 2019 15:04:47 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:46910 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfDWTEr (ORCPT ); Tue, 23 Apr 2019 15:04:47 -0400 Received: by mail-ed1-f67.google.com with SMTP id d1so13616442edd.13 for ; Tue, 23 Apr 2019 12:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+LNd4+TT8NxoX7ZZ6T8bIv524WB2VxzjHQPPCkI8wNw=; b=W2e9QA/F+5DMPiKatiC3Kgku69k8HWNnJW+0maAS3Ur+f8UdjujRUQf99TcoT1QRez PVWKQNgVOjDut9TS0J72g7iln6rjRvE6Ch50vnqK2GmhDTLKTCWFijg2QrdTTPZYDxDf VyF0hFr9vTAgyxfWLJEjsKo/pbM8Zi1TY8JVbZQ8OB04u1SOtoK+mD/aY21oXYIYU0Xe XS7GtdjhwUZOiRDeblKADzLSpg9dSsFbqpMCaK+ItFHpxcKQJZapIaAYX1z0Cd5rrst4 m6d8D13Ela9tvLeVAycBQr4wsJZej92JF7r3g7TGiUd/2a/G0EtubnEakO6cnb+IubaQ DSmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+LNd4+TT8NxoX7ZZ6T8bIv524WB2VxzjHQPPCkI8wNw=; b=WyxSS0t1morPpYanupJZbQswWHJspbx9mL//nWUNTxPU/05lXPPDpSLhQfnMzo54Sk M8kxt7x7K3LpLaB7MSDGXkrAZIrlPgS9UmGwIoDHY0oRSgOpxpppTCvSStPnOMY1sZfH RpPcxKnxX308XyXC9WmejhzKA1KiYII50gd3MfCVx3K/6xMKaf6yneSQjXZfCJBNfZ8L HaoPE/ahQQRh8cKJxE9yNq4EY8UWiIsHsZ8PZYRH/lWAMEfwVZuZWcasJPG2jvB8Nnqh PNtMntVJZZ4OylUmbYxggi26U6YI/cwNu/mbgTXtjD7owcSFeT4Cy5CvnRm9P4rNd+h8 caCQ== X-Gm-Message-State: APjAAAXzNHcDXVdAo+GQFM24BVOspC0fMkn4dlWRqZm62aE7ALPizzrw mqw65P/LKA56mkqCC8eKjR0= X-Google-Smtp-Source: APXvYqyS+1nc8YXhKmR9jcKJ1JUgTCG0qswwa+D9uuWjN1C8DDwcPqQxCp1MY5On6nrevp/jOyALNg== X-Received: by 2002:a50:b544:: with SMTP id z4mr17320436edd.95.1556046285199; Tue, 23 Apr 2019 12:04:45 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:2b:2b84::2]) by smtp.gmail.com with ESMTPSA id w40sm1202991edb.50.2019.04.23.12.04.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 12:04:44 -0700 (PDT) From: Nathan Chancellor To: Greg Kroah-Hartman , Sasha Levin , stable@vger.kernel.org Cc: Nick Desaulniers , clang-built-linux@googlegroups.com, Matthias Kaehlcke , Peter Zijlstra , Masahiro Yamada , Nathan Chancellor Subject: [PATCH 4.4] Revert "kbuild: use -Oz instead of -Os when using clang" Date: Tue, 23 Apr 2019 12:04:24 -0700 Message-Id: <20190423190426.18720-4-natechancellor@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190423190426.18720-1-natechancellor@gmail.com> References: <20190423190426.18720-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Matthias Kaehlcke commit a75bb4eb9e565b9f5115e2e8c07377ce32cbe69a upstream. The clang option -Oz enables *aggressive* optimization for size, which doesn't necessarily result in smaller images, but can have negative impact on performance. Switch back to the less aggressive -Os. This reverts commit 6748cb3c299de1ffbe56733647b01dbcc398c419. Suggested-by: Peter Zijlstra Signed-off-by: Matthias Kaehlcke Reviewed-by: Nick Desaulniers Signed-off-by: Masahiro Yamada Signed-off-by: Nathan Chancellor --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 35be7983ef2d..0b7d9fb13fcc 100644 --- a/Makefile +++ b/Makefile @@ -639,7 +639,7 @@ KBUILD_CFLAGS += $(call cc-disable-warning, int-in-bool-context) KBUILD_CFLAGS += $(call cc-disable-warning, attribute-alias) ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) +KBUILD_CFLAGS += -Os else ifdef CONFIG_PROFILE_ALL_BRANCHES KBUILD_CFLAGS += -O2 -- 2.21.0