From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3834C10F03 for ; Tue, 23 Apr 2019 19:04:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9289921773 for ; Tue, 23 Apr 2019 19:04:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="alAMkbFm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725975AbfDWTEt (ORCPT ); Tue, 23 Apr 2019 15:04:49 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40104 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfDWTEt (ORCPT ); Tue, 23 Apr 2019 15:04:49 -0400 Received: by mail-ed1-f67.google.com with SMTP id d46so13643988eda.7 for ; Tue, 23 Apr 2019 12:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X48V/55ujpGdJGLrC/+tNAu3foDtrR2YL0tNOiCNQiU=; b=alAMkbFmH3XrXByoiKkHBRlSEVddImnem6ZWSq0Vf0vjNXVGUVLbrqkgo5FJ4Vuw98 OnSYEnpPrdgK4fgifn16tdW35mPP3mdAOaJZMAZRo/k7gPt5Rhvy9eofJ4zF9/E6ArY+ 7WSTPiNojMJGgbEe84db2pSzBg4q05jnOWX5LTjpWTYdmd02R8TZB/vak2NIhfMlVO4q wKBrqQXWVkZy5mGkqyMWEtKpXkVP7FVJMt1+lQdyzribJZQ+B3O6MeGN/rFzpmqfvXUc mRtRVmb//u6N/5DCB4SNx4mwIOaj++MsHTz1IjMfUYeHZcPvCl54i076ON1qmCcAtTrw a8aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X48V/55ujpGdJGLrC/+tNAu3foDtrR2YL0tNOiCNQiU=; b=HhDtpN0fX+fbo2RnSw2zSR7D8ujrFfzAMP2c64/baK08WAmk8uUmmLGX3Pjk70IM/k Za+F7ut/xnHIqQSEDZ+NTxTGRDGoGY/Lmtde1AUdN1Th42XUgxv6J7ey8OYPFxIhi+hE v91XSc1QywW/J5c9E+C2d4zSe9M8Fhjs4UvL2EG3hupA+Gur6d2/JAkvyJhfX+BwxDbi E5VXeVP2otSLaCxAB1W+HUNG2EW5nFdLyCrFFXcLDxlK/4ZbJXhRCt5UsnMhX0RXXrjc isz12tkfHOWE06m7bVzdYS+8OACaIPydvbgMl2yfMJFArg4ipTy4XsKmJ4ISiXuZQr94 j93w== X-Gm-Message-State: APjAAAXWdyeLiQLwTXGCmWNvCjbpVdmnZfyD484Q9thurRKtIgwI7L63 n2a+C3IicZduBJntJpiYjIA= X-Google-Smtp-Source: APXvYqwlzWjlobyExSSFZUZbVRmoR0lZ03pNuWDl6rbjSp1GCcHjEd0Qnwoxhh1nxloN292kAvmwEQ== X-Received: by 2002:a17:906:cc9c:: with SMTP id oq28mr13775665ejb.287.1556046287155; Tue, 23 Apr 2019 12:04:47 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:2b:2b84::2]) by smtp.gmail.com with ESMTPSA id w40sm1202991edb.50.2019.04.23.12.04.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 12:04:46 -0700 (PDT) From: Nathan Chancellor To: Greg Kroah-Hartman , Sasha Levin , stable@vger.kernel.org Cc: Nick Desaulniers , clang-built-linux@googlegroups.com, Matthias Kaehlcke , Peter Zijlstra , Masahiro Yamada , Nathan Chancellor Subject: [PATCH 4.9] Revert "kbuild: use -Oz instead of -Os when using clang" Date: Tue, 23 Apr 2019 12:04:25 -0700 Message-Id: <20190423190426.18720-5-natechancellor@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190423190426.18720-1-natechancellor@gmail.com> References: <20190423190426.18720-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Matthias Kaehlcke commit a75bb4eb9e565b9f5115e2e8c07377ce32cbe69a upstream. The clang option -Oz enables *aggressive* optimization for size, which doesn't necessarily result in smaller images, but can have negative impact on performance. Switch back to the less aggressive -Os. This reverts commit 6748cb3c299de1ffbe56733647b01dbcc398c419. Suggested-by: Peter Zijlstra Signed-off-by: Matthias Kaehlcke Reviewed-by: Nick Desaulniers Signed-off-by: Masahiro Yamada Signed-off-by: Nathan Chancellor --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 966069dab768..994e52be8685 100644 --- a/Makefile +++ b/Makefile @@ -655,8 +655,7 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) endif ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) -KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) +KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) else ifdef CONFIG_PROFILE_ALL_BRANCHES KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) -- 2.21.0