From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD68C10F03 for ; Tue, 23 Apr 2019 19:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BDA021773 for ; Tue, 23 Apr 2019 19:04:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GiEMBKJM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726075AbfDWTEv (ORCPT ); Tue, 23 Apr 2019 15:04:51 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:32881 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfDWTEv (ORCPT ); Tue, 23 Apr 2019 15:04:51 -0400 Received: by mail-ed1-f66.google.com with SMTP id d55so13670058ede.0 for ; Tue, 23 Apr 2019 12:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y/hXifgPAnjDUOP2AbFCxRFxE8PpQLb32HunxxQf6/E=; b=GiEMBKJMauYbuFTYhfRT//MyQ+XFzmqCGxWU9YSrEWhqWCRCjf8Z1K5nV5/xxZuw7Z KZoVt/S5IQfJfYgER6gPea26R8d1raoSWGrhutgSCOyZL2NBgLF9tzJRt6X83Bc3xDr4 nmlmWC2Eq+znzb1MBLfEn227k+8WPifIKHtY+B2dlLdzIFKvbKpmp0zsIZUe+QpEy8/w xSRvfK58ZN2LoFWx4i5rAyHgQe2F3anML4i+VgS+JF4RGwDF/RZVrkYBaCvc/zVjgy/c 3EvKEhyuBvlyT5fMzuNyVKf+ZdDgzbeBWLNn35PMB4MaEQJ0iQH3wFROKFGd8Vd4Mt0F kEbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y/hXifgPAnjDUOP2AbFCxRFxE8PpQLb32HunxxQf6/E=; b=qW4A86tXnSRGdKH5zpAL+oQGdnLqhl/DQxIwBkVQ91B9d/egUUJTkgV5auAdm3KJYe n0MjDIKrw+y9M752KH1+rNY0ucjM0R8n7794WAGzyw2bWyRGaAINBkwsq/SQXSXJeJ+F YgDl3tcWCPiEd4T7ZQVyXFqcKS+zdFiFZo/M7BCKNIOdNqlTdx9Rw5oSP3ILTNOtALAJ 5MLg2tGy+4qo9l7zZtQNa+TlMZNIj+QRTBUcbKRlhuLwjrufDb5mQKDQTrRoSTlXl1yN 3gJ1KTy0nc01Vl3XW7uMkhD63U0L7ueGyG/ecMZdj0tngf9L6njk6l2m00bFcxW+cxYT OKyw== X-Gm-Message-State: APjAAAX0K4K3jvcuuxOEpCVc92UEkr5J0IDlvgGLoCqbl12rTYhCETHD gY5UJZmKz17CEGYs/gZmANQ= X-Google-Smtp-Source: APXvYqxru0tdn0jHDt9fW6OyFkC83R8HAWBNx4bDN5YKnZ3j7nKIHHs0tnlY1NXDaWjoAqdGMr03+w== X-Received: by 2002:a17:906:6548:: with SMTP id u8mr1525889ejn.275.1556046289135; Tue, 23 Apr 2019 12:04:49 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:2b:2b84::2]) by smtp.gmail.com with ESMTPSA id w40sm1202991edb.50.2019.04.23.12.04.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 12:04:48 -0700 (PDT) From: Nathan Chancellor To: Greg Kroah-Hartman , Sasha Levin , stable@vger.kernel.org Cc: Nick Desaulniers , clang-built-linux@googlegroups.com, Matthias Kaehlcke , Peter Zijlstra , Masahiro Yamada , Nathan Chancellor Subject: [PATCH 5.0] Revert "kbuild: use -Oz instead of -Os when using clang" Date: Tue, 23 Apr 2019 12:04:26 -0700 Message-Id: <20190423190426.18720-6-natechancellor@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190423190426.18720-1-natechancellor@gmail.com> References: <20190423190426.18720-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Matthias Kaehlcke commit a75bb4eb9e565b9f5115e2e8c07377ce32cbe69a upstream. The clang option -Oz enables *aggressive* optimization for size, which doesn't necessarily result in smaller images, but can have negative impact on performance. Switch back to the less aggressive -Os. This reverts commit 6748cb3c299de1ffbe56733647b01dbcc398c419. Suggested-by: Peter Zijlstra Signed-off-by: Matthias Kaehlcke Reviewed-by: Nick Desaulniers Signed-off-by: Masahiro Yamada Signed-off-by: Nathan Chancellor --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index ef192ca04330..807ae0e3ff6e 100644 --- a/Makefile +++ b/Makefile @@ -678,8 +678,7 @@ KBUILD_CFLAGS += $(call cc-disable-warning, format-overflow) KBUILD_CFLAGS += $(call cc-disable-warning, int-in-bool-context) ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) -KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) +KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) else ifdef CONFIG_PROFILE_ALL_BRANCHES KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) -- 2.21.0