From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJ9OH-0006J5-SN for qemu-devel@nongnu.org; Wed, 24 Apr 2019 00:20:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJ9OH-0008Kw-0v for qemu-devel@nongnu.org; Wed, 24 Apr 2019 00:20:13 -0400 From: David Gibson Date: Wed, 24 Apr 2019 14:19:57 +1000 Message-Id: <20190424041959.4087-2-david@gibson.dropbear.id.au> In-Reply-To: <20190424041959.4087-1-david@gibson.dropbear.id.au> References: <20190424041959.4087-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 1/3] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Alex Williamson , Greg Kurz Cc: David Gibson , clg@kaod.org, qemu-ppc@nongnu.org These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by: David Gibson --- hw/pci/pcie_host.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c index 553db56778..1ee4945a6d 100644 --- a/hw/pci/pcie_host.c +++ b/hw/pci/pcie_host.c @@ -47,11 +47,6 @@ static void pcie_mmcfg_data_write(void *opaque, hwaddr= mmcfg_addr, } addr =3D PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit =3D pci_config_size(pci_dev); - if (limit <=3D addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <=3D addr < 4K has no effects. */ - return; - } pci_host_config_write_common(pci_dev, addr, limit, val, len); } =20 @@ -70,11 +65,6 @@ static uint64_t pcie_mmcfg_data_read(void *opaque, } addr =3D PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit =3D pci_config_size(pci_dev); - if (limit <=3D addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <=3D addr < 4K has no effects. */ - return ~0x0; - } return pci_host_config_read_common(pci_dev, addr, limit, len); } =20 --=20 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFD8C10F11 for ; Wed, 24 Apr 2019 04:21:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7144020878 for ; Wed, 24 Apr 2019 04:21:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="dqmU1hsN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7144020878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:35434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJ9Pg-0007ZJ-Hh for qemu-devel@archiver.kernel.org; Wed, 24 Apr 2019 00:21:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJ9OH-0006J5-SN for qemu-devel@nongnu.org; Wed, 24 Apr 2019 00:20:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJ9OH-0008Kw-0v for qemu-devel@nongnu.org; Wed, 24 Apr 2019 00:20:13 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:58057) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJ9OG-0007ud-C6; Wed, 24 Apr 2019 00:20:12 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 44pnCk0CFQz9s5c; Wed, 24 Apr 2019 14:20:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1556079602; bh=RHUPFBMkFYu4hWKdf7/Df7eUjK+AtZJm7HDAbd4EALs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dqmU1hsNsb6SjVgpIxonA0opKNJsMDmyJn7038h7aMhvDecrUo9mhBJJ/+a4UApSZ 4UxSDBSRdB6yaH2bT5FVyVEZ1/t6sspEqrsakOjQAiNyeQWy49XIZDjQNIn2h5p0oE aGnFhtCdh/z4hsMa3B9V6dyyDnuIgN1xS1PDi+Jk= From: David Gibson To: Marcel Apfelbaum , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Alex Williamson , Greg Kurz Date: Wed, 24 Apr 2019 14:19:57 +1000 Message-Id: <20190424041959.4087-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190424041959.4087-1-david@gibson.dropbear.id.au> References: <20190424041959.4087-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PATCH v2 1/3] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190424041957.A8cK_RZve2FWNWo1h0izZ5aQVNWWZ3gu992gkm6x6I8@z> These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by: David Gibson --- hw/pci/pcie_host.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c index 553db56778..1ee4945a6d 100644 --- a/hw/pci/pcie_host.c +++ b/hw/pci/pcie_host.c @@ -47,11 +47,6 @@ static void pcie_mmcfg_data_write(void *opaque, hwaddr= mmcfg_addr, } addr =3D PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit =3D pci_config_size(pci_dev); - if (limit <=3D addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <=3D addr < 4K has no effects. */ - return; - } pci_host_config_write_common(pci_dev, addr, limit, val, len); } =20 @@ -70,11 +65,6 @@ static uint64_t pcie_mmcfg_data_read(void *opaque, } addr =3D PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit =3D pci_config_size(pci_dev); - if (limit <=3D addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <=3D addr < 4K has no effects. */ - return ~0x0; - } return pci_host_config_read_common(pci_dev, addr, limit, len); } =20 --=20 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD928C04AB4 for ; Thu, 16 May 2019 12:32:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3C2120848 for ; Thu, 16 May 2019 12:32:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3C2120848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRFYP-0003a0-Ry for qemu-devel@archiver.kernel.org; Thu, 16 May 2019 08:32:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRFMh-00013h-9z for qemu-devel@nongnu.org; Thu, 16 May 2019 08:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRFMe-0002Hm-9J for qemu-devel@nongnu.org; Thu, 16 May 2019 08:20:03 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:45335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRFMe-0002Hd-6L for qemu-devel@nongnu.org; Thu, 16 May 2019 08:20:00 -0400 Received: by mail-qt1-f193.google.com with SMTP id t1so3510042qtc.12 for ; Thu, 16 May 2019 05:20:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EBhBqzmf7dvCSZtcFzIQFoj7mET0nH0WKBXoVmSjL3Q=; b=jDLsQKUuiKwPXsQNX5rkMgpbq7VBwlzZ30+Tz4wl53A8n7lOH9SrDfQt0HvpRsgFez 2W7O0Mzxc1jJrHx8Tv+VGCSWls8uE4iPLy+qPFXPsn33UkmYYtQ/26VSmqaDFzguuKFV IvkD/9AM3EcwC/HZG7F0UB5ZKsL10ZK1NjShpKr1MrDwrWaaw5fn2fY86bkJrVLEQzm7 hW0GwY38ok19aVise4CypheCltDi0gqhOJKHfA45daR/jf91dyndy8Ceqi/pZHU5hxm1 gQPFPGeEmPb3v7NXt9DwRrdADMrtVou/18vW2KVdWhDK2phraklbbUPlkDPmvHOaIi8a RG5g== X-Gm-Message-State: APjAAAXCxdABR6DBZmLQmk28B0B2HWv97H5flmQpIhjij7CBbG7T/ood Q+DpqGLenN5mjs2GYybY7/BwGNF9EPI= X-Google-Smtp-Source: APXvYqxdsANop/CbkY43Paxq84cQJ8WyrMRFG8AtmrhLRcMzJAcEUDnklJgA8KOvd5W4T58Pw1ruTg== X-Received: by 2002:a0c:c16c:: with SMTP id i41mr39979638qvh.183.1558009199539; Thu, 16 May 2019 05:19:59 -0700 (PDT) Received: from redhat.com ([185.54.206.10]) by smtp.gmail.com with ESMTPSA id l16sm2311804qtj.60.2019.05.16.05.19.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 16 May 2019 05:19:58 -0700 (PDT) Date: Thu, 16 May 2019 08:19:56 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190424041959.4087-2-david@gibson.dropbear.id.au> References: <20190515121146.7248-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190515121146.7248-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: [Qemu-devel] [PULL 21/37] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190516121956.SwGm4mCxJFB_NS5n6Oiol4yXYVWPUrw3qeZosX5VOSA@z> From: David Gibson These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by: David Gibson Message-Id: <20190424041959.4087-2-david@gibson.dropbear.id.au> --- hw/pci/pcie_host.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c index 553db56778..1ee4945a6d 100644 --- a/hw/pci/pcie_host.c +++ b/hw/pci/pcie_host.c @@ -47,11 +47,6 @@ static void pcie_mmcfg_data_write(void *opaque, hwaddr mmcfg_addr, } addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit = pci_config_size(pci_dev); - if (limit <= addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <= addr < 4K has no effects. */ - return; - } pci_host_config_write_common(pci_dev, addr, limit, val, len); } @@ -70,11 +65,6 @@ static uint64_t pcie_mmcfg_data_read(void *opaque, } addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit = pci_config_size(pci_dev); - if (limit <= addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <= addr < 4K has no effects. */ - return ~0x0; - } return pci_host_config_read_common(pci_dev, addr, limit, len); } -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4266DC04AAC for ; Mon, 20 May 2019 23:24:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 144BB20862 for ; Mon, 20 May 2019 23:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144BB20862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrdY-0001DL-8g for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 19:24:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrR1-0007bs-Jj for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSrR0-0008Bd-Nl for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:11 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:33111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSrR0-0008B1-K0 for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:10 -0400 Received: by mail-qt1-f193.google.com with SMTP id m32so18403694qtf.0 for ; Mon, 20 May 2019 16:11:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EBhBqzmf7dvCSZtcFzIQFoj7mET0nH0WKBXoVmSjL3Q=; b=CNjXvVUhtv791/tn1EHNqqA167ikBlZq7fb8XpX3Pgfb2123aoiy1aZBYsMpAR2Pgn NOJ48KUtbDLlpuAxrZkMWE9sNBB13Bw4a6I7sEYx73/7wYy7UbHPkacNwmIbcYdCTotb clsMaVkSGTGx8GC0jnD+bM2KnpWlCccQfNRqYyesF6t5VyJAWFrXYDOhSIIAPq8WPuQp TBbNW79d+HnyiaPm9RwFbokmdbQDqWEnNL9/KrpGk+oyaLmNMmnfJRl0+ZRZfe7hwQ89 F+oUuqBKrUwQbor1XkmgxB2Yj+MKX9+CjbtpjHXoKV4C8PhV2ONcur2rB89qUzPZ+0gP 2OHw== X-Gm-Message-State: APjAAAWrTRQ4f6Vb8gOieu0dW4MO06JRC+eHTaqSlsXAvEoL1fHkJjgQ GdLMJcfcdfQW8ro8QFxRz5I/s55y4+U= X-Google-Smtp-Source: APXvYqwQlpCyP1ZKsgJSYHHrnI57gtzNfc5RSXWKq62UPJfM5LiS7diQnAG0DzpvcMnAYEe96GoUDA== X-Received: by 2002:ac8:26a4:: with SMTP id 33mr47116734qto.188.1558393868882; Mon, 20 May 2019 16:11:08 -0700 (PDT) Received: from redhat.com (pool-173-76-105-71.bstnma.fios.verizon.net. [173.76.105.71]) by smtp.gmail.com with ESMTPSA id w5sm6465476qtc.50.2019.05.20.16.11.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 16:11:08 -0700 (PDT) Date: Mon, 20 May 2019 19:11:07 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190424041959.4087-2-david@gibson.dropbear.id.au> References: <20190520231008.20140-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190520231008.20140-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: [Qemu-devel] [PULL v2 20/36] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190520231107.E3jxL74MdrE-FQIn9FrbZ9JuLZzE_KtRsH9fcQ-uIr0@z> From: David Gibson These functions have an explicit test for accesses above the device's config size. But pci_host_config_{read,write}_common() which they're about to call already have checks against the config space limit and do the right thing. So, remove the redundant tests. Signed-off-by: David Gibson Message-Id: <20190424041959.4087-2-david@gibson.dropbear.id.au> --- hw/pci/pcie_host.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c index 553db56778..1ee4945a6d 100644 --- a/hw/pci/pcie_host.c +++ b/hw/pci/pcie_host.c @@ -47,11 +47,6 @@ static void pcie_mmcfg_data_write(void *opaque, hwaddr mmcfg_addr, } addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit = pci_config_size(pci_dev); - if (limit <= addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <= addr < 4K has no effects. */ - return; - } pci_host_config_write_common(pci_dev, addr, limit, val, len); } @@ -70,11 +65,6 @@ static uint64_t pcie_mmcfg_data_read(void *opaque, } addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr); limit = pci_config_size(pci_dev); - if (limit <= addr) { - /* conventional pci device can be behind pcie-to-pci bridge. - 256 <= addr < 4K has no effects. */ - return ~0x0; - } return pci_host_config_read_common(pci_dev, addr, limit, len); } -- MST