All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools lib traceevent: Change tag string for error
Date: Wed, 24 Apr 2019 08:08:29 -0400	[thread overview]
Message-ID: <20190424080829.0043469b@gandalf.local.home> (raw)
In-Reply-To: <20190424013802.27569-1-leo.yan@linaro.org>

On Wed, 24 Apr 2019 09:38:02 +0800
Leo Yan <leo.yan@linaro.org> wrote:

> The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it
> outputs error log on ARM64 platform:
> 
>   running test 33 '*:*'trace-cmd: No such file or directory
> 
>   [...]
> 
>   trace-cmd: Invalid argument
> 
> The trace event parsing code originally came from trace-cmd so it keeps
> the tag string "trace-cmd" for errors, this easily introduces the
> impression that perf tool launches trace-cmd command for trace event
> parsing, but in fact the related parsing is accomplished by traceevent
> lib.
> 
> This patch changes the tag string to "libtraceevent" so can avoid
> confusion and let users to be more easily to connect the error with
> traceevent lib.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Arnaldo,

Can you pull this into your tree.

-- Steve

> ---
>  tools/lib/traceevent/parse-utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/parse-utils.c b/tools/lib/traceevent/parse-utils.c
> index 77e4ec6402dd..e99867111387 100644
> --- a/tools/lib/traceevent/parse-utils.c
> +++ b/tools/lib/traceevent/parse-utils.c
> @@ -14,7 +14,7 @@
>  void __vwarning(const char *fmt, va_list ap)
>  {
>  	if (errno)
> -		perror("trace-cmd");
> +		perror("libtraceevent");
>  	errno = 0;
>  
>  	fprintf(stderr, "  ");


  reply	other threads:[~2019-04-24 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  1:38 Leo Yan
2019-04-24 12:08 ` Steven Rostedt [this message]
2019-04-24 12:44   ` Arnaldo Carvalho de Melo
2019-04-24 12:45     ` Leo Yan
2019-05-03  5:54 ` [tip:perf/urgent] " tip-bot for Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424080829.0043469b@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] tools lib traceevent: Change tag string for error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.