From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nicholas Piggin <npiggin@gmail.com>,
LKMM Maintainers -- Akira Yokosawa <akiyks@gmail.com>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Boqun Feng <boqun.feng@gmail.com>,
David Howells <dhowells@redhat.com>,
Daniel Lustig <dlustig@nvidia.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Kernel development list <linux-kernel@vger.kernel.org>,
Luc Maranget <luc.maranget@inria.fr>,
Alan Stern <stern@rowland.harvard.edu>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()
Date: Wed, 24 Apr 2019 01:29:48 -0700 [thread overview]
Message-ID: <20190424082948.GG3923@linux.ibm.com> (raw)
In-Reply-To: <20190423202831.GA4038@hirez.programming.kicks-ass.net>
On Tue, Apr 23, 2019 at 10:28:31PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 23, 2019 at 01:16:37PM -0700, Paul E. McKenney wrote:
>
> > Agreed, but I thought that one of the ideas going forward was to get
> > rid of smp_mb__{before,after}_atomic().
>
> It's not one I had considered.. I just wanted to get rid of this
> 'surprise' behaviour.
Ah, good point, your patch is in fact a midpoint between those two
positions. Just to make sure I understand:
1. Without your patch, smp_mb__{before,after}_atomic() orders
only against the atomic itself.
2. With your patch, smp_mb__{before,after}_atomic() orders against
the atomic itself and the accesses on the other side of that
atomic. However, it does not order the atomic against the
accesses on the other side of that atomic.
Putting things between the smp_mb__{before,after}_atomic()
and the atomic is in my opinion a bad idea, but in this case
they are not necessarily ordered.
3. Dispensing with smp_mb__{before,after}_atomic() would have
void RMW atomics fully ordered, but I suspect that it results
in ugly performance regressions.
Or am I still missing something?
Thanx, Paul
next prev parent reply other threads:[~2019-04-24 8:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 17:21 [PATCH] Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic() Alan Stern
2019-04-19 17:54 ` Paul E. McKenney
2019-04-19 18:00 ` Peter Zijlstra
2019-04-19 18:26 ` Paul E. McKenney
2019-04-20 0:26 ` Nicholas Piggin
2019-04-20 8:54 ` Paul E. McKenney
2019-04-23 12:17 ` Peter Zijlstra
2019-04-23 13:21 ` Paul E. McKenney
2019-04-23 13:26 ` Peter Zijlstra
2019-04-23 20:16 ` Paul E. McKenney
2019-04-23 20:28 ` Peter Zijlstra
2019-04-24 8:29 ` Paul E. McKenney [this message]
2019-04-24 8:44 ` Peter Zijlstra
2019-04-23 12:32 ` Peter Zijlstra
2019-04-23 13:30 ` Paul E. McKenney
2019-04-23 13:40 ` Peter Zijlstra
2019-04-23 20:19 ` Paul E. McKenney
2019-04-27 8:17 ` Andrea Parri
2019-04-27 8:36 ` Paul E. McKenney
2019-04-29 9:24 ` Johan Hovold
2019-04-29 14:49 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424082948.GG3923@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.