All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Jiri Kosina <jikos@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Miroslav Benes <mbenes@suse.cz>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	Petr Mladek <pmladek@suse.com>
Subject: [PATCH 1/3] livepatch: Convert error about unsupported reliable stacktrace into a warning
Date: Wed, 24 Apr 2019 10:55:48 +0200	[thread overview]
Message-ID: <20190424085550.29612-2-pmladek@suse.com> (raw)
In-Reply-To: <20190424085550.29612-1-pmladek@suse.com>

The commit d0807da78e11d46f ("livepatch: Remove immediate feature") caused
that any livepatch was refused when reliable stacktraces were not supported
on the given architecture.

The limitation is too strong. User space processes are safely migrated
even when entering or leaving the kernel. Kthreads transition would
need to get forced. But it is safe when:

   + The livepatch does not change the semantic of the code.
   + Callbacks do not depend on a safely finished transition.

Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
---
 kernel/livepatch/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index eb0ee10a1981..14f33ab6c583 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)
 		return -ENODEV;
 
 	if (!klp_have_reliable_stack()) {
-		pr_err("This architecture doesn't have support for the livepatch consistency model.\n");
-		return -EOPNOTSUPP;
+		pr_warn("This architecture doesn't have support for the livepatch consistency model.\n");
+		pr_warn("The livepatch transition may never complete.\n");
 	}
 
-
 	mutex_lock(&klp_mutex);
 
 	ret = klp_init_patch_early(patch);
-- 
2.16.4


  reply	other threads:[~2019-04-24  8:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  8:55 [PATCH 0/3] livepatch/stacktrace: Clean up of reliable stacktrace errors Petr Mladek
2019-04-24  8:55 ` Petr Mladek [this message]
2019-04-24 15:51   ` [PATCH 1/3] livepatch: Convert error about unsupported reliable stacktrace into a warning Josh Poimboeuf
2019-04-24 18:31   ` Miroslav Benes
2019-04-25  3:18   ` Kamalesh Babulal
2019-04-29 14:44   ` Petr Mladek
2019-04-24  8:55 ` [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable() Petr Mladek
2019-04-24  9:07   ` Petr Mladek
2019-04-24 15:50   ` Josh Poimboeuf
2019-04-24 15:51   ` Josh Poimboeuf
2019-04-24 18:35   ` Miroslav Benes
2019-04-25  3:22   ` Kamalesh Babulal
2019-04-24  8:55 ` [PATCH 3/3] livepatch: Cleanup message handling in klp_try_switch_task() Petr Mladek
2019-04-24 10:41   ` Jiri Kosina
2019-04-24 12:49     ` Petr Mladek
2019-04-24 15:55   ` Josh Poimboeuf
2019-04-24 18:48     ` Miroslav Benes
2019-04-25  3:32       ` Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424085550.29612-2-pmladek@suse.com \
    --to=pmladek@suse.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.