All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking/percpu-rwsem: Add DEFINE_PERCPU_RWSEM(), use it to initialize cgroup_threadgroup_rwsem
Date: Wed, 24 Apr 2019 12:31:55 +0200	[thread overview]
Message-ID: <20190424103155.GA9642@gmail.com> (raw)
In-Reply-To: <20190423163241.GA15866@redhat.com>


* Oleg Nesterov <oleg@redhat.com> wrote:

> Turn DEFINE_STATIC_PERCPU_RWSEM() into __DEFINE_PERCPU_RWSEM() with the
> additional "is_static" argument to introduce DEFINE_PERCPU_RWSEM().
> 
> Change cgroup.c to use DEFINE_PERCPU_RWSEM(cgroup_threadgroup_rwsem).
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
>  include/linux/percpu-rwsem.h | 8 ++++++--
>  kernel/cgroup/cgroup.c       | 3 +--
>  2 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/percpu-rwsem.h b/include/linux/percpu-rwsem.h
> index 6887636..2809b44 100644
> --- a/include/linux/percpu-rwsem.h
> +++ b/include/linux/percpu-rwsem.h
> @@ -17,14 +17,18 @@ struct percpu_rw_semaphore {
>  	int			readers_block;
>  };
>  
> -#define DEFINE_STATIC_PERCPU_RWSEM(name)				\
> +#define __DEFINE_PERCPU_RWSEM(name, is_static)				\
>  static DEFINE_PER_CPU(unsigned int, __percpu_rwsem_rc_##name);		\
> -static struct percpu_rw_semaphore name = {				\
> +is_static struct percpu_rw_semaphore name = {				\
>  	.rss = __RCU_SYNC_INITIALIZER(name.rss),			\
>  	.read_count = &__percpu_rwsem_rc_##name,			\
>  	.rw_sem = __RWSEM_INITIALIZER(name.rw_sem),			\
>  	.writer = __RCUWAIT_INITIALIZER(name.writer),			\
>  }
> +#define DEFINE_PERCPU_RWSEM(name)		\
> +	__DEFINE_PERCPU_RWSEM(name, /* not static */)
> +#define DEFINE_STATIC_PERCPU_RWSEM(name)	\
> +	__DEFINE_PERCPU_RWSEM(name, static)

Which tree is this against? It doesn't apply to tip:master nor latest 
-git.

Thanks,

	Ingo

  reply	other threads:[~2019-04-24 10:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 16:32 [PATCH] locking/percpu-rwsem: Add DEFINE_PERCPU_RWSEM(), use it to initialize cgroup_threadgroup_rwsem Oleg Nesterov
2019-04-24 10:31 ` Ingo Molnar [this message]
2019-04-24 11:00   ` Oleg Nesterov
2019-04-24 11:02     ` Ingo Molnar
2019-04-24 18:34       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424103155.GA9642@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.