From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DF5C282E1 for ; Wed, 24 Apr 2019 12:31:13 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8B15720811 for ; Wed, 24 Apr 2019 12:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B15720811 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26D5D1B127; Wed, 24 Apr 2019 14:31:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9F5C96CD8 for ; Wed, 24 Apr 2019 14:31:10 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 05:31:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="153334028" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by orsmga002.jf.intel.com with SMTP; 24 Apr 2019 05:31:07 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 13:31:06 +0100 Date: Wed, 24 Apr 2019 13:31:06 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190424123105.GA1892@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423220644.54589-4-bruce.richardson@intel.com> <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> <20190424104119.GB1885@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > > The pkg-config file generated as part of the build of DPDK should > > > > allow > > > > applications to be built with an installed DPDK. We can test this > > > > as > > > > part of the build by doing an install of DPDK to a temporary > > > > directory > > > > within the build folder, and by then compiling up a few sample > > > > apps > > > > using make working off that directory. > > > > > > > > Signed-off-by: Bruce Richardson < > > > > bruce.richardson@intel.com > > > > > > > > > > > > --- devtools/test-meson-builds.sh | 17 +++++++++++++++++ 1 file > > > > changed, 17 insertions(+) > > > > > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > > > > builds.sh index 630a1a6fe..dfba2a782 100755 --- > > > > a/devtools/test-meson-builds.sh +++ b/devtools/test-meson- > > > > builds.sh @@ > > > > -90,3 +90,20 @@ if command -v $c >/dev/null 2>&1 ; then > > > > $use_shared > > > > --cross-file $f done fi + +############## +# Test installation of > > > > the > > > > x86-default target, to be used for checking +# the sample apps > > > > build > > > > using the pkg-config file for cflags and libs +############### > > > > +build_path=build-x86-default +DESTDIR=`pwd`/$build_path/install- > > > > root ; > > > > export DESTDIR > > > > +PKG_CONFIG_PATH=$DESTDIR/usr/local/lib64/pkgconfig ; > > > > export PKG_CONFIG_PATH +$ninja_cmd -C $build_path install + +# > > > > rather > > > > than hacking our environment, just edit the .pc file prefix value > > > > +sed > > > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > > > > > What about just using meson's prefix option instead? Which is how > > > it > > > would be used in a real use case > > > > > > > I don't think that would fully work, as my understanding is that the > > prefix > > option would apply only to the /usr/local parts, but not to the > > kernel > > modules which would still try and install in /lib/. > > > > /Bruce > > What about doing a meson configure -Denable_kmods=false before the > ninja install? The modules are not needed for that test anyway, right? > Alternatively, the kernel src dir could be symlinked in the build path, > and the kernel_dir option could be used > > I'm just worried that the test should be as "realistic" as possible, to > avoid missing something > Yes, I did think of that too, but it does mean doing another configuration run in meson, and possibly a rebuild too if the rte_build_config.h file changes. Therefore I decided to use DESTDIR for the sake of speed here. I assumed there would be a pkg-config variable to adjust the output paths based on a sysroot, but couldn't find a suitable one. In any case, I'll see about changing things as you suggest in V2 - correctness is more important that speed here. /Bruce