From: Petri Latvala <petri.latvala@intel.com>
To: Simon Ser <simon.ser@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang
Date: Wed, 24 Apr 2019 16:26:55 +0300 [thread overview]
Message-ID: <20190424132655.GY22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190424092842.GV22949@platvala-desk.ger.corp.intel.com>
On Wed, Apr 24, 2019 at 12:28:42PM +0300, Petri Latvala wrote:
> On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> > The source file contains a special code-path for Clang, however this path fails
> > to compile:
> >
> > ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
> > float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
> > ^
> > ../lib/igt_halffloat.h:26:6: note: previous declaration is here
> > void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
> > ^
> > 1 error generated.
> >
> > This commit fixes this mismatch.
> >
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
>
> Same clang path is also used for !x86_64, as shown in the gitlab CI
> build failure.
>
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
And merged now, thanks.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-24 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 7:01 [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang Simon Ser
2019-04-24 8:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-24 9:28 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-04-24 13:26 ` Petri Latvala [this message]
2019-04-24 20:06 ` Daniel Vetter
2019-04-25 7:36 ` Daniel Vetter
2019-04-25 11:28 ` Ser, Simon
2019-04-24 13:18 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424132655.GY22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.