From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECFFC10F11 for ; Wed, 24 Apr 2019 20:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF6492183E for ; Wed, 24 Apr 2019 20:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sCfnlGIO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731373AbfDXUpe (ORCPT ); Wed, 24 Apr 2019 16:45:34 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:41723 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726823AbfDXUpe (ORCPT ); Wed, 24 Apr 2019 16:45:34 -0400 Received: by mail-qk1-f193.google.com with SMTP id l199so2055514qke.8 for ; Wed, 24 Apr 2019 13:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=EC+PbIeOOCvtsuCyOqFvom+enFDmG7sWnT3l6kW3CVQ=; b=sCfnlGIOkLjJMP/wZjBpkkxYG8gGIhnEgS7EaELHAQG++SVwWNzIhPgsk2nQGO1SYf HXSRWmHYLfEBpMHcDUwLebthttq8OemQXsEC8x/zgTK0WANxhKktgXsJ/xkRa7iPCA+2 7eNRPF4Wj+obRBlKW3zpRteHONzM+yfzc+LyUr8w04Kv5FOiyJrB8jTLT2h/mFEJ1FuR 6lIPIwaW1f2cpis3k9VPEUUIqNQ8rPeN2FXMHawRj46m9nDCj1agY75JG6tkYSjnjLPx 68pZ/r7Fqtr4c9Qd7YVdPpZQb3lFbiYkiYEgKBps2+nEmSSBYFLccbL01Ho0JvQjOTpR KQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=EC+PbIeOOCvtsuCyOqFvom+enFDmG7sWnT3l6kW3CVQ=; b=YYXf0yevH1gj2zk2Uz+yClGhMwNWtBZpRQpsbYpXdayhMfJXeafafHCMrxZdmu34qq vp7DLEJfjPfYUiz4pdj79qL+peXO+DBFeanPIhWym4byD023gzo+CG/vX3+h1ZsUZYdj WAOKu5YTK0+C39TAhbWFQCdXKX3gVzVkrf0wlv+DDNKalmmNOy9b92jrNoyeEDDbhRsC 3TqgD1kb+J8szn6iCVJ+EpMlh70FFqxkFwXjv19n9jT3d6ce+1kpIurTckxAIx69rOWI GMKYwxXrK9JyadpYKbYY8x5qg4M5BIOJBtod6XnuVah2h82cwKj0b0GZej0g0r0OlWBA hdpA== X-Gm-Message-State: APjAAAV6XU8Y5TlTqVjA8y11yu6TWaO+KHUw/lC/0tfqjCTrYfsy7UHi Jk1+b6dP0ECSHzFvoHacjFI= X-Google-Smtp-Source: APXvYqz4LkjaFhcP6c9ki3L91AMPtqnSP6VXVWPEv2rzGdpsdvtZ8yYwVQnLgxZb2E1h5QkVUyQvCA== X-Received: by 2002:a37:6315:: with SMTP id x21mr19414436qkb.265.1556138733308; Wed, 24 Apr 2019 13:45:33 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id l12sm791847qtj.37.2019.04.24.13.45.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 13:45:32 -0700 (PDT) Date: Wed, 24 Apr 2019 16:45:31 -0400 Message-ID: <20190424164531.GB402@t480s.localdomain> From: Vivien Didelot To: Andrew Lunn Cc: David Miller , netdev , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH v2 net-next 00/14] Make DSA tag drivers kernel modules In-Reply-To: <20190423002257.3220-1-andrew@lunn.ch> References: <20190423002257.3220-1-andrew@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Andrew, On Tue, 23 Apr 2019 02:22:43 +0200, Andrew Lunn wrote: > istorically, DSA tag drivers have been compiled into the kernel as > part of the DSA core. With the growing number of tag drivers, it makes > sense to allow this driver code to be compiled as a module, and loaded > on demand. > > v2 > -- > Move name to end of structure, keeping the hot entries at the beginning. > More tag protocol to end of structure to keep hot members at the beginning. > Fix indent of #endif > Rewrite to move list pointer into a new structure > void functions, since there cannot be errors > Fix fall-through comment > Reorder patch for unused symbols to before tag drivers can be modules > tab/space cleanup > Help text wording > NET_DSA_TAG_BRCM_COMMON and NET_DSA_TAG_KZS_COMMON hidden > > > Andrew Lunn (14): > dsa: Add SPDX header to tag drivers. > dsa: Move tagger name into its ops structure > dsa: Add MODULE_ALIAS to taggers in preparation to become modules > dsa: Add MODULE_LICENSE to tag drivers > dsa: Add TAG protocol to tag ops > dsa: Add boilerplate helper to register DSA tag driver modules > dsa: Keep link list of tag drivers > dsa: Register the none tagger ops > dsa: Rename dsa_resolve_tag_protocol() to _get ready for locking > dsa: Add stub tag driver put method > dsa: Make use of the list of tag drivers > dsa: Cleanup unneeded table and make tag structures static > dsa: tag_brcm: Avoid unused symbols > dsa: Allow tag drivers to be built as modules > > include/net/dsa.h | 110 ++++++++++++++++++++++++---- > net/dsa/Kconfig | 83 ++++++++++++++++----- > net/dsa/Makefile | 19 +++-- > net/dsa/dsa.c | 165 ++++++++++++++++++++++-------------------- > net/dsa/dsa2.c | 4 +- > net/dsa/dsa_priv.h | 34 +-------- > net/dsa/legacy.c | 4 +- > net/dsa/tag_brcm.c | 41 ++++++++--- > net/dsa/tag_dsa.c | 15 ++-- > net/dsa/tag_edsa.c | 15 ++-- > net/dsa/tag_gswip.c | 9 ++- > net/dsa/tag_ksz.c | 29 ++++++-- > net/dsa/tag_lan9303.c | 20 +++-- > net/dsa/tag_mtk.c | 18 ++--- > net/dsa/tag_qca.c | 19 +++-- > net/dsa/tag_trailer.c | 15 ++-- > 16 files changed, 380 insertions(+), 220 deletions(-) Nice cleanup at the same time. Tested-by: Vivien Didelot