From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJMPa-0008II-Tu for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJMPZ-0004oL-PC for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:14:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJMPZ-0004nP-HJ for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:14:25 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A485B3088D94 for ; Wed, 24 Apr 2019 18:14:24 +0000 (UTC) Date: Wed, 24 Apr 2019 15:14:20 -0300 From: Eduardo Habkost Message-ID: <20190424181420.GG18406@habkost.net> References: <20190423212246.3542-1-ehabkost@redhat.com> <2b1d825f-8bd3-ba25-3e1b-8415aeec8ce6@redhat.com> <20190424083113.GE28615@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190424083113.GE28615@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Thomas Huth , qemu-devel@nongnu.org, mprivozn@redhat.com, Markus Armbruster , Gerd Hoffmann On Wed, Apr 24, 2019 at 09:31:13AM +0100, Daniel P. Berrang=E9 wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > > On 23/04/2019 23.22, Eduardo Habkost wrote: > > > This series adds machine type deprecation information to the > > > output of the `query-machines` QMP command. With this, libvirt > > > and management software will be able to show this information to > > > users and/or suggest changes to VM configuration to avoid > > > deprecated machine types. > > >=20 > > > Eduardo Habkost (3): > > > qapi: SupportStatusInfo struct > > > machine: Use SupportStatusInfo for deprecation info > > > qmp: Add deprecation information to query-machines > > >=20 > > > qapi/common.json | 24 ++++++++++++++++++++++++ > > > qapi/misc.json | 5 ++++- > > > include/hw/boards.h | 7 ++++--- > > > hw/i386/pc_piix.c | 4 +++- > > > hw/ppc/prep.c | 4 +++- > > > vl.c | 19 +++++++++++++++---- > > > tests/acceptance/query_machines.py | 27 ++++++++++++++++++++++++++= + > > > 7 files changed, 80 insertions(+), 10 deletions(-) > > > create mode 100644 tests/acceptance/query_machines.py > >=20 > > Good idea, but some questions come to my mind: > >=20 > > - What about devices? IIRC Gerd wrote a patch series last year that d= oes > > something similar for devices... It would be good to synchronize th= e > > work, so that we do not have two completely interfaces between devi= ces > > and machines here in the end... >=20 > Might as well add CPU models to that too as there's plenty of awful > CPUs no one should use with KVM. The tricky thing is they are fine > / sensible with TCG still. Right. We also have devices that are supported in some machines but not in others. We will probably need a separate API that takes a (device type, machine type, accelerator) tuple as input. --=20 Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB24C10F11 for ; Wed, 24 Apr 2019 18:15:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C061D20685 for ; Wed, 24 Apr 2019 18:15:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C061D20685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:45397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJMQa-0000P4-16 for qemu-devel@archiver.kernel.org; Wed, 24 Apr 2019 14:15:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJMPa-0008II-Tu for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJMPZ-0004oL-PC for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:14:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJMPZ-0004nP-HJ for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:14:25 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A485B3088D94 for ; Wed, 24 Apr 2019 18:14:24 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3773272CD; Wed, 24 Apr 2019 18:14:21 +0000 (UTC) Date: Wed, 24 Apr 2019 15:14:20 -0300 From: Eduardo Habkost To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Message-ID: <20190424181420.GG18406@habkost.net> References: <20190423212246.3542-1-ehabkost@redhat.com> <2b1d825f-8bd3-ba25-3e1b-8415aeec8ce6@redhat.com> <20190424083113.GE28615@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190424083113.GE28615@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 24 Apr 2019 18:14:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, Thomas Huth , Gerd Hoffmann , qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190424181420.60DuRVzroYrn4BnHb8w9Le0p3pzqYGejJDVkvRmbKbs@z> On Wed, Apr 24, 2019 at 09:31:13AM +0100, Daniel P. Berrang=E9 wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > > On 23/04/2019 23.22, Eduardo Habkost wrote: > > > This series adds machine type deprecation information to the > > > output of the `query-machines` QMP command. With this, libvirt > > > and management software will be able to show this information to > > > users and/or suggest changes to VM configuration to avoid > > > deprecated machine types. > > >=20 > > > Eduardo Habkost (3): > > > qapi: SupportStatusInfo struct > > > machine: Use SupportStatusInfo for deprecation info > > > qmp: Add deprecation information to query-machines > > >=20 > > > qapi/common.json | 24 ++++++++++++++++++++++++ > > > qapi/misc.json | 5 ++++- > > > include/hw/boards.h | 7 ++++--- > > > hw/i386/pc_piix.c | 4 +++- > > > hw/ppc/prep.c | 4 +++- > > > vl.c | 19 +++++++++++++++---- > > > tests/acceptance/query_machines.py | 27 ++++++++++++++++++++++++++= + > > > 7 files changed, 80 insertions(+), 10 deletions(-) > > > create mode 100644 tests/acceptance/query_machines.py > >=20 > > Good idea, but some questions come to my mind: > >=20 > > - What about devices? IIRC Gerd wrote a patch series last year that d= oes > > something similar for devices... It would be good to synchronize th= e > > work, so that we do not have two completely interfaces between devi= ces > > and machines here in the end... >=20 > Might as well add CPU models to that too as there's plenty of awful > CPUs no one should use with KVM. The tricky thing is they are fine > / sensible with TCG still. Right. We also have devices that are supported in some machines but not in others. We will probably need a separate API that takes a (device type, machine type, accelerator) tuple as input. --=20 Eduardo