From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA94C10F11 for ; Wed, 24 Apr 2019 18:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33F5E21773 for ; Wed, 24 Apr 2019 18:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387952AbfDXSfH (ORCPT ); Wed, 24 Apr 2019 14:35:07 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57894 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727567AbfDXSfG (ORCPT ); Wed, 24 Apr 2019 14:35:06 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3OISqSg073138 for ; Wed, 24 Apr 2019 14:35:05 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s2v4waue1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 24 Apr 2019 14:35:05 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Apr 2019 19:35:04 +0100 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 24 Apr 2019 19:35:02 +0100 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3OIZ1v112124338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 18:35:01 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E11B6B2066; Wed, 24 Apr 2019 18:35:00 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3B7AB206A; Wed, 24 Apr 2019 18:35:00 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.80.231.45]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 24 Apr 2019 18:35:00 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id ABA9D16C5ED1; Wed, 24 Apr 2019 11:34:59 -0700 (PDT) Date: Wed, 24 Apr 2019 11:34:59 -0700 From: "Paul E. McKenney" To: Ingo Molnar Cc: Oleg Nesterov , Peter Zijlstra , Tejun Heo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] locking/percpu-rwsem: Add DEFINE_PERCPU_RWSEM(), use it to initialize cgroup_threadgroup_rwsem Reply-To: paulmck@linux.ibm.com References: <20190423163241.GA15866@redhat.com> <20190424103155.GA9642@gmail.com> <20190424110031.GA16167@redhat.com> <20190424110256.GA86120@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424110256.GA86120@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 19042418-2213-0000-0000-0000037F4210 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010988; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000285; SDB=6.01193813; UDB=6.00625852; IPR=6.00974636; MB=3.00026579; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-24 18:35:04 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19042418-2214-0000-0000-00005E277468 Message-Id: <20190424183459.GO3923@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-24_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=915 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904240133 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 24, 2019 at 01:02:56PM +0200, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > On 04/24, Ingo Molnar wrote: > > > > > > > -#define DEFINE_STATIC_PERCPU_RWSEM(name) \ > > > > +#define __DEFINE_PERCPU_RWSEM(name, is_static) \ > > > > static DEFINE_PER_CPU(unsigned int, __percpu_rwsem_rc_##name); \ > > > > -static struct percpu_rw_semaphore name = { \ > > > > +is_static struct percpu_rw_semaphore name = { \ > > > > .rss = __RCU_SYNC_INITIALIZER(name.rss), \ > > > > .read_count = &__percpu_rwsem_rc_##name, \ > > > > .rw_sem = __RWSEM_INITIALIZER(name.rw_sem), \ > > > > .writer = __RCUWAIT_INITIALIZER(name.writer), \ > > > > } > > > > +#define DEFINE_PERCPU_RWSEM(name) \ > > > > + __DEFINE_PERCPU_RWSEM(name, /* not static */) > > > > +#define DEFINE_STATIC_PERCPU_RWSEM(name) \ > > > > + __DEFINE_PERCPU_RWSEM(name, static) > > > > > > Which tree is this against? It doesn't apply to tip:master nor latest > > > > OOPS, sorry Ingo! > > > > I forgot that the change above depends on another cleanup I sent to Paul, > > > > [PATCH] rcu/sync: kill rcu_sync_type/gp_type > > https://lore.kernel.org/lkml/20190423120724.GA6132@redhat.com/ > > > > which does > > > > - .rss = __RCU_SYNC_INITIALIZER(name.rss, RCU_SCHED_SYNC), \ > > + .rss = __RCU_SYNC_INITIALIZER(name.rss), \ > > > > so lets forget it for now, or may be Paul can take this patch too. > > No problem, and both rwsem patches you sent seem fine to me: > > Reviewed-by: Ingo Molnar I queued patches with Ingo's reviewed-by. Thank you both! Thanx, Paul