From: kbuild test robot <lkp@intel.com>
To: Jiong Wang <jiong.wang@netronome.com>
Cc: kbuild-all@01.org, alexei.starovoitov@gmail.com,
daniel@iogearbox.net, bpf@vger.kernel.org,
netdev@vger.kernel.org, oss-drivers@netronome.com,
Jiong Wang <jiong.wang@netronome.com>
Subject: Re: [PATCH v4 bpf-next 15/15] nfp: bpf: eliminate zero extension code-gen
Date: Thu, 25 Apr 2019 00:31:01 +0800 [thread overview]
Message-ID: <201904250050.Z0Q6veLQ%lkp@intel.com> (raw)
In-Reply-To: <1555349185-12508-16-git-send-email-jiong.wang@netronome.com>
Hi Jiong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jiong-Wang/bpf-eliminate-zero-extensions-for-sub-register-writes/20190416-191711
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/netronome/nfp/bpf/jit.c:2654:34: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned char [usertype] dst @@ got resunsigned char [usertype] dst @@
>> drivers/net/ethernet/netronome/nfp/bpf/jit.c:2654:34: sparse: expected unsigned char [usertype] dst
>> drivers/net/ethernet/netronome/nfp/bpf/jit.c:2654:34: sparse: got restricted swreg [usertype] dst
drivers/net/ethernet/netronome/nfp/bpf/jit.c:2680:34: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned char [usertype] dst @@ got resunsigned char [usertype] dst @@
drivers/net/ethernet/netronome/nfp/bpf/jit.c:2680:34: sparse: expected unsigned char [usertype] dst
drivers/net/ethernet/netronome/nfp/bpf/jit.c:2680:34: sparse: got restricted swreg [usertype] dst
vim +2654 drivers/net/ethernet/netronome/nfp/bpf/jit.c
2627
2628 static int mem_ldx_skb(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta,
2629 u8 size)
2630 {
2631 swreg dst = reg_both(meta->insn.dst_reg * 2);
2632
2633 switch (meta->insn.off) {
2634 case offsetof(struct __sk_buff, len):
2635 if (size != FIELD_SIZEOF(struct __sk_buff, len))
2636 return -EOPNOTSUPP;
2637 wrp_mov(nfp_prog, dst, plen_reg(nfp_prog));
2638 break;
2639 case offsetof(struct __sk_buff, data):
2640 if (size != FIELD_SIZEOF(struct __sk_buff, data))
2641 return -EOPNOTSUPP;
2642 wrp_mov(nfp_prog, dst, pptr_reg(nfp_prog));
2643 break;
2644 case offsetof(struct __sk_buff, data_end):
2645 if (size != FIELD_SIZEOF(struct __sk_buff, data_end))
2646 return -EOPNOTSUPP;
2647 emit_alu(nfp_prog, dst,
2648 plen_reg(nfp_prog), ALU_OP_ADD, pptr_reg(nfp_prog));
2649 break;
2650 default:
2651 return -EOPNOTSUPP;
2652 }
2653
> 2654 wrp_zext(nfp_prog, meta, dst);
2655
2656 return 0;
2657 }
2658
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2019-04-24 16:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 17:26 [PATCH v4 bpf-next 00/15] bpf: eliminate zero extensions for sub-register writes Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 01/15] bpf: split read liveness into REG_LIVE_READ64 and REG_LIVE_READ32 Jiong Wang
2019-04-15 23:03 ` Jakub Kicinski
2019-04-16 1:26 ` Alexei Starovoitov
2019-04-16 7:39 ` Jiong Wang
2019-04-16 16:20 ` Alexei Starovoitov
2019-04-16 20:19 ` Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 02/15] bpf: mark lo32 writes that should be zero extended into hi32 Jiong Wang
2019-04-18 23:57 ` Alexei Starovoitov
2019-04-19 20:40 ` Jakub Kicinski
2019-04-19 21:14 ` Alexei Starovoitov
2019-04-19 21:33 ` Jakub Kicinski
2019-04-19 21:41 ` Alexei Starovoitov
2019-04-19 23:27 ` Jiong Wang
2019-04-19 23:28 ` Alexei Starovoitov
2019-04-15 17:26 ` [PATCH v4 bpf-next 03/15] bpf: reduce false alarm by refining helper call arg types Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 04/15] bpf: insert explicit zero extension insn when hardware doesn't do it implicitly Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 05/15] bpf: introduce new bpf prog load flags "BPF_F_TEST_RND_HI32" Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 06/15] bpf: randomize high 32-bit when BPF_F_TEST_RND_HI32 is set Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 07/15] libbpf: add "prog_flags" to bpf_program/bpf_prog_load_attr/bpf_load_program_attr Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 08/15] selftests: enable hi32 randomization for all tests Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 09/15] arm: bpf: eliminate zero extension code-gen Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 10/15] powerpc: " Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 11/15] s390: " Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 12/15] sparc: " Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 13/15] x32: " Jiong Wang
2019-04-15 17:26 ` [PATCH v4 bpf-next 14/15] riscv: " Jiong Wang
2019-04-17 7:55 ` Björn Töpel
2019-04-15 17:26 ` [PATCH v4 bpf-next 15/15] nfp: " Jiong Wang
2019-04-24 16:31 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904250050.Z0Q6veLQ%lkp@intel.com \
--to=lkp@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiong.wang@netronome.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.