From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AABC282E1 for ; Thu, 25 Apr 2019 10:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBFE8214AE for ; Thu, 25 Apr 2019 10:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556186984; bh=LFYOnrzOnqHgCaRL1dV3rewYVMdVsYB0QjuTPuTNuS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TN4LjRpHKaxvAJYx20azDoGG6ri68XoqGe6ieZS1yImh0vY9Jjg78zqSWk4eZD9Cj lMsL92d/ixxI+ZnjVXMqxpcW4PGZuxGEmY3f92fBmfKoA44jL+PO0pZzWHB4ClIbLO uNrNTrjH9b70nSGdLlUFw2AP6WxsM+DkPC+aGjn8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbfDYKJk (ORCPT ); Thu, 25 Apr 2019 06:09:40 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:39793 "EHLO mail-wm1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbfDYKJj (ORCPT ); Thu, 25 Apr 2019 06:09:39 -0400 Received: by mail-wm1-f53.google.com with SMTP id n25so9694421wmk.4; Thu, 25 Apr 2019 03:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qDXe8aInWx7rrUFbUzdCjPGqVvpdtP3z9EWwVfzbZc0=; b=kAxXHkZYy9zXKuU1mD/GV24mrHOTRf2dSE1dytqyDTE9UDI6Qs03UeV4nB5Yquf+nl 1tep2U7T3Sryt2ngffH0HbGnWoldhLQYMgCmjjSkzwRogMPhe3prjnuLu6GRBIQdgUmP FO9A7NNqPP+fSPIriO0PBVmQlihNr+lRUE9kN3TizxGphIMjD0dAZh3pX8+TVTBIlEGM NvtAJ9V68fpOVi2Lsx5HMiib5OaOfiymoKlY6eqWti6BEHTZMF6SWGNJ9IBt5/IKPWow QfTd69DVj5A06mVnuB2nERuOjY3Jq4M3TbOja1rBzuWUVL+Z+FGC8ZLEkNP4i5JfSmzV aAvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=qDXe8aInWx7rrUFbUzdCjPGqVvpdtP3z9EWwVfzbZc0=; b=intRd2J8Rd0dT9xsoF/UrTxTB+DwQvwijrTcwdCOnUy3+pxgVtf6u2pkngq7j/5EP1 VQvqpAZHXOlO8cyU6wsxniLgvqNcnIljtYreVLRMPkS9gGlAllJHMx3KDlwnIuebevbL zpKbbzeMHqTJsNlhHPCl95sEUtcUA9iFODFT2S1Cdrdv9HmiEAoBlvCJZU3nazjRqcaC NUwl7/I4isC3YVlPgvfdrJ1quJwiec5uqDVR6dv0sxnscolyhj4ejwwNxAg25c9as23I GgObq6/XyWh6inrijEOmJc5EpgBnAMsf7pn56urzLWd3QnuZQwrRqHgGqbPHtdDhW46g b8PQ== X-Gm-Message-State: APjAAAUcCTJpOO4mfQ+4Vu3bUXTn3OUpCZNSq9InHolFd/wnJx3IfESk U0PiY3GbouFBdTxmHzoDOMY= X-Google-Smtp-Source: APXvYqx2GAh1uv+m48koOKK3YSqfB/7bnkVhISaxrxFGwOyRBo5NQ9XpO4CFxCAJqjHa83cweimVmQ== X-Received: by 2002:a1c:6c04:: with SMTP id h4mr2890302wmc.135.1556186977884; Thu, 25 Apr 2019 03:09:37 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id c2sm19739225wrr.13.2019.04.25.03.09.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 03:09:37 -0700 (PDT) Date: Thu, 25 Apr 2019 12:09:33 +0200 From: Ingo Molnar To: Thomas Gleixner Cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , Christoph Hellwig , iommu@lists.linux-foundation.org, Robin Murphy , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , Daniel Vetter , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Rodrigo Vivi , Tom Zanussi , Miroslav Benes , linux-arch@vger.kernel.org Subject: Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage Message-ID: <20190425100933.GB8387@gmail.com> References: <20190425094453.875139013@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190425094453.875139013@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org * Thomas Gleixner wrote: > - if (unlikely(!ret)) > + if (unlikely(!ret)) { > + if (!trace->nr_entries) { > + /* > + * If save_trace fails here, the printing might > + * trigger a WARN but because of the !nr_entries it > + * should not do bad things. > + */ > + save_trace(trace); > + } > return print_circular_bug(&this, target_entry, next, prev); > + } > else if (unlikely(ret < 0)) > return print_bfs_bug(ret); Just a minor style nit: the 'else' should probably on the same line as the '}' it belongs to, to make it really obvious that the 'if' has an 'else' branch? At that point the condition should probably also use balanced curly braces. Interdiff looks good otherwise. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage Date: Thu, 25 Apr 2019 12:09:33 +0200 Message-ID: <20190425100933.GB8387@gmail.com> References: <20190425094453.875139013@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190425094453.875139013@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , Christoph Hellwig , iommu@lists.linux-foundation.org, Robin Murphy List-Id: linux-arch.vger.kernel.org * Thomas Gleixner wrote: > - if (unlikely(!ret)) > + if (unlikely(!ret)) { > + if (!trace->nr_entries) { > + /* > + * If save_trace fails here, the printing might > + * trigger a WARN but because of the !nr_entries it > + * should not do bad things. > + */ > + save_trace(trace); > + } > return print_circular_bug(&this, target_entry, next, prev); > + } > else if (unlikely(ret < 0)) > return print_bfs_bug(ret); Just a minor style nit: the 'else' should probably on the same line as the '}' it belongs to, to make it really obvious that the 'if' has an 'else' branch? At that point the condition should probably also use balanced curly braces. Interdiff looks good otherwise. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82AE5C10F03 for ; Thu, 25 Apr 2019 10:10:06 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E294206BA for ; Thu, 25 Apr 2019 10:10:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kAxXHkZY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E294206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 131FE1C67; Thu, 25 Apr 2019 10:10:06 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9B6E51C2E for ; Thu, 25 Apr 2019 10:09:39 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 275D882B for ; Thu, 25 Apr 2019 10:09:39 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id h11so2902499wmb.5 for ; Thu, 25 Apr 2019 03:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qDXe8aInWx7rrUFbUzdCjPGqVvpdtP3z9EWwVfzbZc0=; b=kAxXHkZYy9zXKuU1mD/GV24mrHOTRf2dSE1dytqyDTE9UDI6Qs03UeV4nB5Yquf+nl 1tep2U7T3Sryt2ngffH0HbGnWoldhLQYMgCmjjSkzwRogMPhe3prjnuLu6GRBIQdgUmP FO9A7NNqPP+fSPIriO0PBVmQlihNr+lRUE9kN3TizxGphIMjD0dAZh3pX8+TVTBIlEGM NvtAJ9V68fpOVi2Lsx5HMiib5OaOfiymoKlY6eqWti6BEHTZMF6SWGNJ9IBt5/IKPWow QfTd69DVj5A06mVnuB2nERuOjY3Jq4M3TbOja1rBzuWUVL+Z+FGC8ZLEkNP4i5JfSmzV aAvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=qDXe8aInWx7rrUFbUzdCjPGqVvpdtP3z9EWwVfzbZc0=; b=VOd1hijZHDznRI64sPR4YwFBuABYeGELqKfzNqLUj1Xv764lVuWuLUFCPcOpbVTHH9 NltsxcaMGXg5fe1YMkqn6Pn8UzANEavajp2wnDEX1eol6XzCTgbsaGqVtHH7k0zOJDLo CrwkED2ZAzcrINty73b2mqhx4dEtT48f/u8j9tAib/Ke9Pza6RnlsbVMl5/JiWoLa+N4 v/DWUhcrAIr2aIPbvjYkfQ3th2WfRSXv+ZQGb1Kl2xfzAt8jJXLP7lpq5xUGtH6ewOav yjHQ4XWinUqSqecL9mv0C4I9nrBNkhV91E/In7Vq/qfimnqVxw9yxlhrR1Fm+iIOIdR1 5YfA== X-Gm-Message-State: APjAAAUYogmM83eQGl254sjS7cFmCw0YadmZwHfEZi7V677ABqAI8+ct Ar1u7cnUhGbjNKqzy+CR1Rg= X-Google-Smtp-Source: APXvYqx2GAh1uv+m48koOKK3YSqfB/7bnkVhISaxrxFGwOyRBo5NQ9XpO4CFxCAJqjHa83cweimVmQ== X-Received: by 2002:a1c:6c04:: with SMTP id h4mr2890302wmc.135.1556186977884; Thu, 25 Apr 2019 03:09:37 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id c2sm19739225wrr.13.2019.04.25.03.09.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 03:09:37 -0700 (PDT) Date: Thu, 25 Apr 2019 12:09:33 +0200 From: Ingo Molnar To: Thomas Gleixner Subject: Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage Message-ID: <20190425100933.GB8387@gmail.com> References: <20190425094453.875139013@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190425094453.875139013@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mike Snitzer , David Airlie , Catalin Marinas , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Miroslav Benes , Christoph Hellwig , Alasdair Kergon , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, David Rientjes , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, Johannes Thumshirn , Maarten Lankhorst , Akinobu Mita , Steven Rostedt , Josef Bacik , Rodrigo Vivi , Mike Rapoport , Jani Nikula , Andy Lutomirski , Josh Poimboeuf , David Sterba , Dmitry Vyukov , Tom Zanussi , Chris Mason , LKML , Pekka Enberg , iommu@lists.linux-foundation.org, Daniel Vetter , Andrew Morton , Robin Murphy , linux-btrfs@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190425100933.m8bVaiAepF0KIeLDommOIjvCeZEzfyUl-cI0mK082mw@z> * Thomas Gleixner wrote: > - if (unlikely(!ret)) > + if (unlikely(!ret)) { > + if (!trace->nr_entries) { > + /* > + * If save_trace fails here, the printing might > + * trigger a WARN but because of the !nr_entries it > + * should not do bad things. > + */ > + save_trace(trace); > + } > return print_circular_bug(&this, target_entry, next, prev); > + } > else if (unlikely(ret < 0)) > return print_bfs_bug(ret); Just a minor style nit: the 'else' should probably on the same line as the '}' it belongs to, to make it really obvious that the 'if' has an 'else' branch? At that point the condition should probably also use balanced curly braces. Interdiff looks good otherwise. Thanks, Ingo _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu