From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards Date: Thu, 25 Apr 2019 11:05:51 +0000 (UTC) Message-ID: <20190425110551.6B4006074F@smtp.codeaurora.org> References: <20190404040106.40519-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190404040106.40519-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Ganapathi Bhat , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, Xinming Hu , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Douglas Anderson , Amitkumar Karwar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nishant Sarmukadam , mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, ryandcase-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, "David S. Miller" List-Id: linux-rockchip.vger.kernel.org Douglas Anderson wrote: > The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent > adapter status variables") had a fairly straightforward bug in it. It > contained this bit of diff: > > - if (!adapter->is_suspended) { > + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) { > > As you can see the patch missed the "!" when converting to the atomic > bitops. This meant that the resume hasn't done anything at all since > that commit landed and suspend/resume for mwifiex SDIO cards has been > totally broken. > > After fixing this mwifiex suspend/resume appears to work again, at > least with the simple testing I've done. > > Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables") > Cc: > Signed-off-by: Douglas Anderson > Reviewed-by: Brian Norris Patch applied to wireless-drivers.git, thanks. b82d6c1f8f82 mwifiex: Make resume actually do something useful again on SDIO cards -- https://patchwork.kernel.org/patch/10884883/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches