From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E531DC43218 for ; Thu, 25 Apr 2019 18:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79966206BF for ; Thu, 25 Apr 2019 18:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730207AbfDYSEi (ORCPT ); Thu, 25 Apr 2019 14:04:38 -0400 Received: from mga05.intel.com ([192.55.52.43]:59440 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387483AbfDYSEi (ORCPT ); Thu, 25 Apr 2019 14:04:38 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 11:04:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="134372445" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga007.jf.intel.com with ESMTP; 25 Apr 2019 11:04:37 -0700 Date: Thu, 25 Apr 2019 11:07:20 -0700 From: Jacob Pan To: Jean-Philippe Brucker Cc: Auger Eric , "iommu@lists.linux-foundation.org" , LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Yi L , "Tian, Kevin" , Raj Ashok , Andriy Shevchenko , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v2 02/19] iommu: introduce device fault data Message-ID: <20190425110720.07d7d317@jacob-builder> In-Reply-To: References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-3-git-send-email-jacob.jun.pan@linux.intel.com> <220a581e-0ee8-70e2-796b-b434594e4825@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Apr 2019 15:33:17 +0100 Jean-Philippe Brucker wrote: > On 25/04/2019 14:21, Auger Eric wrote: > We could add a > >> IOMMU_FAULT_PAGE_REQUEST_PERM_VALID bit instead, but I still find > >> it weird to denote the validity of a bitfield using a separate bit. > >> > >> Given that three different series now rely on this, how about we > >> send the fault patches separately for v5.2? > > Sorry I meant v5.3 - after the merge window > > >> I pushed the recoverable fault > >> support applied on top of this, with the PERM_READ bit and cleaned > >> up kernel doc, to git://linux-arm.org/linux-jpb.git sva/api > > Sounds good to me. We need th READ perm. I will pick the fault reporting patches from this tree for my next rev. My plan is to add PRQ support for vSVA after the current series. > > my only concern is is it likely to be upstreamed without any actual > > user? In the positive, of course, I don't have any objection. > > Possibly, I don't think my I/O page fault stuff for SVA is likely to > get in v5.3, it depends on one or two more patch sets. But your > nested work and Jacob's one may be in good shape for next version? I > find it difficult to keep track of the same patches in three > different series. Same here, hard to track especially for minor tweaks. I am working towards the next version for vSVA page fault. Then I will look into converting VT-d native IO page fault to yours. Thanks, Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80427C43219 for ; Thu, 25 Apr 2019 18:05:18 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E483206BF for ; Thu, 25 Apr 2019 18:05:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E483206BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3567A2194; Thu, 25 Apr 2019 18:05:18 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C70E8218E for ; Thu, 25 Apr 2019 18:04:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2AA3E74A for ; Thu, 25 Apr 2019 18:04:38 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 11:04:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="134372445" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga007.jf.intel.com with ESMTP; 25 Apr 2019 11:04:37 -0700 Date: Thu, 25 Apr 2019 11:07:20 -0700 From: Jacob Pan To: Jean-Philippe Brucker Subject: Re: [PATCH v2 02/19] iommu: introduce device fault data Message-ID: <20190425110720.07d7d317@jacob-builder> In-Reply-To: References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-3-git-send-email-jacob.jun.pan@linux.intel.com> <220a581e-0ee8-70e2-796b-b434594e4825@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: Yi L , "Tian, Kevin" , Raj Ashok , "iommu@lists.linux-foundation.org" , LKML , Alex Williamson , Andriy Shevchenko , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190425180720.cLw__x_1_K7jKRg51lAzuDP5Ng_3I22t52wLuMT-IuQ@z> On Thu, 25 Apr 2019 15:33:17 +0100 Jean-Philippe Brucker wrote: > On 25/04/2019 14:21, Auger Eric wrote: > We could add a > >> IOMMU_FAULT_PAGE_REQUEST_PERM_VALID bit instead, but I still find > >> it weird to denote the validity of a bitfield using a separate bit. > >> > >> Given that three different series now rely on this, how about we > >> send the fault patches separately for v5.2? > > Sorry I meant v5.3 - after the merge window > > >> I pushed the recoverable fault > >> support applied on top of this, with the PERM_READ bit and cleaned > >> up kernel doc, to git://linux-arm.org/linux-jpb.git sva/api > > Sounds good to me. We need th READ perm. I will pick the fault reporting patches from this tree for my next rev. My plan is to add PRQ support for vSVA after the current series. > > my only concern is is it likely to be upstreamed without any actual > > user? In the positive, of course, I don't have any objection. > > Possibly, I don't think my I/O page fault stuff for SVA is likely to > get in v5.3, it depends on one or two more patch sets. But your > nested work and Jacob's one may be in good shape for next version? I > find it difficult to keep track of the same patches in three > different series. Same here, hard to track especially for minor tweaks. I am working towards the next version for vSVA page fault. Then I will look into converting VT-d native IO page fault to yours. Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu