From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A6AC4321A for ; Thu, 25 Apr 2019 20:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89383206A3 for ; Thu, 25 Apr 2019 20:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731118AbfDYUbn (ORCPT ); Thu, 25 Apr 2019 16:31:43 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39857 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730805AbfDYUbn (ORCPT ); Thu, 25 Apr 2019 16:31:43 -0400 X-Originating-IP: 90.66.53.80 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id A9448E000E; Thu, 25 Apr 2019 20:31:39 +0000 (UTC) Date: Thu, 25 Apr 2019 22:31:39 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Nicolas Ferre , Claudiu Beznea , Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver Message-ID: <20190425203139.GO14604@piout.net> References: <20190402125056.21509-1-alexandre.belloni@bootlin.com> <20190402125056.21509-8-alexandre.belloni@bootlin.com> <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/2019 12:38:55-0700, Stephen Boyd wrote: > Quoting Alexandre Belloni (2019-04-02 05:50:56) > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c > > new file mode 100644 > > index 000000000000..22bf51c55bdc > > --- /dev/null > > +++ b/drivers/clk/at91/sam9x60.c > > @@ -0,0 +1,307 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +#include > > +#include > > +#include > > + > > +#include > > + > > +#include "pmc.h" > > + > > +DEFINE_SPINLOCK(pmc_pll_lock); > > + > > +static const struct clk_master_characteristics mck_characteristics = { > > + .output = { .min = 140000000, .max = 200000000 }, > > + .divisors = { 1, 2, 4, 3 }, > > + .have_div3_pres = 1, > > +}; > > + > > +static const struct clk_master_layout sam9x60_master_layout = { > > + .mask = 0x373, > > + .pres_shift = 4, > > + .offset = 0x28, > > +}; > > + > > +static struct clk_range plla_outputs[] = { > > const? > Right, can you fix that up or should I send a new version? > > + { .min = 300000000, .max = 600000000 }, > > +}; > [...] > > + > > +} > > + > > +CLK_OF_DECLARE_DRIVER(sam9x60_pmc, "microchip,sam9x60-pmc", sam9x60_pmc_setup); > > -- > > Can't be platform device? > IIRC two clocks are used by the clocksource and having it as a platform device make the clocksource driver fail with -EPROBE_DEFER. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA83FC43218 for ; Thu, 25 Apr 2019 20:31:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB6CA206A3 for ; Thu, 25 Apr 2019 20:31:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RgSj41Ji" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB6CA206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gxMXaYICICDE8xWofUghGXIXvDAv+dtx1Gg4i2PoM+0=; b=RgSj41Ji5wx+DB FYTD/8JzON8hevTdiIyejvOXJRkKKXHP3t/BXAE4akODW+S3KpV26asVINGlmmcuvKrgp8iHGnSqA /XovlJIv9LnvAwwQpO0WoCWWILl0Rv5f+pr1+3it15iH+fUR25lMydbxBT6Z4MvZDffNvDJzAmbpe o5Pi25JQgDG8f4ogQrWuursFPSs2aG9JkKsL1BVcQs29FUcgxyrJSpokAxBFWVuHC0A0YNmgLq6j5 FOtMe5K+l20RX80Be+mGquZuwWUVaiOwrUKHIsqD3N93TsHwiQgRBiUU42lgSo9wL+UOcbyIp5Hnp 2MtlhtVfI0SqdR/h+KiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJl2D-000452-Nw; Thu, 25 Apr 2019 20:31:57 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJl29-00044E-ST for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2019 20:31:55 +0000 X-Originating-IP: 90.66.53.80 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id A9448E000E; Thu, 25 Apr 2019 20:31:39 +0000 (UTC) Date: Thu, 25 Apr 2019 22:31:39 +0200 From: Alexandre Belloni To: Stephen Boyd Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver Message-ID: <20190425203139.GO14604@piout.net> References: <20190402125056.21509-1-alexandre.belloni@bootlin.com> <20190402125056.21509-8-alexandre.belloni@bootlin.com> <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190425_133154_069916_D660E4E5 X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , linux-kernel@vger.kernel.org, Claudiu Beznea , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/04/2019 12:38:55-0700, Stephen Boyd wrote: > Quoting Alexandre Belloni (2019-04-02 05:50:56) > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c > > new file mode 100644 > > index 000000000000..22bf51c55bdc > > --- /dev/null > > +++ b/drivers/clk/at91/sam9x60.c > > @@ -0,0 +1,307 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +#include > > +#include > > +#include > > + > > +#include > > + > > +#include "pmc.h" > > + > > +DEFINE_SPINLOCK(pmc_pll_lock); > > + > > +static const struct clk_master_characteristics mck_characteristics = { > > + .output = { .min = 140000000, .max = 200000000 }, > > + .divisors = { 1, 2, 4, 3 }, > > + .have_div3_pres = 1, > > +}; > > + > > +static const struct clk_master_layout sam9x60_master_layout = { > > + .mask = 0x373, > > + .pres_shift = 4, > > + .offset = 0x28, > > +}; > > + > > +static struct clk_range plla_outputs[] = { > > const? > Right, can you fix that up or should I send a new version? > > + { .min = 300000000, .max = 600000000 }, > > +}; > [...] > > + > > +} > > + > > +CLK_OF_DECLARE_DRIVER(sam9x60_pmc, "microchip,sam9x60-pmc", sam9x60_pmc_setup); > > -- > > Can't be platform device? > IIRC two clocks are used by the clocksource and having it as a platform device make the clocksource driver fail with -EPROBE_DEFER. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel