From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEBFC4321A for ; Thu, 25 Apr 2019 21:10:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE741206A3 for ; Thu, 25 Apr 2019 21:10:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731088AbfDYVKN (ORCPT ); Thu, 25 Apr 2019 17:10:13 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:51329 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfDYVKN (ORCPT ); Thu, 25 Apr 2019 17:10:13 -0400 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E7FAE20000C; Thu, 25 Apr 2019 21:10:09 +0000 (UTC) Date: Thu, 25 Apr 2019 23:10:09 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Nicolas Ferre , Claudiu Beznea , Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver Message-ID: <20190425211009.GP14604@piout.net> References: <20190402125056.21509-1-alexandre.belloni@bootlin.com> <20190402125056.21509-8-alexandre.belloni@bootlin.com> <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> <20190425203139.GO14604@piout.net> <155622589096.15276.8583738150370510787@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155622589096.15276.8583738150370510787@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/2019 13:58:10-0700, Stephen Boyd wrote: > > IIRC two clocks are used by the clocksource and having it as a platform > > device make the clocksource driver fail with -EPROBE_DEFER. > > > > Ok. I'll add a comment in the driver. It needs to be > CLK_OF_DECLARE_DRIVER() because it's used somewhere else too? Or it can > be CLK_OF_DECLARE() instead? It is coming from that comment: https://lore.kernel.org/lkml/153573753043.93865.2420370848457480370@swboyd.mtv.corp.google.com/ Maybe I misinterpreted it. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFBF8C43219 for ; Thu, 25 Apr 2019 21:10:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3899206A3 for ; Thu, 25 Apr 2019 21:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZgrAU7F9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MB+e5xKd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3899206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rQt1HtsniMbbEMOZM9wgMFiu6a6yorqgB5MX+t0oceg=; b=ZgrAU7F9WNJ1RT ArMTF0Q8cJXPyMvciHdf0qOXtLIlBSsMSWFwSq1SASPU7GlyQ4BRX9JO9o37+Mhvt02/slrZYCw07 F/QrpzXywLGkwdLOfY2HIslX8jeXch+6fI5H2O0vVu4DZPhgxrBEU98BJdl5uKiRy7yKAZBU/nnYy cHw2mZc2DOjGb/Ar+YZAR1sojr8WFRyQd2vXw94qLpHLvSFZmkG70cF1ffcpqmxIflLQKHwUX+X0V SdB3LghtklcvkGGn6ZBjLQOEjICG5ud2xqeIlxFQVO6wDlN/w5epm5SDCGTniCKDXbF+FAk2ViZB1 Rr0UvfFQFGKQLYpwux4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJldr-0001HL-2R; Thu, 25 Apr 2019 21:10:51 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJldp-0001HE-9a for linux-arm-kernel@bombadil.infradead.org; Thu, 25 Apr 2019 21:10:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YXgLbKfL0O5zk+jDkEG3vkzJdpN6UFsEietyrnRXn2s=; b=MB+e5xKdk+XrCwROmmwyuES+p /FUPniymUS1vEQ0Ikdn+XxbFOdm8pLbVILPqisu1ygEqt6luHWH/NYv6Bt34LsbWzH6xTSbwO1MaQ quwHcJGZ7l8vbLUXsLzlUp/apbtTX8otxh7fXidOwzkGh6KvgZWxasjtoOIT9gUO7jbNsEmWVYiqr gMNdkf9wjRVzOGGDiedquEB/Tl8bVQJVyGPsictQ6EfDmcSXItrJc70y2EUnx0jKM4oVSccCZz2Yc cMzNZc+xofEpVWSi4Zqmo/mFTHbG0tZ+FwT7F8vEjpHg79713BB2QVvyCtHiv71sq2605QzWi+iyA VgMn0iHPw==; Received: from relay12.mail.gandi.net ([217.70.178.232]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJldl-0002bG-Fr for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2019 21:10:47 +0000 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E7FAE20000C; Thu, 25 Apr 2019 21:10:09 +0000 (UTC) Date: Thu, 25 Apr 2019 23:10:09 +0200 From: Alexandre Belloni To: Stephen Boyd Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver Message-ID: <20190425211009.GP14604@piout.net> References: <20190402125056.21509-1-alexandre.belloni@bootlin.com> <20190402125056.21509-8-alexandre.belloni@bootlin.com> <155622113579.15276.15900194435736283135@swboyd.mtv.corp.google.com> <20190425203139.GO14604@piout.net> <155622589096.15276.8583738150370510787@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <155622589096.15276.8583738150370510787@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190425_221045_546109_31AB1AD2 X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , linux-kernel@vger.kernel.org, Claudiu Beznea , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/04/2019 13:58:10-0700, Stephen Boyd wrote: > > IIRC two clocks are used by the clocksource and having it as a platform > > device make the clocksource driver fail with -EPROBE_DEFER. > > > > Ok. I'll add a comment in the driver. It needs to be > CLK_OF_DECLARE_DRIVER() because it's used somewhere else too? Or it can > be CLK_OF_DECLARE() instead? It is coming from that comment: https://lore.kernel.org/lkml/153573753043.93865.2420370848457480370@swboyd.mtv.corp.google.com/ Maybe I misinterpreted it. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel