Re: TC stats / hw offload question

From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@resnulli.us>,
	Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: TC stats / hw offload question
Date: Fri, 26 Apr 2019 00:33:46 +0200	[thread overview]
Message-ID: <20190425223346.zqfadtphmhuj7ohp@salvia> (raw)
In-Reply-To: <58c74d0f-b92e-31f9-9828-24fb04129534@solarflare.com>

On Thu, Apr 25, 2019 at 02:23:08PM +0100, Edward Cree wrote:
> On 24/04/2019 16:03, Edward Cree wrote:
> > static int efx_tc_flower_replace(struct efx_nic *efx,
> >                                  struct net_device *net_dev,
> >                                  struct tc_cls_flower_offload *tc)
> > {
> >     struct efx_tc_action_set *act;
> >
> >     /* parse the match */
> >
> >     tcf_exts_for_each_action(i, a, tc->exts) {
> >         if (a->ops && a->ops->stats_update) {
> >             /* act is the hw action we're building */
> >             act->count = allocate_a_counter();
>
> Also, this was actually taking a->tcfa_index, allowing multiple rules to
>  share a counter.  The action index doesn't seem to be available in the
>  new flow_offload API.

Could you show a bit more code to see how you use a->tcfa_index from
your efx_tc_flower_replace()?

Thanks.