All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hunt <david.hunt@intel.com>
To: dev@dpdk.org
Cc: david.hunt@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix string null termination
Date: Fri, 26 Apr 2019 12:24:22 +0100	[thread overview]
Message-ID: <20190426112422.15719-1-david.hunt@intel.com> (raw)
In-Reply-To: <20190426084337.3921-1-david.hunt@intel.com>

coverity complains about a null-termination after a read,
so we terminate after exiting the do-while loop. The position
is conditional on whether idx is within the buffer or at the
end of the buffer.

Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: stable@dpdk.org

Signed-off-by: David Hunt <david.hunt@intel.com>

---
v2:
   * Move null termination outside of do-while.
---
 examples/vm_power_manager/channel_monitor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 971e4f2bc..03fdcd15a 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -822,6 +822,8 @@ read_json_packet(struct channel_info *chan_info)
 				break;
 		} while (indent > 0);
 
+		json_data[idx + (idx < MAX_JSON_STRING_LEN - 1)] = '\0';
+
 		if (indent > 0)
 			/*
 			 * We've broken out of the read loop without getting
-- 
2.17.1


  parent reply	other threads:[~2019-04-26 11:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26  8:43 [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix string null termination David Hunt
2019-04-26 10:33 ` Burakov, Anatoly
2019-04-26 11:16   ` Hunt, David
2019-04-26 11:24 ` David Hunt [this message]
2019-04-26 11:56   ` [dpdk-dev] [PATCH v2] " Burakov, Anatoly
2019-04-26 12:31     ` Bruce Richardson
2019-04-26 12:47       ` Burakov, Anatoly
2019-04-26 14:04   ` [dpdk-dev] [PATCH v3] " David Hunt
2019-04-26 14:10     ` Burakov, Anatoly
2019-05-02 23:43       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190426112422.15719-1-david.hunt@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.