From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC8DC43219 for ; Fri, 26 Apr 2019 17:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E74E9212F5 for ; Fri, 26 Apr 2019 17:11:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfDZRLT (ORCPT ); Fri, 26 Apr 2019 13:11:19 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:39638 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbfDZRLR (ORCPT ); Fri, 26 Apr 2019 13:11:17 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hK4NX-0003xD-99; Fri, 26 Apr 2019 17:11:15 +0000 Date: Fri, 26 Apr 2019 18:11:15 +0100 From: Al Viro To: Linus Torvalds Cc: Jeff Layton , Ilya Dryomov , ceph-devel@vger.kernel.org, Linux List Kernel Mailing Subject: Re: [GIT PULL] Ceph fixes for 5.1-rc7 Message-ID: <20190426171115.GA2217@ZenIV.linux.org.uk> References: <20190425174739.27604-1-idryomov@gmail.com> <342ef35feb1110197108068d10e518742823a210.camel@kernel.org> <20190425200941.GW2217@ZenIV.linux.org.uk> <86674e79e9f24e81feda75bc3c0dd4215604ffa5.camel@kernel.org> <20190426170108.GZ2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 26, 2019 at 10:08:48AM -0700, Linus Torvalds wrote: > On Fri, Apr 26, 2019 at 10:01 AM Al Viro wrote: > > > > What I don't understand is why would anyone want to mess with > > name snapshots for dentry_path() lookalikes... > > Talking about dentry_path()... Shouldn't the ceph path walking code > also check the mount_lock sequence to make sure the path is actually > stable? > > Maybe it doesn't matter. They want it relative to fs root - after all, server doesn't know or care what's mounted where on client...