From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AE66C43218 for ; Sun, 28 Apr 2019 16:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63F8E206BB for ; Sun, 28 Apr 2019 16:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1E1ztWBv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbfD1Qxv (ORCPT ); Sun, 28 Apr 2019 12:53:51 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47381 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726220AbfD1Qxv (ORCPT ); Sun, 28 Apr 2019 12:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cRMd8mueGQjf3u9Ez32aIcf72f+Jx2olgX7/QRk0Jr8=; b=1E1ztWBvomZnvKFV+Oeb5y2OcO Bpc/PetqYR0pYDGHQitn0xdRSySMdTKgJk6OnpFmXMqNDmDniFTuUXyxNLxqJtypiWSNowTRvFzsF 79dvP93+AwqQgUhxDcfh6xM+JQcDfAApsJ3rNvb8/RciAFp7MzdZW0QXd3hQtNvDiMkg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hKn3O-0000uS-PY; Sun, 28 Apr 2019 18:53:26 +0200 Date: Sun, 28 Apr 2019 18:53:26 +0200 From: Andrew Lunn To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Rob Herring , Mark Rutland , Vivien Didelot , Florian Fainelli , Yisen Zhuang , Salil Mehta , Woojung Huh , Microchip Linux Driver Support , Kunihiko Hayashi , Masahiro Yamada , Jassi Brar , Kalle Valo , Matthias Brugger , Heiner Kallweit , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel , linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Message-ID: <20190428165326.GI23059@lunn.ch> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-3-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556456002-13430-3-git-send-email-ynezz@true.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Apr 28, 2019 at 02:53:20PM +0200, Petr Štetiar wrote: > As of_get_mac_address now supports NVMEM under the hood, we need to update > the bindings documentation with the new nvmem-cell* properties, which would > mean copy&pasting a lot of redundant information to every binding > documentation currently referencing some of the MAC address properties. > > So I've just removed all the references to the optional MAC address > properties and replaced them with the reference to the net/ethernet.txt > file. While at it, I've also removed other optional Ethernet properties. Hi Petr I think each individual binding needs to give a hint if of_get_mac_address() is used, and hence if these optional properties are respected. The same is true for other optional properties. I don't want to have to look at the driver to know which optional properties are implemented, the binding should tell me. What the optional properties mean, and which order they are used in can then be defined in ethernet.txt. So i would suggests something like: The MAC address will be determined using the optional properties defined in ethernet.txt. And leave all the other optional parameters in the bindings. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Date: Sun, 28 Apr 2019 18:53:26 +0200 Message-ID: <20190428165326.GI23059@lunn.ch> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-3-git-send-email-ynezz@true.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1556456002-13430-3-git-send-email-ynezz@true.cz> Sender: linux-kernel-owner@vger.kernel.org To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Rob Herring , Mark Rutland , Vivien Didelot , Florian Fainelli , Yisen Zhuang , Salil Mehta , Woojung Huh , Microchip Linux Driver Support , Kunihiko Hayashi , Masahiro Yamada , Jassi Brar , Kalle Valo , Matthias Brugger , Heiner Kallweit , Frank Rowand List-Id: devicetree@vger.kernel.org On Sun, Apr 28, 2019 at 02:53:20PM +0200, Petr Štetiar wrote: > As of_get_mac_address now supports NVMEM under the hood, we need to update > the bindings documentation with the new nvmem-cell* properties, which would > mean copy&pasting a lot of redundant information to every binding > documentation currently referencing some of the MAC address properties. > > So I've just removed all the references to the optional MAC address > properties and replaced them with the reference to the net/ethernet.txt > file. While at it, I've also removed other optional Ethernet properties. Hi Petr I think each individual binding needs to give a hint if of_get_mac_address() is used, and hence if these optional properties are respected. The same is true for other optional properties. I don't want to have to look at the driver to know which optional properties are implemented, the binding should tell me. What the optional properties mean, and which order they are used in can then be defined in ethernet.txt. So i would suggests something like: The MAC address will be determined using the optional properties defined in ethernet.txt. And leave all the other optional parameters in the bindings. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2697C43219 for ; Sun, 28 Apr 2019 16:53:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8177E20693 for ; Sun, 28 Apr 2019 16:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rAfgyp+A"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1E1ztWBv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8177E20693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g+jeShTG4SODPyLTbl1P8dA7xygcI1A5Nb4/XnduD5M=; b=rAfgyp+A8kROlx IgcM0SApTgmT5sue/KCHaau1lqWtUtszVO831ik9eM9Xt+GSOXRX/6xV56kDm1VJ0OuK4yAkfE3h8 RVNZQ1nJ28hxTGd4lZ4GE1lB3XxkCVVK2BKx/+tIOJ90nYRpvfLWpBFa8jPw1l4eHe9YE7miqF39K EMoOFKEylvxtshX8nJarSC4lmYzAuKpYb3jKLQJz0O+FwjXLQb4GvdxFUOGep3ut3leEh+MD70uLq Cg+aM+3jUfPdX/zW07J/hCWZ0GKsIeI/VUvvAl9iQn15wpUsm2qnaXC9T1w7xq9rYgMUFPnHk96kr 1urg/M8OdpsESmc+pSzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKn3q-0006Hr-Hq; Sun, 28 Apr 2019 16:53:54 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKn3m-0006HQ-GN; Sun, 28 Apr 2019 16:53:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cRMd8mueGQjf3u9Ez32aIcf72f+Jx2olgX7/QRk0Jr8=; b=1E1ztWBvomZnvKFV+Oeb5y2OcO Bpc/PetqYR0pYDGHQitn0xdRSySMdTKgJk6OnpFmXMqNDmDniFTuUXyxNLxqJtypiWSNowTRvFzsF 79dvP93+AwqQgUhxDcfh6xM+JQcDfAApsJ3rNvb8/RciAFp7MzdZW0QXd3hQtNvDiMkg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hKn3O-0000uS-PY; Sun, 28 Apr 2019 18:53:26 +0200 Date: Sun, 28 Apr 2019 18:53:26 +0200 From: Andrew Lunn To: Petr =?utf-8?Q?=C5=A0tetiar?= Subject: Re: [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Message-ID: <20190428165326.GI23059@lunn.ch> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-3-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1556456002-13430-3-git-send-email-ynezz@true.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190428_095350_698185_A96E81E0 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kunihiko Hayashi , Maxime Ripard , Masahiro Yamada , Srinivas Kandagatla , Frank Rowand , Florian Fainelli , linux-arm-kernel@lists.infradead.org, Yisen Zhuang , Vivien Didelot , Woojung Huh , devicetree@vger.kernel.org, Jassi Brar , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Kalle Valo , Salil Mehta , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Alban Bedel , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBBcHIgMjgsIDIwMTkgYXQgMDI6NTM6MjBQTSArMDIwMCwgUGV0ciDFoHRldGlhciB3 cm90ZToKPiBBcyBvZl9nZXRfbWFjX2FkZHJlc3Mgbm93IHN1cHBvcnRzIE5WTUVNIHVuZGVyIHRo ZSBob29kLCB3ZSBuZWVkIHRvIHVwZGF0ZQo+IHRoZSBiaW5kaW5ncyBkb2N1bWVudGF0aW9uIHdp dGggdGhlIG5ldyBudm1lbS1jZWxsKiBwcm9wZXJ0aWVzLCB3aGljaCB3b3VsZAo+IG1lYW4gY29w eSZwYXN0aW5nIGEgbG90IG9mIHJlZHVuZGFudCBpbmZvcm1hdGlvbiB0byBldmVyeSBiaW5kaW5n Cj4gZG9jdW1lbnRhdGlvbiBjdXJyZW50bHkgcmVmZXJlbmNpbmcgc29tZSBvZiB0aGUgTUFDIGFk ZHJlc3MgcHJvcGVydGllcy4KPiAKPiBTbyBJJ3ZlIGp1c3QgcmVtb3ZlZCBhbGwgdGhlIHJlZmVy ZW5jZXMgdG8gdGhlIG9wdGlvbmFsIE1BQyBhZGRyZXNzCj4gcHJvcGVydGllcyBhbmQgcmVwbGFj ZWQgdGhlbSB3aXRoIHRoZSByZWZlcmVuY2UgdG8gdGhlIG5ldC9ldGhlcm5ldC50eHQKPiBmaWxl LiAgV2hpbGUgYXQgaXQsIEkndmUgYWxzbyByZW1vdmVkIG90aGVyIG9wdGlvbmFsIEV0aGVybmV0 IHByb3BlcnRpZXMuCgpIaSBQZXRyCgpJIHRoaW5rIGVhY2ggaW5kaXZpZHVhbCBiaW5kaW5nIG5l ZWRzIHRvIGdpdmUgYSBoaW50IGlmCm9mX2dldF9tYWNfYWRkcmVzcygpIGlzIHVzZWQsIGFuZCBo ZW5jZSBpZiB0aGVzZSBvcHRpb25hbCBwcm9wZXJ0aWVzCmFyZSByZXNwZWN0ZWQuIFRoZSBzYW1l IGlzIHRydWUgZm9yIG90aGVyIG9wdGlvbmFsIHByb3BlcnRpZXMuIEkgZG9uJ3QKd2FudCB0byBo YXZlIHRvIGxvb2sgYXQgdGhlIGRyaXZlciB0byBrbm93IHdoaWNoIG9wdGlvbmFsIHByb3BlcnRp ZXMKYXJlIGltcGxlbWVudGVkLCB0aGUgYmluZGluZyBzaG91bGQgdGVsbCBtZS4gV2hhdCB0aGUg b3B0aW9uYWwKcHJvcGVydGllcyBtZWFuLCBhbmQgd2hpY2ggb3JkZXIgdGhleSBhcmUgdXNlZCBp biBjYW4gdGhlbiBiZSBkZWZpbmVkCmluIGV0aGVybmV0LnR4dC4KClNvIGkgd291bGQgc3VnZ2Vz dHMgc29tZXRoaW5nIGxpa2U6CgpUaGUgTUFDIGFkZHJlc3Mgd2lsbCBiZSBkZXRlcm1pbmVkIHVz aW5nIHRoZSBvcHRpb25hbCBwcm9wZXJ0aWVzCmRlZmluZWQgaW4gZXRoZXJuZXQudHh0LgoKQW5k IGxlYXZlIGFsbCB0aGUgb3RoZXIgb3B0aW9uYWwgcGFyYW1ldGVycyBpbiB0aGUgYmluZGluZ3Mu CgoJQW5kcmV3CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==