From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Date: Mon, 29 Apr 2019 05:04:10 +0000 Subject: Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant Message-Id: <20190429050410.GA7982@dhcp-128-65.nay.redhat.com> List-Id: References: <1556087581-14513-1-git-send-email-kernelfans@gmail.com> <10dc5468-6cd9-85c7-ba66-1dfa5aa922b7@suse.com> <20190428083710.GA11981@dhcp-128-65.nay.redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Pingfan Liu Cc: Rich Felker , linux-ia64@vger.kernel.org, Julien Thierry , Yangtao Li , Benjamin Herrenschmidt , Palmer Dabbelt , Heiko Carstens , Stefan Agner , linux-mips@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner , Logan Gunthorpe , linux-s390@vger.kernel.org, Florian Fainelli , Yoshinori Sato , linux-sh@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King , Ingo Molnar , Hari Bathini , Catalin Marinas , James Hogan , Fenghua Yu , Tony Luck , Will Deacon , Johannes Weiner , Ananth N Mavinakayanahalli , Borislav Petkov , David Hildenbrand , linux-arm-kernel@lists.infradead.org, Jens Axboe , Matthias Brugger , Baoquan He , Ard Biesheuvel , Robin Murphy , kexec@lists.infradead.org, LKML , Ralf Baechle , Thomas Bogendoerfer , Paul Burton , Greg Kroah-Hartman , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Greg Hackmann On 04/29/19 at 12:48pm, Pingfan Liu wrote: > On Mon, Apr 29, 2019 at 11:04 AM Pingfan Liu wrote: > > > > On Sun, Apr 28, 2019 at 4:37 PM Dave Young wrote: > > > > > > On 04/25/19 at 04:20pm, Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > > > > > > > [...] > > > > > > @@ -139,6 +141,8 @@ static int __init parse_crashkernel_simple(char *cmdline, > > > > > > pr_warn("crashkernel: unrecognized char: %c\n", *cur); > > > > > > return -EINVAL; > > > > > > } > > > > > > + if (*crash_size = 0) > > > > > > + return -EINVAL; > > > > > > > > > > This covers the case where I pass an argument like "crashkernel=0M" ? > > > > > Can't we fix that by using kstrtoull() in memparse and check if the return value > > > > > is < 0? In that case we could return without updating the retptr and we will be > > > > > fine. > > > > > > > > > It seems that kstrtoull() treats 0M as invalid parameter, while > > > > simple_strtoull() does not. > > > > > > > > If changed like your suggestion, then all the callers of memparse() > > > > will treats 0M as invalid parameter. This affects many components > > > > besides kexec. Not sure this can be done or not. > > > > > > simple_strtoull is obsolete, move to kstrtoull is the right way. > > > > > > $ git grep memparse|wc > > > 158 950 10479 > > > > > > Except some documentation/tools etc there are still a log of callers > > > which directly use the return value as the ull number without error > > > checking. > > > > > > So it would be good to mark memparse as obsolete as well in > > > lib/cmdline.c, and introduce a new function eg. kmemparse() to use > > > kstrtoull, and return a real error code, and save the size in an > > > argument like &size. Then update X86 crashkernel code to use it. > > > > > Thank for your good suggestion. > > > Go through the v5.0 kernel code, I think it will be a huge job. > > The difference between unsigned long long simple_strtoull(const char > *cp, char **endp, unsigned int base) and int _kstrtoull(const char *s, > unsigned int base, unsigned long long *res) is bigger than expected, > especially the output parameter @res. Many references to > memparse(const char *ptr, char **retptr) rely on @retptr to work. A > typical example from arch/x86/kernel/e820.c > mem_size = memparse(p, &p); > if (p = oldp) > return -EINVAL; > > userdef = 1; > if (*p = '@') { <----------- here > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RAM); > } else if (*p = '#') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_ACPI); > } else if (*p = '$') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RESERVED); > } > > So we need to resolve the prototype of kstrtoull() firstly, and maybe > kstrtouint() etc too. All of them have lots of references in kernel. > > Any idea about this? Not only this place, a lot of other places, I think no hurry to fix them all at one time. As we talked just do it according to previous reply, mark memparse as obsolete, and create a new function to use kstrtoull, and make it used in crashkernel code first. Thanks Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8CF2C43219 for ; Mon, 29 Apr 2019 05:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BB3F2087B for ; Mon, 29 Apr 2019 05:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbfD2FEh (ORCPT ); Mon, 29 Apr 2019 01:04:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbfD2FEg (ORCPT ); Mon, 29 Apr 2019 01:04:36 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77A4D81F0F; Mon, 29 Apr 2019 05:04:34 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-135.pek2.redhat.com [10.72.12.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A98F1001DF6; Mon, 29 Apr 2019 05:04:14 +0000 (UTC) Date: Mon, 29 Apr 2019 13:04:10 +0800 From: Dave Young To: Pingfan Liu Cc: Matthias Brugger , LKML , Rich Felker , linux-ia64@vger.kernel.org, Julien Thierry , Yangtao Li , Benjamin Herrenschmidt , Palmer Dabbelt , Heiko Carstens , x86@kernel.org, linux-mips@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , linux-s390@vger.kernel.org, Florian Fainelli , Yoshinori Sato , linux-sh@vger.kernel.org, Michael Ellerman , David Hildenbrand , Russell King , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Catalin Marinas , James Hogan , Fenghua Yu , Will Deacon , linuxppc-dev@lists.ozlabs.org, Ananth N Mavinakayanahalli , Borislav Petkov , Stefan Agner , Thomas Gleixner , Hari Bathini , Jens Axboe , Tony Luck , Baoquan He , Ard Biesheuvel , Robin Murphy , Greg Kroah-Hartman , Ralf Baechle , Thomas Bogendoerfer , Paul Burton , Johannes Weiner , Martin Schwidefsky , Andrew Morton , Logan Gunthorpe , Greg Hackmann , kexec@lists.infradead.org Subject: Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant Message-ID: <20190429050410.GA7982@dhcp-128-65.nay.redhat.com> References: <1556087581-14513-1-git-send-email-kernelfans@gmail.com> <10dc5468-6cd9-85c7-ba66-1dfa5aa922b7@suse.com> <20190428083710.GA11981@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 29 Apr 2019 05:04:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/29/19 at 12:48pm, Pingfan Liu wrote: > On Mon, Apr 29, 2019 at 11:04 AM Pingfan Liu wrote: > > > > On Sun, Apr 28, 2019 at 4:37 PM Dave Young wrote: > > > > > > On 04/25/19 at 04:20pm, Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > > > > > > > [...] > > > > > > @@ -139,6 +141,8 @@ static int __init parse_crashkernel_simple(char *cmdline, > > > > > > pr_warn("crashkernel: unrecognized char: %c\n", *cur); > > > > > > return -EINVAL; > > > > > > } > > > > > > + if (*crash_size == 0) > > > > > > + return -EINVAL; > > > > > > > > > > This covers the case where I pass an argument like "crashkernel=0M" ? > > > > > Can't we fix that by using kstrtoull() in memparse and check if the return value > > > > > is < 0? In that case we could return without updating the retptr and we will be > > > > > fine. > > > > > > > > > It seems that kstrtoull() treats 0M as invalid parameter, while > > > > simple_strtoull() does not. > > > > > > > > If changed like your suggestion, then all the callers of memparse() > > > > will treats 0M as invalid parameter. This affects many components > > > > besides kexec. Not sure this can be done or not. > > > > > > simple_strtoull is obsolete, move to kstrtoull is the right way. > > > > > > $ git grep memparse|wc > > > 158 950 10479 > > > > > > Except some documentation/tools etc there are still a log of callers > > > which directly use the return value as the ull number without error > > > checking. > > > > > > So it would be good to mark memparse as obsolete as well in > > > lib/cmdline.c, and introduce a new function eg. kmemparse() to use > > > kstrtoull, and return a real error code, and save the size in an > > > argument like &size. Then update X86 crashkernel code to use it. > > > > > Thank for your good suggestion. > > > Go through the v5.0 kernel code, I think it will be a huge job. > > The difference between unsigned long long simple_strtoull(const char > *cp, char **endp, unsigned int base) and int _kstrtoull(const char *s, > unsigned int base, unsigned long long *res) is bigger than expected, > especially the output parameter @res. Many references to > memparse(const char *ptr, char **retptr) rely on @retptr to work. A > typical example from arch/x86/kernel/e820.c > mem_size = memparse(p, &p); > if (p == oldp) > return -EINVAL; > > userdef = 1; > if (*p == '@') { <----------- here > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RAM); > } else if (*p == '#') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_ACPI); > } else if (*p == '$') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RESERVED); > } > > So we need to resolve the prototype of kstrtoull() firstly, and maybe > kstrtouint() etc too. All of them have lots of references in kernel. > > Any idea about this? Not only this place, a lot of other places, I think no hurry to fix them all at one time. As we talked just do it according to previous reply, mark memparse as obsolete, and create a new function to use kstrtoull, and make it used in crashkernel code first. Thanks Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 29 Apr 2019 13:04:10 +0800 From: Dave Young Subject: Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant Message-ID: <20190429050410.GA7982@dhcp-128-65.nay.redhat.com> References: <1556087581-14513-1-git-send-email-kernelfans@gmail.com> <10dc5468-6cd9-85c7-ba66-1dfa5aa922b7@suse.com> <20190428083710.GA11981@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org List-Archive: To: Pingfan Liu Cc: Rich Felker , linux-ia64@vger.kernel.org, Julien Thierry , Yangtao Li , Benjamin Herrenschmidt , Palmer Dabbelt , Heiko Carstens , Stefan Agner , linux-mips@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner , Logan Gunthorpe , linux-s390@vger.kernel.org, Florian Fainelli , Yoshinori Sato , linux-sh@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King , Ingo Molnar , Hari Bathini , Catalin Marinas , James Hogan , Fenghua Yu , Tony Luck , Will Deacon , Johannes Weiner , Ananth N Mavinakayanahalli , Borislav Petkov , David Hildenbrand , linux-arm-kernel@lists.infradead.org, Jens Axboe , Matthias Brugger , Baoquan He , Ard Biesheuvel , Robin Murphy , kexec@lists.infradead.org, LKML , Ralf Baechle , Thomas Bogendoerfer , Paul Burton , Greg Kroah-Hartman , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Greg Hackmann List-ID: On 04/29/19 at 12:48pm, Pingfan Liu wrote: > On Mon, Apr 29, 2019 at 11:04 AM Pingfan Liu wrote: > > > > On Sun, Apr 28, 2019 at 4:37 PM Dave Young wrote: > > > > > > On 04/25/19 at 04:20pm, Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > > > > > > > [...] > > > > > > @@ -139,6 +141,8 @@ static int __init parse_crashkernel_simple(char *cmdline, > > > > > > pr_warn("crashkernel: unrecognized char: %c\n", *cur); > > > > > > return -EINVAL; > > > > > > } > > > > > > + if (*crash_size == 0) > > > > > > + return -EINVAL; > > > > > > > > > > This covers the case where I pass an argument like "crashkernel=0M" ? > > > > > Can't we fix that by using kstrtoull() in memparse and check if the return value > > > > > is < 0? In that case we could return without updating the retptr and we will be > > > > > fine. > > > > > > > > > It seems that kstrtoull() treats 0M as invalid parameter, while > > > > simple_strtoull() does not. > > > > > > > > If changed like your suggestion, then all the callers of memparse() > > > > will treats 0M as invalid parameter. This affects many components > > > > besides kexec. Not sure this can be done or not. > > > > > > simple_strtoull is obsolete, move to kstrtoull is the right way. > > > > > > $ git grep memparse|wc > > > 158 950 10479 > > > > > > Except some documentation/tools etc there are still a log of callers > > > which directly use the return value as the ull number without error > > > checking. > > > > > > So it would be good to mark memparse as obsolete as well in > > > lib/cmdline.c, and introduce a new function eg. kmemparse() to use > > > kstrtoull, and return a real error code, and save the size in an > > > argument like &size. Then update X86 crashkernel code to use it. > > > > > Thank for your good suggestion. > > > Go through the v5.0 kernel code, I think it will be a huge job. > > The difference between unsigned long long simple_strtoull(const char > *cp, char **endp, unsigned int base) and int _kstrtoull(const char *s, > unsigned int base, unsigned long long *res) is bigger than expected, > especially the output parameter @res. Many references to > memparse(const char *ptr, char **retptr) rely on @retptr to work. A > typical example from arch/x86/kernel/e820.c > mem_size = memparse(p, &p); > if (p == oldp) > return -EINVAL; > > userdef = 1; > if (*p == '@') { <----------- here > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RAM); > } else if (*p == '#') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_ACPI); > } else if (*p == '$') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RESERVED); > } > > So we need to resolve the prototype of kstrtoull() firstly, and maybe > kstrtouint() etc too. All of them have lots of references in kernel. > > Any idea about this? Not only this place, a lot of other places, I think no hurry to fix them all at one time. As we talked just do it according to previous reply, mark memparse as obsolete, and create a new function to use kstrtoull, and make it used in crashkernel code first. Thanks Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0098DC43219 for ; Mon, 29 Apr 2019 05:06:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42A742087B for ; Mon, 29 Apr 2019 05:06:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42A742087B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44st0V01rYzDqQ4 for ; Mon, 29 Apr 2019 15:06:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=redhat.com (client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=dyoung@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44ssyv5bbzzDqNK for ; Mon, 29 Apr 2019 15:04:38 +1000 (AEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77A4D81F0F; Mon, 29 Apr 2019 05:04:34 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-135.pek2.redhat.com [10.72.12.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A98F1001DF6; Mon, 29 Apr 2019 05:04:14 +0000 (UTC) Date: Mon, 29 Apr 2019 13:04:10 +0800 From: Dave Young To: Pingfan Liu Subject: Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant Message-ID: <20190429050410.GA7982@dhcp-128-65.nay.redhat.com> References: <1556087581-14513-1-git-send-email-kernelfans@gmail.com> <10dc5468-6cd9-85c7-ba66-1dfa5aa922b7@suse.com> <20190428083710.GA11981@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 29 Apr 2019 05:04:35 +0000 (UTC) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, Julien Thierry , Yangtao Li , Palmer Dabbelt , Heiko Carstens , Stefan Agner , linux-mips@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner , Logan Gunthorpe , linux-s390@vger.kernel.org, Florian Fainelli , Yoshinori Sato , linux-sh@vger.kernel.org, x86@kernel.org, Russell King , Ingo Molnar , Hari Bathini , Catalin Marinas , James Hogan , Fenghua Yu , Tony Luck , Will Deacon , Johannes Weiner , Borislav Petkov , David Hildenbrand , linux-arm-kernel@lists.infradead.org, Jens Axboe , Matthias Brugger , Baoquan He , Ard Biesheuvel , Robin Murphy , kexec@lists.infradead.org, LKML , Ralf Baechle , Thomas Bogendoerfer , Paul Burton , Greg Kroah-Hartman , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Greg Hackmann Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 04/29/19 at 12:48pm, Pingfan Liu wrote: > On Mon, Apr 29, 2019 at 11:04 AM Pingfan Liu wrote: > > > > On Sun, Apr 28, 2019 at 4:37 PM Dave Young wrote: > > > > > > On 04/25/19 at 04:20pm, Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > > > > > > > [...] > > > > > > @@ -139,6 +141,8 @@ static int __init parse_crashkernel_simple(char *cmdline, > > > > > > pr_warn("crashkernel: unrecognized char: %c\n", *cur); > > > > > > return -EINVAL; > > > > > > } > > > > > > + if (*crash_size == 0) > > > > > > + return -EINVAL; > > > > > > > > > > This covers the case where I pass an argument like "crashkernel=0M" ? > > > > > Can't we fix that by using kstrtoull() in memparse and check if the return value > > > > > is < 0? In that case we could return without updating the retptr and we will be > > > > > fine. > > > > > > > > > It seems that kstrtoull() treats 0M as invalid parameter, while > > > > simple_strtoull() does not. > > > > > > > > If changed like your suggestion, then all the callers of memparse() > > > > will treats 0M as invalid parameter. This affects many components > > > > besides kexec. Not sure this can be done or not. > > > > > > simple_strtoull is obsolete, move to kstrtoull is the right way. > > > > > > $ git grep memparse|wc > > > 158 950 10479 > > > > > > Except some documentation/tools etc there are still a log of callers > > > which directly use the return value as the ull number without error > > > checking. > > > > > > So it would be good to mark memparse as obsolete as well in > > > lib/cmdline.c, and introduce a new function eg. kmemparse() to use > > > kstrtoull, and return a real error code, and save the size in an > > > argument like &size. Then update X86 crashkernel code to use it. > > > > > Thank for your good suggestion. > > > Go through the v5.0 kernel code, I think it will be a huge job. > > The difference between unsigned long long simple_strtoull(const char > *cp, char **endp, unsigned int base) and int _kstrtoull(const char *s, > unsigned int base, unsigned long long *res) is bigger than expected, > especially the output parameter @res. Many references to > memparse(const char *ptr, char **retptr) rely on @retptr to work. A > typical example from arch/x86/kernel/e820.c > mem_size = memparse(p, &p); > if (p == oldp) > return -EINVAL; > > userdef = 1; > if (*p == '@') { <----------- here > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RAM); > } else if (*p == '#') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_ACPI); > } else if (*p == '$') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RESERVED); > } > > So we need to resolve the prototype of kstrtoull() firstly, and maybe > kstrtouint() etc too. All of them have lots of references in kernel. > > Any idea about this? Not only this place, a lot of other places, I think no hurry to fix them all at one time. As we talked just do it according to previous reply, mark memparse as obsolete, and create a new function to use kstrtoull, and make it used in crashkernel code first. Thanks Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Mon, 29 Apr 2019 13:04:10 +0800 From: Dave Young Subject: Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant Message-ID: <20190429050410.GA7982@dhcp-128-65.nay.redhat.com> References: <1556087581-14513-1-git-send-email-kernelfans@gmail.com> <10dc5468-6cd9-85c7-ba66-1dfa5aa922b7@suse.com> <20190428083710.GA11981@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pingfan Liu Cc: Rich Felker , linux-ia64@vger.kernel.org, Julien Thierry , Yangtao Li , Benjamin Herrenschmidt , Palmer Dabbelt , Heiko Carstens , Stefan Agner , linux-mips@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner , Logan Gunthorpe , linux-s390@vger.kernel.org, Florian Fainelli , Yoshinori Sato , linux-sh@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King , Ingo Molnar , Hari Bathini , Catalin Marinas , James Hogan , Fenghua Yu , Tony Luck , Will Deacon , Johannes Weiner , Ananth N Mavinakayanahalli , Borislav Petkov , David Hildenbrand , linux-arm-kernel@lists.infradead.org, Jens Axboe , Matthias Brugger , Baoquan He , Ard Biesheuvel , Robin Murphy , kexec@lists.infradead.org, LKML , Ralf Baechle , Thomas Bogendoerfer , Paul Burton , Greg Kroah-Hartman , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Greg Hackmann On 04/29/19 at 12:48pm, Pingfan Liu wrote: > On Mon, Apr 29, 2019 at 11:04 AM Pingfan Liu wrote: > > > > On Sun, Apr 28, 2019 at 4:37 PM Dave Young wrote: > > > > > > On 04/25/19 at 04:20pm, Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > > > > > > > [...] > > > > > > @@ -139,6 +141,8 @@ static int __init parse_crashkernel_simple(char *cmdline, > > > > > > pr_warn("crashkernel: unrecognized char: %c\n", *cur); > > > > > > return -EINVAL; > > > > > > } > > > > > > + if (*crash_size == 0) > > > > > > + return -EINVAL; > > > > > > > > > > This covers the case where I pass an argument like "crashkernel=0M" ? > > > > > Can't we fix that by using kstrtoull() in memparse and check if the return value > > > > > is < 0? In that case we could return without updating the retptr and we will be > > > > > fine. > > > > > > > > > It seems that kstrtoull() treats 0M as invalid parameter, while > > > > simple_strtoull() does not. > > > > > > > > If changed like your suggestion, then all the callers of memparse() > > > > will treats 0M as invalid parameter. This affects many components > > > > besides kexec. Not sure this can be done or not. > > > > > > simple_strtoull is obsolete, move to kstrtoull is the right way. > > > > > > $ git grep memparse|wc > > > 158 950 10479 > > > > > > Except some documentation/tools etc there are still a log of callers > > > which directly use the return value as the ull number without error > > > checking. > > > > > > So it would be good to mark memparse as obsolete as well in > > > lib/cmdline.c, and introduce a new function eg. kmemparse() to use > > > kstrtoull, and return a real error code, and save the size in an > > > argument like &size. Then update X86 crashkernel code to use it. > > > > > Thank for your good suggestion. > > > Go through the v5.0 kernel code, I think it will be a huge job. > > The difference between unsigned long long simple_strtoull(const char > *cp, char **endp, unsigned int base) and int _kstrtoull(const char *s, > unsigned int base, unsigned long long *res) is bigger than expected, > especially the output parameter @res. Many references to > memparse(const char *ptr, char **retptr) rely on @retptr to work. A > typical example from arch/x86/kernel/e820.c > mem_size = memparse(p, &p); > if (p == oldp) > return -EINVAL; > > userdef = 1; > if (*p == '@') { <----------- here > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RAM); > } else if (*p == '#') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_ACPI); > } else if (*p == '$') { > start_at = memparse(p+1, &p); > e820__range_add(start_at, mem_size, E820_TYPE_RESERVED); > } > > So we need to resolve the prototype of kstrtoull() firstly, and maybe > kstrtouint() etc too. All of them have lots of references in kernel. > > Any idea about this? Not only this place, a lot of other places, I think no hurry to fix them all at one time. As we talked just do it according to previous reply, mark memparse as obsolete, and create a new function to use kstrtoull, and make it used in crashkernel code first. Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec