From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F92C43219 for ; Mon, 29 Apr 2019 10:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C9D120656 for ; Mon, 29 Apr 2019 10:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbfD2KQF (ORCPT ); Mon, 29 Apr 2019 06:16:05 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:53489 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727428AbfD2KQE (ORCPT ); Mon, 29 Apr 2019 06:16:04 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hL3KK-0005Gt-1m; Mon, 29 Apr 2019 12:16:00 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hL3KI-0001hH-Bf; Mon, 29 Apr 2019 12:15:58 +0200 Date: Mon, 29 Apr 2019 12:15:58 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Wolfram Sang Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Wim Van Sebroeck , Shawn Guo , Guenter Roeck Subject: Re: [PATCH v3 08/16] watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout Message-ID: <20190429101558.6vyiospb6oqsstt7@pengutronix.de> References: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> <20190419181601.7412-9-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190419181601.7412-9-wsa+renesas@sang-engineering.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 19, 2019 at 08:15:53PM +0200, Wolfram Sang wrote: > The core will print out details now. > > Reviewed-by: Guenter Roeck > Signed-off-by: Wolfram Sang > --- > drivers/watchdog/imx_sc_wdt.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c > index 86c2722f2a09..6dc24ceb1b2c 100644 > --- a/drivers/watchdog/imx_sc_wdt.c > +++ b/drivers/watchdog/imx_sc_wdt.c This driver isn't in next, and I don't know where to look for it. > @@ -117,10 +117,7 @@ static int imx_sc_wdt_probe(struct platform_device *pdev) > imx_sc_wdd->parent = &pdev->dev; > imx_sc_wdd->timeout = DEFAULT_TIMEOUT; > > - ret = watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); > - if (ret) > - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n"); > - > + watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); One side effect is however that ret isn't set any more. So I wonder if a failure in watchdog_init_timeout() really makes the core print the details as expected. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D5EC43219 for ; Mon, 29 Apr 2019 10:16:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 363CC20656 for ; Mon, 29 Apr 2019 10:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I9sLRFiX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 363CC20656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YZuO/6Ki2eD4VhO3Gk/oI49DJ/SADaVt0E3CIFs7UXw=; b=I9sLRFiXVMK/dq o4FQUSvq1/UHgq0EVjHMrK2FwzuYBZn4dm0l6PP8AUNoRZ5GkoydAsr90D15POpOQDLB/Lcwcn192 XUjk7NH6Bx6iqrJ2t13/nYCNvf4LRJ4rYiQWwMNuK3vpoiPcAAzMwlxXM423UNS0rxPLoQVmvVmem 0eifk2+8tQtE/Zdo3/gm4HcVeE4iuPDxrFR5FMsDZF+vKAQOku4blugJarzIcbMs+CQM/A8f2Revu pV+BdyEUXuviLmMuS38eS+rFspDaxenx1P0H/W6ONIlI9i6MGzmFRvdwWAYJEmUs27h/mhNeXmA93 Z9NZo+huMovqk9soZiSA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hL3KR-0001En-A8; Mon, 29 Apr 2019 10:16:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hL3KN-0001Dy-KZ for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2019 10:16:05 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hL3KK-0005Gt-1m; Mon, 29 Apr 2019 12:16:00 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hL3KI-0001hH-Bf; Mon, 29 Apr 2019 12:15:58 +0200 Date: Mon, 29 Apr 2019 12:15:58 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Wolfram Sang Subject: Re: [PATCH v3 08/16] watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout Message-ID: <20190429101558.6vyiospb6oqsstt7@pengutronix.de> References: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> <20190419181601.7412-9-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190419181601.7412-9-wsa+renesas@sang-engineering.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190429_031603_834001_E4C982CC X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-watchdog@vger.kernel.org, Shawn Guo , Sascha Hauer , Guenter Roeck , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Wim Van Sebroeck , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 19, 2019 at 08:15:53PM +0200, Wolfram Sang wrote: > The core will print out details now. > = > Reviewed-by: Guenter Roeck > Signed-off-by: Wolfram Sang > --- > drivers/watchdog/imx_sc_wdt.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > = > diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c > index 86c2722f2a09..6dc24ceb1b2c 100644 > --- a/drivers/watchdog/imx_sc_wdt.c > +++ b/drivers/watchdog/imx_sc_wdt.c This driver isn't in next, and I don't know where to look for it. > @@ -117,10 +117,7 @@ static int imx_sc_wdt_probe(struct platform_device *= pdev) > imx_sc_wdd->parent =3D &pdev->dev; > imx_sc_wdd->timeout =3D DEFAULT_TIMEOUT; > = > - ret =3D watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); > - if (ret) > - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n"); > - > + watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); One side effect is however that ret isn't set any more. So I wonder if a failure in watchdog_init_timeout() really makes the core print the details as expected. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel