From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/7] dmaengine: sprd: Fix the possible crash when getting engine status From: Vinod Koul Message-Id: <20190429113555.GI3845@vkoul-mobl.Dlink> Date: Mon, 29 Apr 2019 17:05:55 +0530 To: Baolin Wang Cc: dan.j.williams@intel.com, eric.long@unisoc.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, broonie@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gMTUtMDQtMTksIDIwOjE0LCBCYW9saW4gV2FuZyB3cm90ZToKPiBXZSB3aWxsIGdldCBhIE5V TEwgdmlydHVhbCBkZXNjcmlwdG9yIGJ5IHZjaGFuX2ZpbmRfZGVzYygpIHdoZW4gdGhlIGRlc2Ny aXB0b3IKPiBoYXMgYmVlbiBzdWJtaXR0ZWQsIHRoYXQgd2lsbCBjcmFzaCB0aGUga2VybmVsIHdo ZW4gZ2V0dGluZyB0aGUgZW5naW5lIHN0YXR1cy4KCk5vIHRoYXQgaXMgd3JvbmcsIHN0YXR1cyBp cyBmb3IgZGVzY3JpcHRvciBhbmQgbm90IGVuZ2luZSEKCj4gSW4gdGhpcyBjYXNlLCBzaW5jZSB0 aGUgZGVzY3JpcHRvciBoYXMgYmVlbiBzdWJtaXR0ZWQsIHdoaWNoIG1lYW5zIHRoZSBwb2ludGVy Cj4gJ3NjaGFuLT5jdXJfZGVzYycgd2lsbCBwb2ludCB0byB0aGUgY3VycmVudCBkZXNjcmlwdG9y LCB0aGVuIHdlIGNhbiB1c2UKPiAnc2NoYW4tPmN1cl9kZXNjJyB0byBnZXQgdGhlIGVuZ2luZSBz dGF0dXMgdG8gYXZvaWQgdGhpcyBpc3N1ZS4KCk5vcGUsIHNpbmNlIHRoZSBkZXNjcmlwdG9yIGlz IGNvbXBsZXRlZCwgeW91IHJldHVybiB3aXRoIHJlc2lkdWUgYXMgMAphbmQgRE1BX0NPTVBMRVRF IHN0YXR1cyEKCj4gCj4gU2lnbmVkLW9mZi1ieTogQmFvbGluIFdhbmcgPGJhb2xpbi53YW5nQGxp bmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZG1hL3NwcmQtZG1hLmMgfCAgICAyICstCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2RtYS9zcHJkLWRtYS5jIGIvZHJpdmVycy9kbWEvc3ByZC1kbWEuYwo+IGlu ZGV4IDQ4NDMxZTIuLmUyOTM0MmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEvc3ByZC1kbWEu Ywo+ICsrKyBiL2RyaXZlcnMvZG1hL3NwcmQtZG1hLmMKPiBAQCAtNjI1LDcgKzYyNSw3IEBAIHN0 YXRpYyBlbnVtIGRtYV9zdGF0dXMgc3ByZF9kbWFfdHhfc3RhdHVzKHN0cnVjdCBkbWFfY2hhbiAq Y2hhbiwKPiAgCQllbHNlCj4gIAkJCXBvcyA9IDA7Cj4gIAl9IGVsc2UgaWYgKHNjaGFuLT5jdXJf ZGVzYyAmJiBzY2hhbi0+Y3VyX2Rlc2MtPnZkLnR4LmNvb2tpZSA9PSBjb29raWUpIHsKPiAtCQlz dHJ1Y3Qgc3ByZF9kbWFfZGVzYyAqc2Rlc2MgPSB0b19zcHJkX2RtYV9kZXNjKHZkKTsKPiArCQlz dHJ1Y3Qgc3ByZF9kbWFfZGVzYyAqc2Rlc2MgPSBzY2hhbi0+Y3VyX2Rlc2M7Cj4gIAo+ICAJCWlm IChzZGVzYy0+ZGlyID09IERNQV9ERVZfVE9fTUVNKQo+ICAJCQlwb3MgPSBzcHJkX2RtYV9nZXRf ZHN0X2FkZHIoc2NoYW4pOwo+IC0tIAo+IDEuNy45LjUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674EDC04AA6 for ; Mon, 29 Apr 2019 11:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 369892075E for ; Mon, 29 Apr 2019 11:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556537773; bh=xrb4idnEqTxEw7YKrCpZyBX26GxTnwHkDH99g213PQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j1soyas2zZJo/l2g2VsYFXQ3MOAq6DO9GjUnATi+neQcznu0qC4k+Y4MYm4ZUAUZj hmvJKpLPuDc1rIQkw/DF0FSM6heJ/eBwbCcofbhngmVBvSAgQL1co9GOHj9ItRMJfw csyAS6LxyEa0qznuLjBe4mYHypWxS3TUJWi56xmM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728016AbfD2LgI (ORCPT ); Mon, 29 Apr 2019 07:36:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:43518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727986AbfD2LgH (ORCPT ); Mon, 29 Apr 2019 07:36:07 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B69482075E; Mon, 29 Apr 2019 11:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556537766; bh=xrb4idnEqTxEw7YKrCpZyBX26GxTnwHkDH99g213PQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VEW+K+47fN2uG7Z1EKCt2g8fTb1RQbfUPM6mxN3KWl5FiTdqryFkRGMrfXCZje2El EeJIuGirmR+BnFAi+o/wbYHW29KWlDOoHDWrqRXlEFFUwVN8kKX/1JWTGcAJMeT3Y5 bvzr+DdI92iexlvpfVvTrkptqj5Xg8GNxGNLIudI= Date: Mon, 29 Apr 2019 17:05:55 +0530 From: Vinod Koul To: Baolin Wang Cc: dan.j.williams@intel.com, eric.long@unisoc.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, broonie@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] dmaengine: sprd: Fix the possible crash when getting engine status Message-ID: <20190429113555.GI3845@vkoul-mobl.Dlink> References: <2eecd528e85377f03e6fbc5e7d6544b9c9f59cb1.1555330115.git.baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <2eecd528e85377f03e6fbc5e7d6544b9c9f59cb1.1555330115.git.baolin.wang@linaro.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190429113555.Z5d2gk_jwRzCHZ3fDDPijZ0SadwA0OXwQSSrNpDXin0@z> On 15-04-19, 20:14, Baolin Wang wrote: > We will get a NULL virtual descriptor by vchan_find_desc() when the descriptor > has been submitted, that will crash the kernel when getting the engine status. No that is wrong, status is for descriptor and not engine! > In this case, since the descriptor has been submitted, which means the pointer > 'schan->cur_desc' will point to the current descriptor, then we can use > 'schan->cur_desc' to get the engine status to avoid this issue. Nope, since the descriptor is completed, you return with residue as 0 and DMA_COMPLETE status! > > Signed-off-by: Baolin Wang > --- > drivers/dma/sprd-dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > index 48431e2..e29342a 100644 > --- a/drivers/dma/sprd-dma.c > +++ b/drivers/dma/sprd-dma.c > @@ -625,7 +625,7 @@ static enum dma_status sprd_dma_tx_status(struct dma_chan *chan, > else > pos = 0; > } else if (schan->cur_desc && schan->cur_desc->vd.tx.cookie == cookie) { > - struct sprd_dma_desc *sdesc = to_sprd_dma_desc(vd); > + struct sprd_dma_desc *sdesc = schan->cur_desc; > > if (sdesc->dir == DMA_DEV_TO_MEM) > pos = sprd_dma_get_dst_addr(schan); > -- > 1.7.9.5 -- ~Vinod