From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@kernel.org, bp@alien8.de, hpa@zytor.com,
kirill.shutemov@linux.intel.com, keescook@chromium.org,
peterz@infradead.org, thgarnie@google.com,
herbert@gondor.apana.org.au, mike.travis@hpe.com,
frank.ramsay@hpe.com, yamada.masahiro@socionext.com
Subject: Re: [PATCH v3 RESEND 2/2] x86/mm/KASLR: Fix the size of vmemmap section
Date: Mon, 29 Apr 2019 16:16:12 +0300 [thread overview]
Message-ID: <20190429131612.y7ee2hbujeondcko@kshutemo-mobl1> (raw)
In-Reply-To: <20190429081246.GT3584@localhost.localdomain>
On Mon, Apr 29, 2019 at 04:12:46PM +0800, Baoquan He wrote:
> > > + * Calculate how many TB vmemmap region needs, and aligned to
> > > + * 1TB boundary.
> > > + */
> > > + vmemmap_size = (kaslr_regions[0].size_tb << (TB_SHIFT - PAGE_SHIFT)) *
> > > + sizeof(struct page);
> >
> > Hm. Don't we need to take into account alignment requirements for struct
> > page here? I'm worried about some exotic debug kernel config where
> > sizeof(struct page) doesn't satify __alignof__(struct page).
>
> I know sizeof(struct page) has handled its own struct alignment and
> padding.
I didn't realize that. Sorry for the noise.
Acked-by: Kirill A. Shutemov <kirill@linux.intel.com>
--
Kirill A. Shutemov
prev parent reply other threads:[~2019-04-29 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 7:28 [PATCH v2 RESEND 0/2] x86/mm/KASLR: Fix the wrong size of memory sections Baoquan He
2019-04-14 7:28 ` [PATCH v2 RESEND 1/2] x86/mm/KASLR: Fix the size of the direct mapping section Baoquan He
2019-04-15 18:53 ` Borislav Petkov
2019-04-17 8:35 ` Baoquan He
2019-04-17 15:01 ` Borislav Petkov
2019-04-17 22:42 ` Baoquan He
2019-04-18 8:52 ` [tip:x86/urgent] " tip-bot for Baoquan He
2019-04-14 7:28 ` [PATCH v2 RESEND 2/2] x86/mm/KASLR: Fix the size of vmemmap section Baoquan He
2019-04-15 19:47 ` Borislav Petkov
2019-04-17 8:39 ` Baoquan He
2019-04-26 9:23 ` Baoquan He
2019-04-26 10:04 ` Borislav Petkov
2019-04-26 10:18 ` Baoquan He
2019-04-22 9:10 ` [PATCH v3 " Baoquan He
2019-04-22 9:14 ` Baoquan He
2019-04-28 18:54 ` Kirill A. Shutemov
2019-04-29 8:12 ` Baoquan He
2019-04-29 13:16 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429131612.y7ee2hbujeondcko@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=frank.ramsay@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.